From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2242BC10F14 for ; Fri, 4 Oct 2019 01:03:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA22D20862 for ; Fri, 4 Oct 2019 01:03:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NeL4DZlM"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="f/4MRmjK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA22D20862 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gmx.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UBBtMXh2ZM7leT7LF0dhAry2+IMWW+VMlQPuyyt6PY4=; b=NeL4DZlMStEh1a r/OAltctY6nZN7wx8k0xKfqRvDOoDReRXOESrIGkOoHnjGJtjd7b7NbToL8oKz+4OronQGYYG6eMI n31thCzSmMOidVJQF2ijvn45gROzdO5wc69t3BLMqdDtg8UlzePcALDUuS24Mr7dmQZZvyyw44YXy 0LMLA+5v6kHtMpIWZklfmslicEwmqY2G70SnSnrt7KYLeR/rrtMAxLAeg+c1xt/krIsqqn51qH4OS M3Gvdt43qVNOeRkv1GRU+fcJPOvJUuh0uXjAybCKEk7V/PtoM+STAofEMKci4qZGmttCExBLq8QVq Z7uDvhyRvvvFt7BotCJA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGC0e-0004Ng-HD; Fri, 04 Oct 2019 01:03:52 +0000 Received: from mout.gmx.net ([212.227.17.20]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGC0a-0004Mz-Ua for linux-arm-kernel@lists.infradead.org; Fri, 04 Oct 2019 01:03:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1570150984; bh=JTN0Ilj44RKQef7zRIqRK8zyV4uPBiX8s88kgrgIQ6E=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=f/4MRmjK1IfZXHiY1UIpIwKukgT8+/SyMf7I3gVy4mTB7gGk/q42vAUF8MLIhRnLQ VG/Tr4pzGkP8HyCfeM/NH0EJCrzCCKNnEaSt0qzhTeK6v8Q4nmqXFrIdHMpIK1ybq4 8r4BN0SfrzxCV1grNLLI2bnOK9x7uyx8d7UQO92w= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.162] ([37.4.249.116]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MZTmY-1iad4g2lmg-00WU0j; Fri, 04 Oct 2019 03:03:04 +0200 Subject: Re: [PATCH V3 0/8] ARM: Add minimal Raspberry Pi 4 support To: Matthias Brugger , Eric Anholt , Guillaume Gardet , Mark Rutland , Ray Jui , Scott Branden , Florian Fainelli , Adrian Hunter , Rob Herring , Nicolas Saenz Julienne References: <1569672435-19823-1-git-send-email-wahrenst@gmx.net> <3853cd8425743b4991f5d599ec1c0fbbf4232f95.camel@suse.de> <420c18a3-d458-8115-ef00-f1cb4febe3b0@suse.com> From: Stefan Wahren Message-ID: Date: Fri, 4 Oct 2019 03:03:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <420c18a3-d458-8115-ef00-f1cb4febe3b0@suse.com> Content-Language: en-US X-Provags-ID: V03:K1:D/CzcFZMPePatrFrXpghROyf5JWEgoewYoagTMnM7RzIdvTronB v1xK1VPIuExh0wByfXxbL3KwfsrhQk+h1Czz9EGJ1uf6zdCKsI/sJalt+vcph8yBrNQT3m5 hbj8lJoscsGj8kPQYnP435qiRNRsbNM4nBXvl6t33hSfDrTok2ZCLbnzwiUbXYLEgYTXV7e 4p+Uj5uZL2XBcvcriR8Vg== X-UI-Out-Filterresults: notjunk:1;V03:K0:i935t8EHEg0=:e4ZlMH/+xjvINkaw8ILfeV 7ibTs+hRtVGhzGFaqKxbBlZwtzQV/3A0RjMCqn2PPzJJZGwPEDDyTFGgpP9Po7Gh1+KsTlafJ KFCN/neBebtwvoA+o76CtcOlVQuExLI2KhNFHfFnxpe6jGeoQaRF8qzHhTmhGKDeZviDnnDiq VKCV6U9Z6+hPqX/uun245V9TFy68h+wAySqOJzei1C5Anqa5Yy7dhyjRRXAYDyFQdZYX6I9Ok yTSOWdZpBgkqWGqzQJbRyvTywqN2Dsznt6y8w2LoOJKaIgkKfleygmjENnZlxV9g5oYCUgbjf qqoAnTLgceHhmEk/eqUduA8nQ3vrXUzfS2uORnzgrVw46c65fJmQy6+WLqy7+MeRotv+AP0zM r99M5FTweGTYMmTSFulZrxc6bM53ajuJdN77eE26d47OeknN0PeE+iJ4fAtQhXu3teZb7HuAQ WWKgef3uyE93BOm5SHVuhpNqTQOLljdCcFCkhJR67Edqv+ubud/JXwVibByn52Xq+n8c97tQz ZKaNNmGa7prpLm3bGeDdEhaeLSYuh9K/WKQ9W7uYxz2icMF6+YtrZO1+qdkRY63SGCTlcRAuH H4IdnN6seeaLdasw7PbAZP42zreCRj7r0FQHyhHkNU7Y8G3kqLRHrpmvbOSSl96PfaIPmQEdZ KPEieQW+mTpvrI1r7sVCYS5mgf8tlffutHys93gplojUYTnfh1NsjEKH5Tm1awiCBrHzYQbHA JQ5bKdG+4ZhoaTGhDJeNd4dfipDcZYm00U9jGlGOpdccrP0cA4gEZokqWDYHTaa+Tp2JXSD0w dy0u1caUQbU7yGtsfDFR/v08c113gQzL3rCCSsKMJT9QDt01m536QcXof2aTWWEj6pJSVNejN YF1+G0iIvwVW38gvnI+VcrUlaVs0sRCCtzXeCDcgWJUbgEUII2vIIBx4efDcDXrW4NyEONKpS fNvWOUyCKeWFzWkM9G4lsMhngQfRThHLzHRqTt0tdXVi1I36Ym2DYnpE8L+jOWD9hBLpnqx4d 8oQHSv/WxTj7PyfgfxxkFUslaQTiUMb48tybSVdaTPZEbS9LAgPJx4nARigO5ORNUblp51b1N SMnHKASXuy2pBiR9zHgTVFiwPUhLYPELfJiBVcP9dS9YNRQX5u4G+1L2zv5irnrMJvpSsAHd9 V6w08wnZY2zU9lDtSyhi7T829nTFg4I90IoYN86+G4N7W8CfPi5tZWXhHqaVpBC0mD8ENSY2V VY+ct3z4scjtZR+BEn0srTWsEX2r1VFEkuSYbxJlYgDnygHwHyzqiAfpiJDI= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191003_180349_394225_34569D5A X-CRM114-Status: GOOD ( 22.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am 04.10.19 um 00:42 schrieb Matthias Brugger: > > On 03/10/2019 19:24, Stefan Wahren wrote: >> Hi Nicolas, >> >> Am 03.10.19 um 19:09 schrieb Nicolas Saenz Julienne: >>> On Sat, 2019-09-28 at 14:07 +0200, Stefan Wahren wrote: >>>> This series adds minimal support for the new Raspberry Pi 4, so we are able >>>> to login via debug UART. >>>> >>>> Patch 1-2: Fix some DT schema warnings >>>> Patch 3-4: Prepare DTS for the new SoC BMC2711 >>>> Patch 5-7: Add Raspberry Pi 4 DTS support >>>> Patch 8: Update MAINTAINERS >>>> >>>> Unfortunately the Raspberry Pi Foundation didn't released a >>>> peripheral documentation for the new SoC yet. So we only have a preliminary >>>> datasheet [1] and reduced schematics [2]. >>>> >>>> Known issues: >>>> Since Linux 5.3-rc1 DMA doesn't work properly on that platform. >>>> Nicolas Saenz Julienne investigates on that issue. As a temporary workaround >>>> i reverted the following patch to test this series: >>>> >>>> 79a98672 "dma-mapping: remove dma_max_pfn" >>>> 7559d612 "mmc: core: let the dma map ops handle bouncing" >>> [ adding Matthias and Guillaume who first saw this ] >>> [ also adding Adrian Hunter just in case ] >>> >>> Hi, >>> we stubled upon a bug in RPi's sdhci-iproc while testing this series. >>> >>> It only shows-up on slow SD cards, the class 4 ones. On each SD operation we >>> get the following warning: >>> >>> [ 2.093328] mmc1: Got data interrupt 0x00000002 even though no data operation was in progress. >>> [ 2.102072] mmc1: sdhci: ============ SDHCI REGISTER DUMP =========== >>> [ 2.108603] mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00001002 >>> [ 2.115134] mmc1: sdhci: Blk size: 0x00007200 | Blk cnt: 0x00000000 >>> [ 2.121664] mmc1: sdhci: Argument: 0x00000000 | Trn mode: 0x00000033 >>> [ 2.128195] mmc1: sdhci: Present: 0x1fff0000 | Host ctl: 0x00000017 >>> [ 2.134725] mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000080 >>> [ 2.141255] mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00000107 >>> [ 2.147785] mmc1: sdhci: Timeout: 0x00000000 | Int stat: 0x00000000 >>> [ 2.154314] mmc1: sdhci: Int enab: 0x03ff100b | Sig enab: 0x03ff100b >>> [ 2.160843] mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000 >>> [ 2.167373] mmc1: sdhci: Caps: 0x45ee6432 | Caps_1: 0x0000a525 >>> [ 2.173902] mmc1: sdhci: Cmd: 0x00000c1a | Max curr: 0x00080008 >>> [ 2.180432] mmc1: sdhci: Resp[0]: 0x00000b00 | Resp[1]: 0x00edc87f >>> [ 2.186961] mmc1: sdhci: Resp[2]: 0x325b5900 | Resp[3]: 0x00400e00 >>> [ 2.193490] mmc1: sdhci: Host ctl2: 0x00000001 >>> [ 2.197992] mmc1: sdhci: ADMA Err: 0x00000000 | ADMA Ptr: 0xec040208 >>> [ 2.204521] mmc1: sdhci: ============================================ >>> >>> Aside from the serial console noise the RPi still boots alright. But as it's >>> printing one of these per SD operation which is a lot... >>> >>> I've been able to reproduce this both with arm and arn64 on multiple SD cards. >>> Just copying the contents of a class 4 card into a class 10 one fixes the >>> issue. >>> >>> Any ideas? >> i saw this once during testing. AFAIR there has been some changes to >> sdhci in the downstream tree, maybe they was related to this issue. > I did a diff against drivers/mmc/host/sdhci-iproc.c of v5.4-rc1 and haven't > found any significant changes: > - compatible in the upstream driver is only bcm2711-emmc2 and not bcm2838-sdhci, > but DTS uses the former one. > - Upstream driver support probing via ACPI. > - pltfm_host->clk gets only set if we probe via DTS > - get_max_clock() is set to sdhci_iproc_get_max_clock() but this checks if > pltfm_host->clk is set and in that case invokes sdhci_pltfm_clk_get_max_clock() > (same function as the downstream driver). > > So AFAIKS nothing relevant here. as i wrote about sdhci, i literally meant this driver [1]. But this looks like a workaround only. [1] - https://github.com/raspberrypi/linux/commit/88b35d4338e238519bf4e6f73837b4ce44bfe4d6 > > Regards, > Matthias > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel