From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00192CF34B0 for ; Thu, 3 Oct 2024 16:48:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RW5P1Arx8XPYT/NPFqMkITFeiGycXbJcANO3qtPPvbA=; b=rxEZkaZq3HATwE48fV1TzRCyAt BiCL5RS7NkEaDM2c/scAzRZ0mIqIQY1am9HUrF1FlaJqU8JmofgPfxCcf0H+Iug6Fw8E84uo6xZZ9 9CgDyhdl7p3Cb4Nulfq0fPPAWXTp4iLFVnJ/8qf1Hflt5ZEssoskNfjtUeFX3xHilmmfM62mqwqvA slRcIBUp7V+cv0GifsSKwu0mQNNIMsynE2hXzB7aoP4VioL3ITZpTZ5UfbWL1NYDtQVmd9nWL4gf5 alRZPMo3c80T7eE0KalUVEkBnI2onxlJtsGU8FXc22debszjj8Ao3KGEOUNhs/AUhafMx0HatKnIE MBXB5vPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1swP0T-00000009rbt-0fEO; Thu, 03 Oct 2024 16:48:49 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1swOyd-00000009rEk-3B4Z for linux-arm-kernel@lists.infradead.org; Thu, 03 Oct 2024 16:46:57 +0000 Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-7db233cef22so878939a12.0 for ; Thu, 03 Oct 2024 09:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727974015; x=1728578815; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RW5P1Arx8XPYT/NPFqMkITFeiGycXbJcANO3qtPPvbA=; b=lNm8HC+Vzdn2PkLyiju+1SGrCxTPpHjhjH9lt8jTmb1UvXAVnn75b/Hg53FO57xu6j SrPrhoHUJ1emeE11FeKsoh5aHV3aZ1dxIC06WmiW9vMNb7GM6AOEb1rDs14H+Cb7hxCl MPnz1LOCHcHRpNlsCTksYvrJi3q1ILeZnwgoJ2QguZDpK49gYtepBRF1pHITkirCQNGS Ht+yJ7gHcplObHP6m3p2iRFS2BkppisGLNACC7fu36s6PdVyDmkuIZmPtjGL/7q1Nrui Cy0Wg9gUJZxhoIbWjf6iv8ZKoIRYMOOoxsZtwt4u4kLh2rl0alYLoZ8omLKzM6h3aR2n E02w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727974015; x=1728578815; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RW5P1Arx8XPYT/NPFqMkITFeiGycXbJcANO3qtPPvbA=; b=ObIkioz9ikyyfhXmhgZXko97wn5nH3Wd9kzwvvMYdNpPat1s+GEWmQGKpKeOTlyohQ 6lPupN/3DH7jAaEkSEpNLEv/rm16s9ThCnuksYqnTw5yC1YHUSyvDIET+ZNZb959sqHL nFb//MnZe1x0qg4wZvSVkOsrvwiP7AU3JbTWj0vJLV3Fw+8zbgn3t0l9GYo4xXUz4UTR vaY+Yv5LS3QaYzTolwO3NUHl56DnJBShejpxcokrFg8Yn3PrX66uXwclNOqIV0NHlxKz glSMbSFPyvlvVsHrEr3wK6scTOHxLopGxQuftPCaoc50tZOCyUDvbtAlpPM7LfYlMVaP AQbA== X-Gm-Message-State: AOJu0Yx9+7umVNim0LWZ9GyQXhFGC0H3M9+750xNtDSXuOKX4LpoPHQE f413kRbB1d56S6MogheV0Mkehgl1SiRUWuBcKaQ+a4j1kotMPF/0FM8EMRlm84k= X-Google-Smtp-Source: AGHT+IHrNLnq312K7GVWKGT1Vo9Ff69i9ensfXAZGMY12ruPSu/BXqZiVZ26a2jiItIAw0CUa22nFw== X-Received: by 2002:a05:6a20:cf84:b0:1d2:e8f6:81e with SMTP id adf61e73a8af0-1d5db1bf932mr10105522637.24.1727974014772; Thu, 03 Oct 2024 09:46:54 -0700 (PDT) Received: from [192.168.0.4] (174-21-81-121.tukw.qwest.net. [174.21.81.121]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7e9dbcf13b6sm1055380a12.8.2024.10.03.09.46.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2024 09:46:54 -0700 (PDT) Message-ID: Date: Thu, 3 Oct 2024 09:46:50 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 01/10] Consolidate IO memcpy/memset into iomap_copy.c To: Julian Vetter , Arnd Bergmann , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Huacai Chen , WANG Xuerui , Andrew Morton , Geert Uytterhoeven , Ivan Kokshaysky , Matt Turner , "James E . J . Bottomley" , Helge Deller , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Richard Weinberger , Anton Ivanov , Johannes Berg Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-alpha@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, Yann Sionneau References: <20240930132321.2785718-1-jvetter@kalrayinc.com> <20240930132321.2785718-2-jvetter@kalrayinc.com> Content-Language: en-US From: Richard Henderson In-Reply-To: <20240930132321.2785718-2-jvetter@kalrayinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241003_094655_930787_2BB48BA0 X-CRM114-Status: UNSURE ( 8.30 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/30/24 06:23, Julian Vetter wrote: > +void memset_io(volatile void __iomem *dst, int c, size_t count) > +{ > + uintptr_t qc = (u8)c; Missed one change to 'long' > + > + qc |= qc << 8; > + qc |= qc << 16; > + > +#ifdef CONFIG_64BIT > + qc |= qc << 32; > +#endif Could be 'qc *= -1ul / 0xff;' r~