From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 177D5C3DA7F for ; Wed, 31 Jul 2024 22:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Mjq0uGvQN66zPwFq4xAVJqxHjAgjcl9vjk3Xwdos2JI=; b=PXagtP0XSxx/ZmJCiHCHoleSpf w4amcEOQZXMi4fsJeZIfykA0dMeP2yurrLztoLAwSUrymsxCUiSTXvGi7I0XptsobXSQUEjCeirW3 3lGJCzThDqdn2QcI39CYvRWwiVp7HbD65HVAJAqhkaDRxFdvgZH+2ywsymjdzy4Oe7bOqMzqxSeKK oBJmdd3E3iroXHxR42wZV5URD6INFyuJ9ox9j/dU66nrmRaScB145Cx3dcwDbhREem3OSbHBqFkLg nTC+44J1un9XvhC6l0yZAUq1CJQpAPGO5SVP5BIxd6In+Mh/3rEZb/2MVkSznC5BLR9ZqfXsThBHm vQ39txRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZHY2-00000002fjF-03Ij; Wed, 31 Jul 2024 22:11:54 +0000 Received: from mail-qv1-xf2a.google.com ([2607:f8b0:4864:20::f2a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZHXZ-00000002fbr-19c8 for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2024 22:11:26 +0000 Received: by mail-qv1-xf2a.google.com with SMTP id 6a1803df08f44-6b7acf213a3so32704176d6.1 for ; Wed, 31 Jul 2024 15:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722463884; x=1723068684; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Mjq0uGvQN66zPwFq4xAVJqxHjAgjcl9vjk3Xwdos2JI=; b=aivglg/8FPu/dWAoNoP6P2oClLMiRt1O4vMM90N08tkDmsxQMMnixuYb9UG0nDwgrE WU3M4DWyhzy7vrGjRBSPlbNKOsAVkHJsC0a7GNqKHk4UqQZ0shGwIsQRX5Zz178Opqhs K6uHRLFvGMIoo6vWkDeKhEknd8GbjF/wdQVrjsBARkI1QSn2ITUjFfdjDzHEcsrz7+aL Uoz/hYVCF9KD8G4wXFd73jDaHxhthnEtM3agG2lPboVjPatj3G7AIQcORLKkmybsJjZU QgNfFL+VEQ6bNPqfs1/WunfhM3C9sGuaCs1f0ZWpyENRRRompjDiTH6eGyX76W+USPbd KZqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722463884; x=1723068684; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Mjq0uGvQN66zPwFq4xAVJqxHjAgjcl9vjk3Xwdos2JI=; b=dNeBzhJwNpAWsyBzHBo51Rdagphcp184V0yujmbnRMfXmTJPTIOkCwM3juxTtcGRPr T70ht7zTn3C3/D0UBWe7Vcnn6IsBQqgPy85x8g3xlzldG1tM68gUA6HfKazM6mllcuQ2 OpfBFr2SeSk2/gmPIGIG0zdvv1Yuu/BpIzllcneopLzdLtXodg1nD594NRWvrnTBMY4G GLkNkQLf7rfJnyIn05hOGD27GqSBcJwUXVIdoKVAG01tedZSPVZ7Ki/CPy8OmVEWYZJQ lnPe6+iQqXSZl4uCojv4r9AYg2p2Sst3CKdOCqNw/YljiRYl6JQwwjV3eHijeuVWaccK 2vVw== X-Forwarded-Encrypted: i=1; AJvYcCW0VOndvsF8qIuSJtokcD/alloknoZAGC/LsFH5/X8jxdZs7CAcxH6ypTilkP3iHdqizpIeLgtb2I1KwFQn2b24rF5yrDbfOq/Gm8ZnP/fGl0W8IqY= X-Gm-Message-State: AOJu0Yzxrr5Z95qNbVZYt/S77iNSNrVgg8DXR/cYM9xxGXSMI8GSU4KS Vu32pYA5i7q2gF11ExO5qUvlwFIkQuZDEfvv3tF+O6yqsgIfUumU X-Google-Smtp-Source: AGHT+IEq4useatLIy7yrsLLnlLbqusQC7mzUooi7ll7ykBhHD8pleYpSETX6KTgn18+TeQTdHq9q0A== X-Received: by 2002:a05:6214:5986:b0:6b5:e451:81d0 with SMTP id 6a1803df08f44-6bb8d6818d0mr8382886d6.3.1722463883626; Wed, 31 Jul 2024 15:11:23 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id 6a1803df08f44-6bb3fad8c0bsm78448786d6.120.2024.07.31.15.11.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jul 2024 15:11:23 -0700 (PDT) Message-ID: Date: Wed, 31 Jul 2024 15:11:19 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/7] arm64: dts: broadcom: bcm2712: Add one more GPIO node To: "Ivan T. Ivanov" , linus.walleij@linaro.org, robh@kernel.org, krzk+dt@kernel.org Cc: conor+dt@kernel.org, florian.fainelli@broadcom.com, wahrenst@gmx.net, andrea.porta@suse.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240731062814.215833-1-iivanov@suse.de> <20240731062814.215833-6-iivanov@suse.de> Content-Language: en-US From: Florian Fainelli In-Reply-To: <20240731062814.215833-6-iivanov@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240731_151125_349042_B3C86D19 X-CRM114-Status: GOOD ( 15.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/30/24 23:28, Ivan T. Ivanov wrote: > Add GPIO and related interrupt controller nodes and wire one > of the lines to power button. > > Signed-off-by: Ivan T. Ivanov > --- > .../boot/dts/broadcom/bcm2712-rpi-5-b.dts | 21 +++++++++++++++++++ > arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 21 +++++++++++++++++++ > 2 files changed, 42 insertions(+) > > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > index 8a0d20afebfe..06e926af16b7 100644 > --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > @@ -2,6 +2,7 @@ > /dts-v1/; > > #include > +#include > #include "bcm2712.dtsi" > > / { > @@ -44,6 +45,21 @@ sd_vcc_reg: sd-vcc-reg { > enable-active-high; > gpios = <&gio_aon 4 GPIO_ACTIVE_HIGH>; > }; > + > + pwr-button { > + compatible = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pwr_button_pins>; > + status = "okay"; > + > + pwr_key: pwr { > + label = "pwr_button"; > + linux,code = ; > + gpios = <&gio 20 GPIO_ACTIVE_LOW>; > + debounce-interval = <50>; > + }; > + }; > }; > > /* The system UART */ > @@ -73,6 +89,11 @@ emmc_aon_cd_pins: emmc-aon-cd-pins { > }; > > &pinctrl { > + pwr_button_pins: pwr-button-pins { > + function = "gpio"; > + pins = "gpio20"; > + bias-pull-up; > + }; > > emmc_sd_pulls: emmc-sd-pulls { > pins = "emmc_cmd", "emmc_dat0", "emmc_dat1", "emmc_dat2", "emmc_dat3"; > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi > index 1099171cd435..39d2419ffce2 100644 > --- a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi > +++ b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi > @@ -271,6 +271,27 @@ pinctrl: pinctrl@7d504100 { > reg = <0x7d504100 0x30>; > }; > > + main_irq: intc@7d508400 { > + compatible = "brcm,bcm7271-l2-intc"; > + reg = <0x7d508400 0x10>; > + interrupts = ; > + interrupt-controller; > + #interrupt-cells = <1>; > + }; > + > + gio: gpio@7d508500 { > + compatible = "brcm,brcmstb-gpio"; > + reg = <0x7d508500 0x40>; > + interrupt-parent = <&main_irq>; > + interrupts = <0>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + brcm,gpio-bank-widths = <32 22>; > + brcm,gpio-direct; Undocumented and unsupported property upstream, what does it do? Other than that, LGTM. -- Florian