From: Vyacheslav <adeep@lexina.in>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
George Stark <gnstark@sberdevices.ru>
Cc: jic23@kernel.org, lars@metafoo.de, neil.armstrong@linaro.org,
khilman@baylibre.com, jbrunet@baylibre.com,
andy.shevchenko@gmail.com, nuno.sa@analog.com,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@sberdevices.ru
Subject: Re: [PATCH v1] meson saradc: fix clock divider mask length
Date: Wed, 17 May 2023 14:37:37 +0300 [thread overview]
Message-ID: <a52335ea-6545-8ca6-d318-38b7ffc64368@lexina.in> (raw)
In-Reply-To: <CAFBinCCc+t7Ks6fqz38cVrufPRFdxFgC9Qp+JhcM1KfD6pupTg@mail.gmail.com>
Hi, Martin,
On 16.05.2023 22:08, Martin Blumenstingl wrote:
> Hi George,
>
> thank you for this patch!
>
> On Mon, May 15, 2023 at 11:06 PM George Stark <gnstark@sberdevices.ru> wrote:
>>
>> From: George Stark <GNStark@sberdevices.ru>
>>
>> According to datasheets of supported meson SOCs
>> length of ADC_CLK_DIV field is 6 bits long
> I have a question about this sentence which doesn't affect this patch
> - it's only about managing expectations:
> Which SoC are you referring to?
I checked the 905x, 905x3, a113x datasheets - there is the same register
with 6 bits for ADC_CLK_DIV
> This divider is only relevant on older SoCs that predate GXBB (S905).
> To my knowledge all SoCs from GXBB onwards place the divider in the
> main or AO clock controller, so this bitmask is irrelevant there.
>
>> Fixes: 3adbf3427330 ("iio: adc: add a driver for the SAR ADC found in Amlogic Meson SoCs")
>> Signed-off-by: George Stark <GNStark@sberdevices.ru>
> Since my question above doesn't affect this patch:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
--
Vyacheslav Bocharov
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-17 11:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 21:05 [PATCH v1] meson saradc: fix clock divider mask length George Stark
2023-05-16 8:22 ` neil.armstrong
2023-05-16 19:08 ` Martin Blumenstingl
2023-05-17 9:21 ` Dmitry Rokosov
2023-05-17 11:37 ` Vyacheslav [this message]
2023-05-17 19:28 ` Martin Blumenstingl
2023-05-22 9:04 ` Dmitry Rokosov
2023-05-22 15:47 ` Старк Георгий Николаевич
2023-05-29 20:41 ` Martin Blumenstingl
2023-05-31 11:33 ` George Stark
2023-06-01 20:52 ` George Stark
2023-06-05 20:18 ` Martin Blumenstingl
2023-06-06 12:53 ` George Stark
2023-05-17 16:47 ` Старк Георгий Николаевич
2023-05-20 15:46 ` Jonathan Cameron
2023-05-21 8:53 ` Andy Shevchenko
2023-05-22 9:11 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a52335ea-6545-8ca6-d318-38b7ffc64368@lexina.in \
--to=adeep@lexina.in \
--cc=andy.shevchenko@gmail.com \
--cc=gnstark@sberdevices.ru \
--cc=jbrunet@baylibre.com \
--cc=jic23@kernel.org \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox