From: Krzysztof Kozlowski <krzk@kernel.org>
To: Faraz Ata <faraz.ata@samsung.com>,
alim.akhtar@samsung.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
rosa.pila@samsung.com, dev.tailor@samsung.com,
suyash.bitti@samsung.com
Subject: Re: [PATCH v2] arm64: dts: exynos: Add DT node for all UART ports
Date: Sat, 12 Apr 2025 12:11:17 +0200 [thread overview]
Message-ID: <a52969f2-8ea2-41e5-b4c8-8a03220cbf51@kernel.org> (raw)
In-Reply-To: <03e501dbaab0$65bb47a0$3131d6e0$@samsung.com>
On 11/04/2025 09:07, Faraz Ata wrote:
> Hello Krzysztof
>
>> Subject: Re: [PATCH v2] arm64: dts: exynos: Add DT node for all UART ports
>>
>> On 18/03/2025 08:56, Faraz Ata wrote:
>>> +
>>> + usi_17: usi@10d800c0 {
>>
>> Messed order. Keep nodes sorted by unit address (see DTS coding style).
>>
>>
> Thanks for your review
> Based on the DTS coding style, it is acceptable to group nodes
> of the same type together, even if it breaks the unit address ordering.
That's accepted alternative because some subsystems do that way. I don't
think we ever applied such rule to Samsung? Do you have any prior
reference about this? I accepted mess in the past, but that does not
mean that mess is the rule.
> https://docs.kernel.org/6.12/devicetree/bindings/dts-coding-style.html
> Please let me know your opinion on this.
> Do you mean I should move all the USI_ node after pwm node?
Please it according to sorting by unit address.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-12 10:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250318074801epcas5p3de68627a3e64ebc2a95ed33a3f485e80@epcas5p3.samsung.com>
2025-03-18 7:56 ` [PATCH v2] arm64: dts: exynos: Add DT node for all UART ports Faraz Ata
2025-03-26 4:11 ` Alim Akhtar
2025-04-07 6:04 ` Krzysztof Kozlowski
2025-04-11 7:07 ` Faraz Ata
2025-04-12 10:11 ` Krzysztof Kozlowski [this message]
2025-04-17 5:03 ` Faraz Ata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a52969f2-8ea2-41e5-b4c8-8a03220cbf51@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=dev.tailor@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=faraz.ata@samsung.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rosa.pila@samsung.com \
--cc=suyash.bitti@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).