From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 938AAC2BD09 for ; Thu, 27 Jun 2024 23:32:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w5mZuuNcE7Xkp1x76DIFUq6yfiTcBZqMgG4awABhgIs=; b=KZYgwDJWvlgTzsbSEI3zkZgYfE j/JdWtOgM8CZd/RhOm1Zi9qGQxlo//HabIyaoVFHgtDgFQcc7RDOF7pCePcpgnPnF7N2qihjtpCkh ALwQ/POR7vOFH70V8pg6FfXbhQH7kO3iJPmOEqCWb0MxXiMg07wffntvhKuRjOmbeEw40JBL68iS1 XB++BlRUS/LCkBinjdw7oQXQ9nzIdpV2RbsZEWqCV3F/6ywnQgmeqhgoRLk97yESyWq0H0IFNjPyJ /xr6wREJGjYMGrY5HIDddi+6KoPa9/ol8Rizgcawug11CNzQcS/v/rwvZryxs+LYp/Tz3KaWbq8CE +BhuucoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMyb5-0000000ByqB-38mi; Thu, 27 Jun 2024 23:32:11 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMyal-0000000Byiy-0s0u for linux-arm-kernel@lists.infradead.org; Thu, 27 Jun 2024 23:31:53 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 45RNVl3R064876; Thu, 27 Jun 2024 18:31:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1719531107; bh=w5mZuuNcE7Xkp1x76DIFUq6yfiTcBZqMgG4awABhgIs=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=QOnWX2yzPKlly3Qr3lKqihyM26enXc+BpHRq/3hYu9quam6rduLCtLbEEqjSRzbr6 zAgZKs+KnSL1EQBmSjbaqJo+5uAf9Tb8nO3Bz2qnpu13LOeXWYjZQ1oY3TSbZrKfMT sMg3piJFwoGq08L3XDvIe5r/u1PjjT81n030bvSk= Received: from DLEE106.ent.ti.com (dlee106.ent.ti.com [157.170.170.36]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 45RNVlGB007030 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 27 Jun 2024 18:31:47 -0500 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 27 Jun 2024 18:31:47 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 27 Jun 2024 18:31:47 -0500 Received: from [10.249.42.149] ([10.249.42.149]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 45RNVkj3063647; Thu, 27 Jun 2024 18:31:46 -0500 Message-ID: Date: Thu, 27 Jun 2024 18:31:46 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] arm64: dts: ti: k3-j72xx-mcu-wakeup: add dedicated wakeup controller compatible To: Jan Kiszka , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley CC: , , , Bao Cheng Su , Diogo Ivo References: Content-Language: en-US From: Andrew Davis In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_163151_392252_A137D403 X-CRM114-Status: GOOD ( 19.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/24/24 1:20 AM, Jan Kiszka wrote: > From: Jan Kiszka > > Each syscon node must come with a dedicated/specific compatible, which > is also reported by dtbs_check: > > k3-j7200-common-proc-board.dtb: scm-conf@40f00000: compatible: ['syscon', 'simple-mfd'] is too short > > Add one for the TI K3 AM654 MCU wakeup system controller used in J72xx > SoCs. Unfortunately this is not correct, this region is not an AM654 MCU system controller, it is a J721e MCU system controller. Some registers are the same, but others are not. So if labeled as a "ti,am654-system-controller" we would not be able to add the rest of the child nodes only found on the J7x devices. A more correct fix for the warning would be the following: diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi index fccaabfb13482..5097d192c2b20 100644 --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi @@ -164,12 +164,16 @@ mcu_timer9: timer@40490000 { ti,timer-pwm; }; - mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; - reg = <0x00 0x40f00000 0x00 0x20000>; + mcu_conf: bus@40f00000 { + compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; - ranges = <0x00 0x00 0x40f00000 0x20000>; + ranges = <0x0 0x0 0x40f00000 0x20000>; + + cpsw_mac_syscon: ethernet-mac-syscon@200 { + compatible = "ti,am62p-cpsw-mac-efuse", "syscon"; + reg = <0x200 0x8>; + }; phy_gmii_sel: phy@4040 { compatible = "ti,am654-phy-gmii-sel"; @@ -420,7 +424,7 @@ cpsw_port1: port@1 { reg = <1>; ti,mac-only; label = "port1"; - ti,syscon-efuse = <&mcu_conf 0x200>; + ti,syscon-efuse = <&cpsw_mac_syscon 0x0>; phys = <&phy_gmii_sel 1>; }; }; I'll clean this up and post it for the other J7x devices tomorrow. Andrew > > Signed-off-by: Jan Kiszka > --- > arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- > arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 2 +- > arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > index fccaabfb1348..3a78a3c1676d 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > @@ -165,7 +165,7 @@ mcu_timer9: timer@40490000 { > }; > > mcu_conf: syscon@40f00000 { > - compatible = "syscon", "simple-mfd"; > + compatible = "ti,am654-system-controller", "syscon", "simple-mfd"; > reg = <0x00 0x40f00000 0x00 0x20000>; > #address-cells = <1>; > #size-cells = <1>; > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > index 9349ae07c046..d68e33d71eb3 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > @@ -35,7 +35,7 @@ k3_reset: reset-controller { > }; > > mcu_conf: syscon@40f00000 { > - compatible = "syscon", "simple-mfd"; > + compatible = "ti,am654-system-controller", "syscon", "simple-mfd"; > reg = <0x0 0x40f00000 0x0 0x20000>; > #address-cells = <1>; > #size-cells = <1>; > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > index 5ccb04c7c462..1edb71f4a1bb 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > @@ -140,7 +140,7 @@ wkup_gpio_intr: interrupt-controller@42200000 { > }; > > mcu_conf: syscon@40f00000 { > - compatible = "syscon", "simple-mfd"; > + compatible = "ti,am654-system-controller", "syscon", "simple-mfd"; > reg = <0x0 0x40f00000 0x0 0x20000>; > #address-cells = <1>; > #size-cells = <1>;