linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: zhiyong.tao <zhiyong.tao@mediatek.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: <lee.jones@linaro.org>, <robh+dt@kernel.org>,
	<matthias.bgg@gmail.com>, <lgirdwood@gmail.com>,
	<broonie@kernel.org>, <eddie.huang@mediatek.com>,
	<a.zummo@towertech.it>, <alexandre.belloni@bootlin.com>,
	<fshao@chromium.org>, <sen.chu@mediatek.com>,
	<hui.liu@mediatek.com>, <allen-kh.cheng@mediatek.com>,
	<hsin-hsiung.wang@mediatek.com>, <sean.wang@mediatek.com>,
	<macpaul.lin@mediatek.com>, <wen.su@mediatek.com>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-rtc@vger.kernel.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v4] regulator: dt-bindings: mediatek: add mt6366
Date: Mon, 29 Aug 2022 10:15:10 +0800	[thread overview]
Message-ID: <a574ece24e1704f4a5634e9f9e25f3dae8485cca.camel@mediatek.com> (raw)
In-Reply-To: <20220823184705.6fdpczguait2la4v@notapiano>

On Tue, 2022-08-23 at 14:47 -0400, Nícolas F. R. A. Prado wrote:
> On Tue, Aug 23, 2022 at 08:37:45PM +0800, Zhiyong Tao wrote:
> > Add mt6366 regulator document
> > 
> > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> > ---
> 
> [..]
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-
> > regulator.yaml
> 
> [..]
> > +      "^buck-(vcore)-sshub$":
> 
> The parentheses here don't serve any purpose, so drop them.
Hi nfrapardo,

we will fix it in v5.

> 
> > +        type: object
> > +        $ref: regulator.yaml#
> > +        unevaluatedProperties: false
> 
> [..]
> > +      "^ldo-vcn(33)-wifi$":
> 
> Ditto.
we will fix it in v5
> 
> > +        type: object
> > +        $ref: regulator.yaml#
> > +        unevaluatedProperties: false
> > +
> > +      "^ldo-vsram-(others)-sshub$":
> 
> Ditto.
we will fix it in v5
> 
> > +        type: object
> > +        $ref: regulator.yaml#
> > +        unevaluatedProperties: false
> 
> [..]
> > +      "^ldo-vsim[2]$":
> 
> Based on the example, should be [12].
we will fix it in v5

Thanks
> 
> Thanks,
> Nícolas
> 
> > +        type: object
> 
> [..]
> > +            mt6366_vsim1_reg: ldo-vsim1 {
> > +                regulator-enable-ramp-delay = <540>;
> > +            };
> 
> [..]
> > +            mt6366_vsim2_reg: ldo-vsim2 {
> > +                regulator-enable-ramp-delay = <540>;
> > +            };
> 
> [..]


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-08-29  2:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 12:37 [PATCH v4] regulator: dt-bindings: mediatek: add mt6366 Zhiyong Tao
2022-08-23 18:47 ` Nícolas F. R. A. Prado
2022-08-29  2:15   ` zhiyong.tao [this message]
2022-08-24 13:48 ` Krzysztof Kozlowski
2022-08-29  3:25   ` zhiyong.tao
2022-08-30  7:42     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a574ece24e1704f4a5634e9f9e25f3dae8485cca.camel@mediatek.com \
    --to=zhiyong.tao@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=allen-kh.cheng@mediatek.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eddie.huang@mediatek.com \
    --cc=fshao@chromium.org \
    --cc=hsin-hsiung.wang@mediatek.com \
    --cc=hui.liu@mediatek.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=macpaul.lin@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=nfraprado@collabora.com \
    --cc=robh+dt@kernel.org \
    --cc=sean.wang@mediatek.com \
    --cc=sen.chu@mediatek.com \
    --cc=wen.su@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).