From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
Tao Zhang <quic_taozha@quicinc.com>
Subject: Re: [PATCH v7 08/10] coresight-tpdm: Add timestamp control register support for the CMB
Date: Tue, 13 Feb 2024 11:01:12 +0000 [thread overview]
Message-ID: <a5a51333-ba84-4725-9dc2-a6689aad36fc@arm.com> (raw)
In-Reply-To: <f95cf482-0ef8-43b5-81e0-f1901d8f85d5@app.fastmail.com>
On 13/02/2024 10:45, Arnd Bergmann wrote:
> On Tue, Feb 13, 2024, at 11:22, Suzuki K Poulose wrote:
>
>> coresight: tpdm: Fix build break due to uninitialised field
>>
>> {CMB/DSB}_PATT_ENABLE_TS attributes do not use an index field.
>> But some compilers complain for uninitialised "index" field in
>> the struct tpdm_dataset_attribute:
>>
> ...
>>
>> Reported-by: Arnd Bergmann <arnd@arndb.de>
>> Cc: Tao Zhang <quic_taozha@quicinc.com>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>
> Works fine here with this, thanks for the fix!
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> I had actually missed that this is a warning option that
> is normally disabled even at W=1 level, but it does get
> added by drivers/hwtracing/coresight/Makefile setting
> -Wextra again because that comes after the
> -Wno-missing-field-initializers from scripts/Makefile.extrawarn.
>
> Arnd
Thanks, I will queue this.
Suzuki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-13 11:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 5:30 [PATCH v7 00/10] Add support to configure TPDM CMB subunit Tao Zhang
2024-02-04 5:30 ` [PATCH v7 01/10] coresight-tpdm: Optimize the store function of tpdm simple dataset Tao Zhang
2024-02-04 5:30 ` [PATCH v7 02/10] coresight-tpdm: Optimize the useage of tpdm_has_dsb_dataset Tao Zhang
2024-02-04 5:30 ` [PATCH v7 03/10] dt-bindings: arm: qcom,coresight-tpdm: Add support for CMB element size Tao Zhang
2024-02-04 5:30 ` [PATCH v7 04/10] coresight-tpdm: Add CMB dataset support Tao Zhang
2024-02-04 5:30 ` [PATCH v7 05/10] coresight-tpda: Add support to configure CMB element Tao Zhang
2024-02-04 5:30 ` [PATCH v7 06/10] coresight-tpdm: Add support to configure CMB Tao Zhang
2024-02-04 5:30 ` [PATCH v7 07/10] coresight-tpdm: Add pattern registers support for CMB Tao Zhang
2024-02-04 5:30 ` [PATCH v7 08/10] coresight-tpdm: Add timestamp control register support for the CMB Tao Zhang
2024-02-13 9:50 ` Arnd Bergmann
2024-02-13 10:22 ` Suzuki K Poulose
2024-02-13 10:45 ` Arnd Bergmann
2024-02-13 11:01 ` Suzuki K Poulose [this message]
2024-02-13 11:04 ` Suzuki K Poulose
2024-02-04 5:30 ` [PATCH v7 09/10] dt-bindings: arm: qcom,coresight-tpdm: Add support for TPDM CMB MSR register Tao Zhang
2024-02-04 5:30 ` [PATCH v7 10/10] coresight-tpdm: Add msr register support for CMB Tao Zhang
2024-02-12 11:25 ` [PATCH v7 00/10] Add support to configure TPDM CMB subunit Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5a51333-ba84-4725-9dc2-a6689aad36fc@arm.com \
--to=suzuki.poulose@arm.com \
--cc=arnd@arndb.de \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=quic_taozha@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox