From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E76610F3DE1 for ; Sat, 28 Mar 2026 10:14:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Zz/9aZCWAK+TvBPXTEhoM6KiLU5MjZYdqj8yxwYphp4=; b=ztTZkGwjT8EQp5EKZfn02VG+vj H26w7BhWWjIrpJoT/mdDpuKjEr6bU1bVIRAmjCz5QJWGlIBdDxieq37SBvSQFTF0yP3LBN7CpSEyW Y+hnT2W5+inpkHtS/Vv+t7DYnSkLflKKqMw8LPqMxMdxsZOsxd4U728Bcvk8QjONNPFOsopLCPZsd 2OZMjxEc0YCFIL9Mt445SQMH+KXxvndIMDMaW8JZTGd40Zc+kwzltdDtFk/C04yJPIvTuX6jsZpFf jTOfJWAsb5nrC8r288AUpMbqG9dQDSRE2dEW3e1ll6MSiEoqaNv1+BJmEWGnK1mnPohroWFodhxnw 9k7oAGOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w6Qgr-00000008p2I-1OjE; Sat, 28 Mar 2026 10:14:49 +0000 Received: from canpmsgout08.his.huawei.com ([113.46.200.223]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w6Qgn-00000008p1r-3MaC for linux-arm-kernel@lists.infradead.org; Sat, 28 Mar 2026 10:14:47 +0000 dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=Zz/9aZCWAK+TvBPXTEhoM6KiLU5MjZYdqj8yxwYphp4=; b=NXoPk2+ueLIEGBIUsPmd6SreaXd2v9vL8QMFbzEznE/6u3GdGx5L2uIkwIDqgJLvojg1txjzC RT9T0D1pwz0Q33CbWZ7VaTBWIHWYKlABmqC3FRmjFX67zSjCHf6NtkpgBN5eCXNZiSi/HGa9lsg DQiAJhDR7tuGJWhDTzyIWtE= Received: from mail.maildlp.com (unknown [172.19.162.92]) by canpmsgout08.his.huawei.com (SkyGuard) with ESMTPS id 4fjYB200WSzmV79; Sat, 28 Mar 2026 18:08:25 +0800 (CST) Received: from kwepemj200003.china.huawei.com (unknown [7.202.194.15]) by mail.maildlp.com (Postfix) with ESMTPS id D0D0140562; Sat, 28 Mar 2026 18:14:34 +0800 (CST) Received: from [10.67.120.170] (10.67.120.170) by kwepemj200003.china.huawei.com (7.202.194.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 28 Mar 2026 18:14:34 +0800 Message-ID: Date: Sat, 28 Mar 2026 18:14:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 0/5] Add debugfs support for ARM SMMUv3 To: , , , CC: , , , , , , , References: <20260328100953.3441915-1-xiaqinxin@huawei.com> From: Qinxin Xia In-Reply-To: <20260328100953.3441915-1-xiaqinxin@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.120.170] X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To kwepemj200003.china.huawei.com (7.202.194.15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260328_031446_635997_877CCBFB X-CRM114-Status: GOOD ( 17.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sorry！patch 2 cannot convert from y to UTF-8,I will release a new version soon; please ignore this one. On 2026/3/28 18:09:48, Qinxin Xia wrote: > Add a comprehensive debugfs framework to the ARM SMMUv3 driver, > providing visibility into internal hardware state for debugging > and performance analysis. The debugfs entries are organized under > /sys/kernel/debug/iommu/arm_smmu_v3/, with per-SMMU instance directories > and per-device stream table entries. > > Each SMMU instance provides: > - capabilities – static SMMU features and queue sizes. > - registers – SMMU key registers. > - stream_table/ – a directory per device with subdirectories per Stream ID. > > Each Stream ID subdirectory contains: > - ste – the Stream Table Entry in decoded and raw format. > - cd – all valid Context Descriptors (Stage 1 translation tables) associated with the device. > - a symlink named with the device’s BDF/name pointing to its sysfs directory for easy navigation. > > /sys/kernel/debug/iommu/arm_smmu_v3/smmu0/stream_table/ > └── / > ├─── ste > ├─── cd > └─── > > Changes since V1: > Address the comments from Nicolin: > 1.Fixed the incorrect comments and replaced 'kzalloc' with 'kzalloc_obj' > 2.'stream_table_create/stream_table_remove' is called in probe_device/release_device > 3.Reused some functions in the driver > > Address the comments from Robin: > 1.Remove unnecessary CR0*EN extra strings > 2.Remove the limit on ssid > > Address the comments from Robin and Nicolin: > 1.The directory structure has been changed > 2.Added lock protection for the ste_show and cd_show > > Others: > 1.'arm_smmu_debugfs_remove' is added to remove the corresponding debugfs when SMMU device is removed > 2.'arm_smmu_debugfs_remove_stream_table' is added to remove the corresponding stream_dir when device is removed > 3.Use scoped_guard for locks that include return > 4.Added 'open' and 'release' operations to prevent the device from being released during dump > 5.Merged 'stream_table_create' and 'ste_show' into one patch > 6.Some other clean code > > - Link: https://lore.kernel.org/all/20260313104351.3502293-1-xiaqinxin@huawei.com/ > > Qinxin Xia (5): > iommu/arm-smmu-v3: Add basic debugfs framework > iommu/arm-smmu-v3: Add register display to debugfs > iommu/arm-smmu-v3: Add Stream Table Entry display to debugfs > iommu/arm-smmu-v3: Add device symlink in stream table debugfs > iommu/arm-smmu-v3: Add Context Descriptor display to debugfs > > drivers/iommu/Kconfig | 11 + > drivers/iommu/arm/arm-smmu-v3/Makefile | 1 + > .../arm/arm-smmu-v3/arm-smmu-v3-debugfs.c | 571 ++++++++++++++++++ > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 33 +- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 32 + > 5 files changed, 646 insertions(+), 2 deletions(-) > create mode 100644 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-debugfs.c > -- Thanks, Qinxin