From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCAA3C4332F for ; Mon, 14 Nov 2022 01:56:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GIeoUw+jXeVJiHuKAFKULPQxAqJmo4jzTKyrce+/z2g=; b=mBlOBdMaGqr24W TQPew2ZBsEMLfEX5ohD/Jhubhin2IAsVzEqOVBFm1yAhAw6sBv5aLJ1ucX3dfjqqCwjv3qdmiWr46 tO371L2SNsbSCWjJzcGpzLfFPL2yUvDpa3sl5TFNXGk8EmETy++fNBDQBaN4KoKN+RXN0V2HoThUQ +BBWIKFkPTCtg8aQXkzH4D280FyN0rwzYgz9OHBba1pt8T0NwWv/SKcH7JAW2Xys4hP7QzL4ffMUw FOYepfulKEj1I7q1nnXJPrhY81ciLwGsSCqbLavImdiV+l5fLIZCfp0VeZK7ujLhPRDrQNY0+5G2I 5LwDjeEp6EBK22TLzxJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouOh7-00FTzm-Eq; Mon, 14 Nov 2022 01:55:29 +0000 Received: from esa4.hgst.iphmx.com ([216.71.154.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouOh3-00FTy7-9w for linux-arm-kernel@lists.infradead.org; Mon, 14 Nov 2022 01:55:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1668390925; x=1699926925; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=nyOFTXz3d9X6eMOZsmuYqPSZyAOtJSgUq3fJ16zqsqM=; b=M/ofJSQQ3dk11DRXe+ZDbY87R5ZFpGDSfMuGiMCDvRJPMxWwUFRmTam9 zDAkAFZzvoenYSqS9LEDClpciqr7uwQOYLyd+d4r1xIgdLs3n4YQlYCBB w1SuAo8lxZ5mbmIgBbe0/xXLjckb1WXGfMbWtsjJptWfCqkxyInYvc/pl vBMmzoVC8cs7xdUlxXhJ8/hW82WdT0tiF2ZWH22y3mjRI4BO3ferEesmx l82UnzSM2ofQAoyKJQXaAVIGUtrb5p/jD13/5laUCn9uYxXG/7Y9ff1Rc N5WZsMW5pLhaTntbFE0eknn4uKBWcnzBx6eVs7DM+ZpCbnAjfXTfqChB9 Q==; X-IronPort-AV: E=Sophos;i="5.96,161,1665417600"; d="scan'208";a="214449245" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 14 Nov 2022 09:55:18 +0800 IronPort-SDR: 7hnaOlNCUyAj+mYpKzD7Nl5GCpZx1gRgmH83CRuMdeSCdoYOqyCNfcj1GoMXfT02Gt2r2FrvwA 2FscN9V4NZCtHXLSdQqwRskDiV0hm3rPr8xZHBvVPUrf/aYztI5i8ENp9+pOWSX0rW44CPZg/6 1FfiD5C+oQz7BRC2ouFhjoztQwRLgrauI4USmQ9eEal9VDSkaUf6OL8ATIvXJy2uhpiRD5jZXm L2W2kUTK2QKrRjFx5h7kqnY5qVRB+yF/63jnl6dRhpWeWKfUNkSYFkc1chIfIavUJq7VK/84/M JE0= Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Nov 2022 17:14:17 -0800 IronPort-SDR: T+npjyZId6DACdAA3fVSl/ZnwCzV5iB9UaoXRwnILWp41NuJm43imnaBbWYSsyifzIDjPym9oR SnPJ2uDqISHHiHpqmSOlIukLdcLipBFj11RSvu4x1Y43OLcnmAFNXq5VJTpNw4lHRpzJd0NNN0 mElHsT6Aa6k/myk0Yyrv3pA5N4kci5FkD1pRckgTc1FFALYNLecQt0i2XSzsPbtE4OBnQW/bGW kmnnaHxQixPkv52I2UxcKN9R/+hWmcal+JHyuedSPYTsgChzDOCJ3G7UMyKewilexPZhAT9L4u i+8= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Nov 2022 17:55:19 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4N9XSj3Nhtz1RwqL for ; Sun, 13 Nov 2022 17:55:17 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1668390915; x=1670982916; bh=nyOFTXz3d9X6eMOZsmuYqPSZyAOtJSgUq3f J16zqsqM=; b=KdBEy2/f1UL9iwdDDsnx13pQgFS4wsL6XbuhlU6jBLPkp0SLBFy 84GR9Jg17dPaRAqlfQ8fmkXVMZh856foOsh0qzTdpIsDd7fcSD6d4eoW++N9UWok 4cQMpwXNu5vsBctDjY55gsixUcxgATCkQth+e9gcXRAhOH67zHH+sg2TN7ZuIrZk /mANDXFmyKeNxYu16CBelrdbnmyehuiIddu7mVji1npiONJjOl4kuAoNRtxi1kOY vpgnjgvQ/07QbI+Chc/tbWOv/0E+rZ6GxD72LB5Xu8J1G+k/b19f9+SdG4f3b2GP wSszJrcog0UeG03zNzlSZqHeLtKanQV5I4A== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id cKVkozMr6-as for ; Sun, 13 Nov 2022 17:55:15 -0800 (PST) Received: from [10.225.163.46] (unknown [10.225.163.46]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4N9XSY61WPz1RvLy; Sun, 13 Nov 2022 17:55:09 -0800 (PST) Message-ID: Date: Mon, 14 Nov 2022 10:55:08 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: Deprecating and removing SLOB Content-Language: en-US To: Conor Dooley , Vlastimil Babka Cc: Pasha Tatashin , Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Matthew Wilcox , Roman Gushchin , Linus Torvalds , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Catalin Marinas , Rustam Kovhaev , Andrew Morton , Josh Triplett , Arnd Bergmann , Russell King , Alexander Shiyan , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Yoshinori Sato , Rich Felker , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "linux-arm-kernel@lists.infradead.org" , openrisc@lists.librecores.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, Geert Uytterhoeven , Conor.Dooley@microchip.com, Paul Cercueil References: From: Damien Le Moal Organization: Western Digital Research In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221113_175525_423381_EC141EA4 X-CRM114-Status: GOOD ( 28.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/12/22 05:46, Conor Dooley wrote: > On Fri, Nov 11, 2022 at 11:33:30AM +0100, Vlastimil Babka wrote: >> On 11/8/22 22:44, Pasha Tatashin wrote: >>> On Tue, Nov 8, 2022 at 10:55 AM Vlastimil Babka wrote: >>>> >>>> Hi, >>>> >>>> as we all know, we currently have three slab allocators. As we discussed >>>> at LPC [1], it is my hope that one of these allocators has a future, and >>>> two of them do not. >>>> >>>> The unsurprising reasons include code maintenance burden, other features >>>> compatible with only a subset of allocators (or more effort spent on the >>>> features), blocking API improvements (more on that below), and my >>>> inability to pronounce SLAB and SLUB in a properly distinguishable way, >>>> without resorting to spelling out the letters. >>>> >>>> I think (but may be proven wrong) that SLOB is the easier target of the >>>> two to be removed, so I'd like to focus on it first. >>>> >>>> I believe SLOB can be removed because: >>>> >>>> - AFAIK nobody really uses it? It strives for minimal memory footprint >>>> by putting all objects together, which has its CPU performance costs >>>> (locking, lack of percpu caching, searching for free space...). I'm not >>>> aware of any "tiny linux" deployment that opts for this. For example, >>>> OpenWRT seems to use SLUB and the devices these days have e.g. 128MB >>>> RAM, not up to 16 MB anymore. I've heard anecdotes that the performance >>>> SLOB impact is too much for those who tried. Googling for >>>> "CONFIG_SLOB=y" yielded nothing useful. >>> >>> I am all for removing SLOB. >>> >>> There are some devices with configs where SLOB is enabled by default. >>> Perhaps, the owners/maintainers of those devices/configs should be >>> included into this thread: >>> >>> tatashin@soleen:~/x/linux$ git grep SLOB=y > >>> arch/riscv/configs/nommu_k210_defconfig:CONFIG_SLOB=y >>> arch/riscv/configs/nommu_k210_sdcard_defconfig:CONFIG_SLOB=y >>> arch/riscv/configs/nommu_virt_defconfig:CONFIG_SLOB=y > >> >> Turns out that since SLOB depends on EXPERT, many of those lack it so >> running make defconfig ends up with SLUB anyway, unless I miss something. >> Only a subset has both SLOB and EXPERT: >> >>> git grep CONFIG_EXPERT `git grep -l "CONFIG_SLOB=y"` > >> arch/riscv/configs/nommu_virt_defconfig:CONFIG_EXPERT=y > > I suppose there's not really a concern with the virt defconfig, but I > did check the output of `make nommu_k210_defconfig" and despite not > having expert it seems to end up CONFIG_SLOB=y in the generated .config. > > I do have a board with a k210 so I checked with s/SLOB/SLUB and it still > boots etc, but I have no workloads or w/e to run on it. I sent a patch to change the k210 defconfig to using SLUB. However... The current default config using SLOB gives about 630 free memory pages after boot (cat /proc/vmstat). Switching to SLUB, this is down to about 400 free memory pages (CONFIG_SLUB_CPU_PARTIAL is off). This is with a buildroot kernel 5.19 build including a shell and sd-card boot. With SLUB, I get clean boots and a shell prompt as expected. But I definitely see more errors with shell commands failing due to allocation failures for the shell process fork. So as far as the K210 is concerned, switching to SLUB is not ideal. I would not want to hold on kernel mm improvements because of this toy k210 though, so I am not going to prevent SLOB deprecation. I just wish SLUB itself used less memory :) -- Damien Le Moal Western Digital Research _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel