From: <Codrin.Ciubotariu@microchip.com>
To: <mirq-linux@rere.qmqm.pl>
Cc: alsa-devel@alsa-project.org, alexandre.belloni@bootlin.com,
lgirdwood@gmail.com, tiwai@suse.com,
Ludovic.Desroches@microchip.com, broonie@kernel.org,
perex@perex.cz, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] ASoC: atmel: enable SSC_PCM_DMA in Kconfig
Date: Tue, 23 Jul 2019 17:27:26 +0000 [thread overview]
Message-ID: <a5ccf118-86d5-a16e-86ed-fa50edef8d51@microchip.com> (raw)
In-Reply-To: <20190723164312.GA4772@qmqm.qmqm.pl>
On 23.07.2019 19:43, mirq-linux@rere.qmqm.pl wrote:
> External E-Mail
>
>
> On Tue, Jul 23, 2019 at 01:36:37PM +0000, Codrin.Ciubotariu@microchip.com wrote:
>> On 22.07.2019 21:27, Michał Mirosław wrote:
>>> Allow SSC to be used on platforms described using audio-graph-card
>>> in Device Tree.
>>>
>>> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
>>> ---
>>> sound/soc/atmel/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
>>> index 06c1d5ce642c..9ef9d25bb517 100644
>>> --- a/sound/soc/atmel/Kconfig
>>> +++ b/sound/soc/atmel/Kconfig
>>> @@ -25,7 +25,7 @@ config SND_ATMEL_SOC_DMA
>>> default y if SND_ATMEL_SOC_SSC_DMA=y || (SND_ATMEL_SOC_SSC_DMA=m && SND_ATMEL_SOC_SSC=y)
>>>
>>> config SND_ATMEL_SOC_SSC_DMA
>>> - tristate
>>> + tristate "SoC PCM DAI support for AT91 SSC controller using DMA"
>>
>> Could you please make something similar for SND_ATMEL_SOC_SSC_PDC? Also,
>> I think that it should select ATMEL_SSC, to be able to use
>> simple/graph-card with SSC.
>
> Hmm. The Kconfig dependencies seems overly complicated, do you mind if I
> get rid of most of the entries in the process?
>
> Best Regards,
> Michał Mirosław
>
'select' creates recursive dependencies with our machine
drivers, but 'depends on' should work. The complication comes from the
fact that PDC and DMA support for SSC can be both enabled at the same
time, so I think we need all of them...
I am reviewing the rest of your patches, so bear with me please.
Best regards,
Codrin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-23 17:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 18:27 [PATCH 0/5] ASoC: atmel: extend SSC support Michał Mirosław
2019-07-22 18:27 ` [PATCH 1/5] ASoC: atmel: enable SSC_PCM_DMA in Kconfig Michał Mirosław
2019-07-23 13:36 ` Codrin.Ciubotariu
2019-07-23 14:26 ` Codrin.Ciubotariu
2019-07-23 16:43 ` mirq-linux
2019-07-23 17:27 ` Codrin.Ciubotariu [this message]
2019-07-23 18:39 ` Alexandre Belloni
2019-07-23 23:25 ` mirq-linux
2019-07-25 15:25 ` Codrin.Ciubotariu
2019-08-23 15:09 ` Alexandre Belloni
2019-07-23 17:18 ` Mark Brown
2019-07-22 18:27 ` [PATCH 4/5] ASoC: atmel_ssc_dai: split TX/RX FS constants Michał Mirosław
2019-07-25 13:28 ` Codrin.Ciubotariu
2019-07-22 18:27 ` [PATCH 5/5] ASoC: atmel_ssc_dai: Enable shared FSYNC source in frame-slave mode Michał Mirosław
2019-07-25 15:02 ` Codrin.Ciubotariu
2019-07-25 18:24 ` mirq-linux
2019-07-26 10:33 ` Codrin.Ciubotariu
2019-07-26 12:08 ` mirq-linux
2019-07-22 18:27 ` [PATCH 2/5] ASoC: atmel_ssc_dai: rework DAI format configuration Michał Mirosław
2019-07-24 10:35 ` Codrin.Ciubotariu
2019-07-24 11:15 ` mirq-linux
2019-07-24 12:54 ` Codrin.Ciubotariu
2019-07-22 18:27 ` [PATCH 3/5] ASoC: atmel_ssc_dai: implement left-justified data mode Michał Mirosław
2019-07-25 13:15 ` Codrin.Ciubotariu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5ccf118-86d5-a16e-86ed-fa50edef8d51@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).