From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2597CC5475B for ; Fri, 1 Mar 2024 06:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9xBnWJdBYuYJtdm28mBWOVfKM2g03fSGd9fb7q9xAbw=; b=gkGzKa6xbc+mS8 8G9KgAhmtn+E7mA3GQvNBhPPBroxxYvU5yqGEFt3aJyIOs/c/diE3d/wdBcfukNteadRO2XVTltuF 7p8DFnzKTLXHXgF9y/LBun4BWOLR7FLhA9HHYZitnDua3cIOyBjKzTVlzw1QcWRMvF5/NzWD6AKtV eaD/Q8aBWqUHCHokIRr7pbVoB2gTwy3MscxbDQjeODCaj/tjzKhsb4XvppM+ZMlXjLKAqclpJIIH0 x65R31Ckp+D5Sz7nWJQ7soHNABVN9gn4mq/Ha2ByUOQ9zahEUfCdkBYQJ6JF5fwcfvE2zNegg6d1B SnzvbskGI3zsNkhuHDwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfwpH-0000000Ge9j-0Kz5; Fri, 01 Mar 2024 06:56:59 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfwpD-0000000Ge8L-3mwc; Fri, 01 Mar 2024 06:56:57 +0000 X-UUID: e0f7f198d79811eea40fa5ac21cdad35-20240229 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=kNnHf20HbEwH4032Ode+vUrRvCIg5sJZ+jJohEs1rvE=; b=sy3J/IKMu73kP7VhCcfErNqDjSIwWteIRroZ68/m5sMTgAzTAXaAkV7fPfKeKXUhIXAd3D+2oxMLJ1ICF4Pdx2UcJ6hYSa/FIfZ+rKE5tWPxv8Q8Lu1ZKpC/MIVMLkl/YT3f7tkjTYlo+cGr5rXS3WxfnAVVQqNZDygNoC/PmvI=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.37,REQID:f1805a96-27a1-404a-b160-785d883d48e1,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:6f543d0,CLOUDID:9f1462ff-c16b-4159-a099-3b9d0558e447,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1, SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: e0f7f198d79811eea40fa5ac21cdad35-20240229 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 2021918890; Thu, 29 Feb 2024 23:56:50 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs13n2.mediatek.inc (172.21.101.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Fri, 1 Mar 2024 14:56:30 +0800 Received: from APC01-SG2-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 1 Mar 2024 14:56:30 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RI2lD3Qpgg2gMzvpFsE/6lVRomjQAP2Rv24b7UaJbg3joZ3ooaEonM+UWIRRJatnaZwCZiCnITgDlodKgJ9OSuP2vreeq1Zbzl/CAcG7PVYk+VW92Hue0+KMl0RTo/mq3lTqtOenw58TSYDV/ROMsl7OFWPEJWTOpoLbx1Mtk1ecgv1U3FyAERnINwSfvWDGKkCqZQg2D156uqKTJAMsXmQEDwmu/B8pk8/eq0jZGGxBozuf86BKqIjhi7sbFXKLXwZ3CWaNZ3irecpnKqnfUXs9Uwof4vfTbBHdcpxuXRHPeCKYafbn6HVsJIghgrt5Mt/OhXSGrAc6wd+Nbu/9Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kNnHf20HbEwH4032Ode+vUrRvCIg5sJZ+jJohEs1rvE=; b=OFdhl5S+XI7aVDpxvISWdlapr8FGKcZKU/09zbT4UoGSKo7aTwdTif9yIZIyvXLfNMkugb6fsfwYq3VKs7hi7DVjl5KNl7GG7QXvk4gDhtMozIsqJvhZ3rFQGo8c/Sq518mA2mUHElxlyj/k0VKDB388lL6KuO1rp1P/6PQi4VO0VgFI2XYInKNKkagfOF2J9nChuuV7uuVLo3CqgdpSnac/Lc5AU2bo8e7UJccRoErSJVUX8wxnY0G1qUOOPwlB4cclLFST678218UMSN27SjmcBYUeqovTOs832Avpw6AgiKGwhcmoITyWM9iWz3+xlP46xeHHGUrseob6JIzF7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kNnHf20HbEwH4032Ode+vUrRvCIg5sJZ+jJohEs1rvE=; b=Qgfby4lQpn9UNG/6mxZnQvhEvsTlyejkjLBsMzGlL5UIj2YMVUCfEHmTZhRdB5Tf/xYe2fiGsutaaixRvzJ6sJbGQU4+mnnAl/GgNNk1x9quHFdrtZhkuADnHNT5rz9ODZg31doAE5bkTbchY4o/gjzbxJXH8AdMTU9/9RC4AFE= Received: from TYZPR03MB6624.apcprd03.prod.outlook.com (2603:1096:400:1f4::13) by PUZPR03MB7235.apcprd03.prod.outlook.com (2603:1096:301:11a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.39; Fri, 1 Mar 2024 06:56:27 +0000 Received: from TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::b705:ea58:46d:e98d]) by TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::b705:ea58:46d:e98d%4]) with mapi id 15.20.7316.039; Fri, 1 Mar 2024 06:56:27 +0000 From: =?utf-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= To: =?utf-8?B?U2hhd24gU3VuZyAo5a6L5a2d6KyZKQ==?= , "angelogioacchino.delregno@collabora.com" , "chunkuang.hu@kernel.org" CC: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?utf-8?B?QmliYnkgSHNpZWggKOisnea/n+mBoCk=?= , "jason-ch.chen@mediatek.corp-partner.google.com" , =?utf-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , "daniel@ffwll.ch" , "seanpaul@chromium.org" , "p.zabel@pengutronix.de" , "dri-devel@lists.freedesktop.org" , "airlied@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" Subject: Re: [PATCH v5 04/13] drm/mediatek: Fix errors when reporting rotation capability Thread-Topic: [PATCH v5 04/13] drm/mediatek: Fix errors when reporting rotation capability Thread-Index: AQHaX/dt8A2CJNeE3ky/RI+ap0eEJ7EiizkA Date: Fri, 1 Mar 2024 06:56:26 +0000 Message-ID: References: <20240215101119.12629-1-shawn.sung@mediatek.com> <20240215101119.12629-5-shawn.sung@mediatek.com> In-Reply-To: <20240215101119.12629-5-shawn.sung@mediatek.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB6624:EE_|PUZPR03MB7235:EE_ x-ms-office365-filtering-correlation-id: 31f4cd57-38c3-46c7-f704-08dc39bcb738 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uoV5aMxsRQDCmyiiniJ5DYJrubV1/Vf9d0ewBnGxFl0PjDi23WmiJ+acKZAxTSQ6Nv98RfGGd+EwdOaWmNlKK/4n/XiwNdd/FjUFrRGJEqOED7yihMwnhtJGBZp1Qq+APsKrJXBa4c0jdJr/BxQ8KdWdxLR+yiCjVnDOVc34AMjXf9WnqsQ06Onfon47hPZ8iyNLg+gaXY7deAu0iesM6oyFNRv0XX6QSUYOQAGHEnH+bTppb4XOtEzTyFq16M/feqBnNKAnbbuXT/tnMY54+8lHx1Td4OLcX8X3wkWIVHZOGudjHq+A0wTOsZ1+SGxlesw+a1GnzsthokrryRLHRuGJUxO43F6td9aMIrA/usqPMPzlLakyqhsKwwXrCZenW+CsJucDJLV5Aldvpun8/cLhQf55uitrbC5xdv8gGPm+vbSKx6hvnAe1fegOjjXwhL0TyP3QJIs8Rrn5DcQ+ercwjztFGs7UN18+dJFK46OFJH5mJMaOBnoTyzNXTJFwuzCIGMSqN25FtEvV1sL/LEz8BfA2C7IxDoSLnC7z67kWzVzTDPdaLS35a6n24liYrvcojC5k/cCunFIX8RxHDZ+GjqUq/zme+65xL0TeNS1cwkF0ZO5ztFEATmTEoPCuSl4S5zgS4OEgBWbdTmOr3Ki8v5GhtB3P5RqvS1gbzN8z+74RuMgysiPSBKgPfXnDZSmoU3I2q7OmMcQ1Y9N7BQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB6624.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?enJIcDFSZTZxUXd5aTJwaHpKeUFhajE0WTdmbkg4bCtjdlE2amcwNUJDM21N?= =?utf-8?B?OHRPN2xLY3c1ai9LU3dValdQTTRFWTN1VkppWUZid096enVBbU0wd2tGTk1U?= =?utf-8?B?Szc3bTAvV3Z1UHl2YVpaV1RsbXZuTEo3MC9Pbm5sNXdWRXFGQXU0bFNtcTFh?= =?utf-8?B?SDdLeDM1UEdHZzFnOTc3R0pUVkp4ZThPekxKV1p3RWhnUVpEdnkyazZpNzZx?= =?utf-8?B?dk9Na0pqVzcvV0d4MWFKNG80NGxpeWVwbXlhTlJZQVk5MUtXNjg2b0Z5VWd0?= =?utf-8?B?dDBKQVZobXU4dFlLWGhuRHJNV0k2dytxbE82NUpzUFF5QnA5elRlNkJnZW9W?= =?utf-8?B?RzAwaFlYQTBVejdTNUJtODV6ei95ZzdlNkVUUFpYR1B2WHcvNFM0QUs5UUZa?= =?utf-8?B?RGJjMytwM1RPMzZjdHNLN0Qzd0dVaUpKbG5md1lnVnA3M0MzQjdPVUNFc1Vn?= =?utf-8?B?RGJHUVJqMGV0VnhkVWVUbUFOOWZVSDN4Mi9tT3VLZ2dlR2VxbmtmS0M5R3Iv?= =?utf-8?B?ZzF1ZEd5NTNYTlRjbG1kTC9DbktybElQSU9OTXJDVEVqYXBleC9MK1ppM1FP?= =?utf-8?B?T3BJeDMvRWNFWmtTNEU0dWRrdUZjUlZWN2JSQit1K3N2SE1FL1NlOHFhMGE2?= =?utf-8?B?NHExdTJxZ29jR3JNWHNnajNYK2dnWjI2WmNUY2oxQktubnNYemY5NUlZK1hE?= =?utf-8?B?ZVZvZjUyN0hIQzVnSFpiSE1TeklIWWd4NGNSSVR2M0dvNUh3b0tNZnRNQWxF?= =?utf-8?B?SFN0eEFLbVprVnl2RVZ4RENGQlVhTFp5VlIvTUtiKytjTTF3TFMwc2dCSzlO?= =?utf-8?B?SWFvQ0pvbzE1YmQvZTRTRk1nUDYzd1lBam5yMXcrcjl5YzBJcVhYYlRLUGdF?= =?utf-8?B?dDZSZ2dqMHRYc096R0FxZzVCMVZyYTNGMkRuMzRHUE5uSzRNM09NWjI0TXEr?= =?utf-8?B?U083SDlvb3ZtN3pEdWJ3WWRCekw1ZU9TZHVEVnlIMURaU3FYT0V2YjhSTzdZ?= =?utf-8?B?WVNzUy83SnVLRWxFVlVIT3VCUEptOFJSajZOd3VEdU5VQ2xDVXpPeFFJbEoz?= =?utf-8?B?ZnR1RFhjUTQ3VHBaTVpLUmFSYmtVaGtkNkVJQnBrMnNrTmd0eU43bEVZeXYw?= =?utf-8?B?RnF4MnpSQzBpS0JMTHVzU1ZKbmF2bEpheFFtSng4MWJZQTh0L1VDb0VOMzBZ?= =?utf-8?B?UzY0YkVDblZib2hsZGozSlFpMzljR1NzOThENEd4VXl3REx2KzRGM0h1TVdQ?= =?utf-8?B?Y1lwQ0NibEo1WlNBTEFKbVFYTDJocUtKR0d5QTVXYk9lcVBwcmpocWs5L1lP?= =?utf-8?B?amlpOUZXSU9ydXlseGxQTWZIb1lLajY2Q0VMdkc2dkRWVDR6REMxYmlEWXFF?= =?utf-8?B?QndiNG15K1JsTlU4bFJRZitKbXhreVZDTXQ4TENXM2NIOEk5UGM3NWplRnVq?= =?utf-8?B?MDlxQzExb1NiZW9mUFFKUVhLcDBKK2ZRdjljcEV3NkJBSWpHckMvMHNGZG5N?= =?utf-8?B?K0hNL1pWYjR6ZloxQ2psSENQUXRuRkM2ZzVVNWVGbU90T0RXTFQ3bmE5eGNq?= =?utf-8?B?TUo4V3dMTXhLRUJuRzhsTEVabnVyOGdFaHNGZzhMY1pMSlVJZmdKNmY5ejRB?= =?utf-8?B?dEhBcUZWYTgzOElFRGlXajQ2YmZsWVY1akdyc0k4L3YxZTJ2Q243SjBQZE5a?= =?utf-8?B?dnY1SVkzem1yVnF4QWdhVERSbUF1UitpSVlHZEFEdnYzSll3dU9uQ3JxUWdh?= =?utf-8?B?YzZQRldyd01UanNKUUJVS3dTZlNtNWF5VjVtSi9UTWE2YnY2Q1BRaVg5NEtW?= =?utf-8?B?YnR2Rm5zYmhtWWtqRmxGaW14UmJLaGpJdUg2dUJnU3VqNGhuV1grbHRSN3Y5?= =?utf-8?B?Ri9WOWFZN3d2MEZBMTd2Zms1MG5xY0hEbllWSDJ3ZnZtVVlmUER4dzk3NEht?= =?utf-8?B?Y1JzYUtJbEdYQWEwVVNoU1JHOXhyWEVQUFBCblN5YjhlWWxHQzdOZDRFRnNW?= =?utf-8?B?UUVGQUQ5dHpqTm00VWVqNGIrSGZlMHk4Z2Z0dHdzSmJwYnhhNzJCeUJManU5?= =?utf-8?B?Nm5wWnBHTWwwdFZ4WmNPK0hRU25xeTJGMytNVTdHT2ZzRWp3czJ0K01rTHAy?= =?utf-8?Q?B+pqBrTZ1ks4W/d69X1TVpgur?= Content-ID: <2AF66333EA6A3847A3AD48650084D0F5@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6624.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31f4cd57-38c3-46c7-f704-08dc39bcb738 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2024 06:56:26.9789 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dQrJO9t2KN6J4i8mGLl7/RJmXxDTZ7cAxrHBOpxwPtLCnAIH/deVAGiJ34r3gHB3wjMVDbCVSE6xtHopJTHwHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR03MB7235 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_225655_965690_69CCD314 X-CRM114-Status: GOOD ( 22.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Hsiao-chien: On Thu, 2024-02-15 at 18:11 +0800, Hsiao Chien Sung wrote: > Create rotation property according to the hardware capability. > Since currently OVL of all chips support same rotation, > no need to define it in the driver data. > > Fixes: 84d805753983 ("drm/mediatek: Support reflect-y plane > rotation") > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > Signed-off-by: Hsiao Chien Sung > --- > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 1 + > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 19 +++++++-------- > ---- > .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 9 +++++++++ > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 2 +- > 5 files changed, 19 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_drv.h > b/drivers/gpu/drm/mediatek/mtk_disp_drv.h > index 4a5661334fb1a..cd5ca5359b0f0 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_drv.h > +++ b/drivers/gpu/drm/mediatek/mtk_disp_drv.h > @@ -126,6 +126,7 @@ void mtk_ovl_adaptor_register_vblank_cb(struct > device *dev, void (*vblank_cb)(vo > void mtk_ovl_adaptor_unregister_vblank_cb(struct device *dev); > void mtk_ovl_adaptor_enable_vblank(struct device *dev); > void mtk_ovl_adaptor_disable_vblank(struct device *dev); > +unsigned int mtk_ovl_adaptor_supported_rotations(struct device > *dev); > void mtk_ovl_adaptor_start(struct device *dev); > void mtk_ovl_adaptor_stop(struct device *dev); > unsigned int mtk_ovl_adaptor_layer_nr(struct device *dev); > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > index 5aaf4342cdbda..c42fce38a35eb 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > @@ -289,6 +289,10 @@ unsigned int mtk_ovl_layer_nr(struct device > *dev) > > unsigned int mtk_ovl_supported_rotations(struct device *dev) > { > + /* > + * although currently OVL can only do reflection, > + * reflect x + reflect y = rotate 180 > + */ > return DRM_MODE_ROTATE_0 | DRM_MODE_ROTATE_180 | > DRM_MODE_REFLECT_X | DRM_MODE_REFLECT_Y; > } > @@ -297,27 +301,18 @@ int mtk_ovl_layer_check(struct device *dev, > unsigned int idx, > struct mtk_plane_state *mtk_state) > { > struct drm_plane_state *state = &mtk_state->base; > - unsigned int rotation = 0; > > - rotation = drm_rotation_simplify(state->rotation, > - DRM_MODE_ROTATE_0 | > - DRM_MODE_REFLECT_X | > - DRM_MODE_REFLECT_Y); > - rotation &= ~DRM_MODE_ROTATE_0; > - > - /* We can only do reflection, not rotation */ > - if ((rotation & DRM_MODE_ROTATE_MASK) != 0) > + /* check if any unsupported rotation is set */ > + if (state->rotation & ~mtk_ovl_supported_rotations(dev)) > return -EINVAL; > > /* > * TODO: Rotating/reflecting YUV buffers is not supported at > this time. > * Only RGB[AX] variants are supported. > */ > - if (state->fb->format->is_yuv && rotation != 0) > + if (state->fb->format->is_yuv && (state->rotation & > ~DRM_MODE_ROTATE_0)) You still no explain what you do here. > return -EINVAL; > > - state->rotation = rotation; > - > return 0; > } > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c > b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c > index 6d4334955e3d3..d4a13a1402148 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c > @@ -379,6 +379,15 @@ void mtk_ovl_adaptor_register_vblank_cb(struct > device *dev, void (*vblank_cb)(vo > vblank_cb, vblank_cb_data); > } > > +unsigned int mtk_ovl_adaptor_supported_rotations(struct device *dev) > +{ > + /* > + * should still return DRM_MODE_ROTATE_0 if rotation is not > supported, > + * or IGT will fail. > + */ > + return DRM_MODE_ROTATE_0; > +} > + > void mtk_ovl_adaptor_unregister_vblank_cb(struct device *dev) > { > struct mtk_disp_ovl_adaptor *ovl_adaptor = > dev_get_drvdata(dev); > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > index 94590227c56a9..b47be6955d9b8 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > @@ -417,6 +417,7 @@ static const struct mtk_ddp_comp_funcs > ddp_ovl_adaptor = { > .get_formats = mtk_ovl_adaptor_get_formats, > .get_num_formats = mtk_ovl_adaptor_get_num_formats, > .mode_valid = mtk_ovl_adaptor_mode_valid, > + .supported_rotations = mtk_ovl_adaptor_supported_rotations, > }; > > static const char * const mtk_ddp_comp_stem[MTK_DDP_COMP_TYPE_MAX] = > { > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > index f10d4cc6c2234..2dc28a79f7603 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c > @@ -338,7 +338,7 @@ int mtk_plane_init(struct drm_device *dev, struct > drm_plane *plane, > return err; > } > > - if (supported_rotations & ~DRM_MODE_ROTATE_0) { > + if (supported_rotations) { Try report issue to IGT team. Regards, CK > err = drm_plane_create_rotation_property(plane, > DRM_MODE_ROTAT > E_0, > supported_rota > tions); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel