From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5876CC38A2D for ; Wed, 26 Oct 2022 06:39:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ju5IMwyPJinoSKZaxLl0kram4XyBps7AJu1UyQZ4ItQ=; b=1AF/GAnRXq+M9W jfhJ9bH6FiOz3NKrtzBKcDMQc+O2KLzrWjxw0akeZNBo38s3DOFj+OtpOZPiSVeRpG++FQTUpwofC VBdGBUuWPx2Nt6GZL4dm6uyz0MfMktr4Oi0KXTPSPB3dYzEfus+QlPU7JOISM2yx2+wRoN/au2c91 FjOBeDNK89bPW0bXvaL8meY7n9enQac3hIxGWkMHVzC6qBNK0Bu/kXJ8JApSU/aDxDxzKuQ9r6HuL Wmi3ioIrZxLKyoH5t8p12dhu4sDRr5jvRsAQehywmjrfD4Ui12n3IbhwHXVXgX+5tvU4ND0jHUBmP 3KL9Pwl+lNymCGqCAdKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ona3o-008HIO-GF; Wed, 26 Oct 2022 06:38:44 +0000 Received: from cpanel.siel.si ([46.19.9.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ona3i-008HG6-Pp for linux-arm-kernel@lists.infradead.org; Wed, 26 Oct 2022 06:38:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=norik.com; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=02WNvwWbhiZXAK+Og8doakRElfSqkd+xgpF6EcyVeOM=; b=nQR6d81So8H6ulfbWo6w7/62Tt 9UIBku5apau5ZsllmmiPChLLKmg2pxmQU7Vwh0mDmmUvSJUruAs3oH6tGup7hPM3fIhPm7ElGJSFm loIwEsEpau1Z2sXlifkO1uBXoexL/1tlUscOzRH2Gn2OogFyejupy6hRPw+s10Jb+yD57lFuRPH4v rA/pw9R0qwNgRz98kheULOFiOl9FBZ09Cryy8CdLdEaoB9anCmzRj7CFfBqYEByudVfjQMIbKECdx wzpuzuFb3voX7p/rU8XrEeYSx+LTx5Wwq/dXdAqdTRlkGqTfvarMCLZbkxdXzAR7Y7BsjnUp1hBIJ MQWXxddQ==; Received: from 89-212-21-243.static.t-2.net ([89.212.21.243]:46054 helo=[192.168.69.85]) by cpanel.siel.si with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.95) (envelope-from ) id 1ona3S-00C9YI-Mx; Wed, 26 Oct 2022 08:38:31 +0200 Message-ID: Date: Wed, 26 Oct 2022 08:38:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 2/3] dt-bindings: watchdog: fsl-imx: document suspend in wait mode Content-Language: en-GB To: Krzysztof Kozlowski , linux-watchdog@vger.kernel.org, Alexander Stein Cc: wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, Anson.Huang@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221025072533.2980154-1-andrej.picej@norik.com> <20221025072533.2980154-3-andrej.picej@norik.com> From: Andrej Picej In-Reply-To: X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel.siel.si X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - norik.com X-Get-Message-Sender-Via: cpanel.siel.si: authenticated_id: andrej.picej@norik.com X-Authenticated-Sender: cpanel.siel.si: andrej.picej@norik.com X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221025_233839_342088_D8DE69EE X-CRM114-Status: GOOD ( 15.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25. 10. 22 15:48, Krzysztof Kozlowski wrote: > On 25/10/2022 03:25, Andrej Picej wrote: >> Property "fsl,suspend-in-wait" suspends watchdog in "WAIT" mode which >> corresponds to Linux's Suspend-to-Idle S0 mode. If this property is not >> set and the device is put into Suspend-to-Idle mode, the watchdog >> triggers a reset after 128 seconds. >> >> Signed-off-by: Andrej Picej >> Reviewed-by: Fabio Estevam >> --- >> Changes in v2: >> - add a commit message, >> - add a list of devices which support this functionality >> --- >> .../bindings/watchdog/fsl-imx-wdt.yaml | 22 +++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >> index fb7695515be1..9289de97859b 100644 >> --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >> +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >> @@ -55,6 +55,28 @@ properties: >> If present, the watchdog device is configured to assert its >> external reset (WDOG_B) instead of issuing a software reset. >> >> + fsl,suspend-in-wait: >> + $ref: /schemas/types.yaml#/definitions/flag >> + description: | >> + If present, the watchdog device is suspended in WAIT mode >> + (Suspend-to-Idle). Only supported on following devices: >> + - "fsl,imx25-wdt", > > You need to define such allow/disallow in allOf:if:then, instead. Like > example-schema is doing for foo-supply, just disallow it for some types > or use "if: not: ..." Sorry missed that. So something like that should be added?: > allOf: > - if: > not: > properties: > compatible: > contains: > enum: > - fsl,imx25-wdt > - fsl,imx35-wdt > - fsl,imx50-wdt > - fsl,imx51-wdt > - fsl,imx53-wdt > - fsl,imx6q-wdt > - fsl,imx6sl-wdt > - fsl,imx6sll-wdt > - fsl,imx6sx-wdt > - fsl,imx6ul-wdt > - fsl,imx7d-wdt > - fsl,imx8mm-wdt > - fsl,imx8mn-wdt > - fsl,imx8mp-wdt > - fsl,imx8mq-wdt > - fsl,vf610-wdt > then: > properties: > fsl,suspend-in-wait: false And I'm assuming I can then remove the supported devices list from property description. Are you fine with this, so we don't have to split the compatible list like Alexander suggested? Basically we have the same list of WDW supported devices in the driver. Thank you for your review, Andrej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel