From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81F30C54E68 for ; Tue, 19 Mar 2024 21:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y/y3uLt1OCFmOAJAOAKGNQu/BNMdMFULB3myelEN1c8=; b=sApWzuTlVX/Rgs MFlNHSNxhGfSRjLX7UugZUUagosjI1pD+nWKANcBz1j0JvJxxvB5GZcre9671BcT0yCg7qGW9AGP0 3dk695ylRBDLI4/7xt0d7UHStsvejgS7tr5LLRDWzQfRBaAK9jhu0BLwnJkZVWSGVoCVYbrm/5Abb +up1Z05KwkosxahSeVXnxc5FArPnM4B1SFDeen2YcEOe7kGbGWojfatdkiwkZPuQdHFDXCj/p+N7c fJBn9cee++VZgAKnhjwX/Su/NHqueoj2pE9CgJ07UfFyTC0OfVciH+V4fvm82e9CxrLoF+QPxitzl e5XzLmKB4rVkCfzfsDFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmgfn-0000000EEbn-23Jo; Tue, 19 Mar 2024 21:07:03 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmgfi-0000000EEZz-3o8y for linux-arm-kernel@lists.infradead.org; Tue, 19 Mar 2024 21:07:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710882417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7qoGIHh6upwj5gPJ9J4YHu4wJ6ui1GNstsfCG9nUc0E=; b=VDJCz5Tynnr2Xh5kNuxMOSfalhvGJ3W3kd5n4gg5Km3HBNVuxmUL9xCIZbL3RNK2wd18hh eZioHpnHA9BfGYTcuxW3RbiFRFOIOKmxtcBe4CErce+MvpXFtM6mxgbPsCKzQRzafC/utK Pq2q+vQktK8NzqN5H7X8KGg5dkRas/g= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-686-915UWAusMLyiTBsAXoornw-1; Tue, 19 Mar 2024 17:06:55 -0400 X-MC-Unique: 915UWAusMLyiTBsAXoornw-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33ed44854ddso1902261f8f.2 for ; Tue, 19 Mar 2024 14:06:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710882415; x=1711487215; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7qoGIHh6upwj5gPJ9J4YHu4wJ6ui1GNstsfCG9nUc0E=; b=AD3x1eiRMu16MifCy8Q8D7PTyRnjdj7zXg/DZ91Kzx//XQALVLtwagNF00xy3JC/3L VekGw3+KS64gd418dwEHo6bTxST8/kCeaW3K9gaAQ2ZeBrU0l+ZwSntPaxDWB6y3aNAt ApIkSfFdFjn9lAz1Iz92qoVdqgsQGT6/rloGG8vmMY/luoFC1l8Rpi4eGN7efWwkAQTc 65yBqFyMuowndfn0MUAg2US86wxPEsvkJu1o9YxNXmxCdMtt1BCBkdlACImQFqXl8jr2 4SGPaAnHUOersjwhgVyXeOxXMNvMYQmaQ5bMvY9FCZXYAbS+y15i41wPgCMsRAApKPRC 66yw== X-Forwarded-Encrypted: i=1; AJvYcCWDVTZ/p9/6NpBRj8dWFBYc7fHf6ss24s+b05MAHy2GG0cWN+z0VKZiuZYkIV9ouJVRJaSb+UjYCLlrQEpymHew9QSlyUcTgxAsPIk1mTGezqtn5Fs= X-Gm-Message-State: AOJu0Yz8lGD+Ntyra72UvMlHa2Zd5n6ZVcdJTOTsRde/rerxR6Io9u47 eQW+8hj4SlxeRN9KAvgYKhZzQsE/ukeZl61vlGd701mWrVV7vMCw05OuGnotDo/IuNHsf0ZFWof Ay1jTaj8jK1p8C+NMYeZ8QFEQ0JtKtsrigBFIMio8gs1XY+s6b386mdcnTDxmtLc7EUFDro/O X-Received: by 2002:a05:6000:18c5:b0:33e:d865:422 with SMTP id w5-20020a05600018c500b0033ed8650422mr2390551wrq.29.1710882414770; Tue, 19 Mar 2024 14:06:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGYgibdY4jILLn+6ByyeP7Lg3sS+wv/bar0zDxWizyxRfyam0sxSD5OLYa520B4VKgbg/WBtw== X-Received: by 2002:a05:6000:18c5:b0:33e:d865:422 with SMTP id w5-20020a05600018c500b0033ed8650422mr2390545wrq.29.1710882414365; Tue, 19 Mar 2024 14:06:54 -0700 (PDT) Received: from ?IPV6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id n8-20020a5d6608000000b0033e45930f35sm13213779wru.6.2024.03.19.14.06.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Mar 2024 14:06:53 -0700 (PDT) Message-ID: Date: Tue, 19 Mar 2024 22:06:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/3] KVM: selftests: aarch64: Add invalid filter test in pmu_event_filter_test To: Shaoqin Huang , Oliver Upton , Marc Zyngier , kvmarm@lists.linux.dev Cc: James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Shuah Khan , linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240229065625.114207-1-shahuang@redhat.com> <20240229065625.114207-4-shahuang@redhat.com> From: Eric Auger In-Reply-To: <20240229065625.114207-4-shahuang@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240319_140659_124992_8D25E8CF X-CRM114-Status: GOOD ( 20.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/29/24 07:56, Shaoqin Huang wrote: > Add the invalid filter test which sets the filter beyond the event > space and sets the invalid action to double check if the > KVM_ARM_VCPU_PMU_V3_FILTER will return the expected error. > > Signed-off-by: Shaoqin Huang > --- > .../kvm/aarch64/pmu_event_filter_test.c | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/tools/testing/selftests/kvm/aarch64/pmu_event_filter_test.c b/tools/testing/selftests/kvm/aarch64/pmu_event_filter_test.c > index 2dd8ea418f47..86714345ee97 100644 > --- a/tools/testing/selftests/kvm/aarch64/pmu_event_filter_test.c > +++ b/tools/testing/selftests/kvm/aarch64/pmu_event_filter_test.c > @@ -8,6 +8,7 @@ > * This test checks if the guest only see the limited pmu event that userspace > * sets, if the guest can use those events which user allow, and if the guest > * can't use those events which user deny. > + * It also checks that setting invalid filter ranges return the expected error. > * This test runs only when KVM_CAP_ARM_PMU_V3, KVM_ARM_VCPU_PMU_V3_FILTER > * is supported on the host. > */ > @@ -262,6 +263,41 @@ static void run_tests(void) > run_test(t); > } > > +static void test_invalid_filter(void) > +{ > + struct kvm_pmu_event_filter invalid; > + int ret; > + > + pr_info("Test: test_invalid_filter\n"); > + > + memset(&vpmu_vm, 0, sizeof(vpmu_vm)); > + > + vpmu_vm.vm = vm_create(1); > + vpmu_vm.vcpu = vm_vcpu_add_with_vpmu(vpmu_vm.vm, 0, guest_code); > + vpmu_vm.gic_fd = vgic_v3_setup(vpmu_vm.vm, 1, 64, > + GICD_BASE_GPA, GICR_BASE_GPA); > + __TEST_REQUIRE(vpmu_vm.gic_fd >= 0, > + "Failed to create vgic-v3, skipping"); > + > + /* The max event number is (1 << 16), set a range largeer than it. */the event space is 16b on ARMv8.1 and 10b on ARMv8.0, set a range larger than 16 s/largeer/larger > + invalid = __DEFINE_FILTER(BIT(15), BIT(15) + 1, 0); > + ret = __kvm_device_attr_set(vpmu_vm.vcpu->fd, KVM_ARM_VCPU_PMU_V3_CTRL, > + KVM_ARM_VCPU_PMU_V3_FILTER, &invalid); > + TEST_ASSERT(ret && errno == EINVAL, "Set Invalid filter range " > + "ret = %d, errno = %d (expected ret = -1, errno = EINVAL)", > + ret, errno); > + > + /* Set the Invalid action. */ s/the/an > + invalid = __DEFINE_FILTER(0, 1, 3); > + ret = __kvm_device_attr_set(vpmu_vm.vcpu->fd, KVM_ARM_VCPU_PMU_V3_CTRL, > + KVM_ARM_VCPU_PMU_V3_FILTER, &invalid); > + TEST_ASSERT(ret && errno == EINVAL, "Set Invalid filter action " > + "ret = %d, errno = %d (expected ret = -1, errno = EINVAL)", > + ret, errno); > + > + destroy_vpmu_vm(); > +} > + > static bool kvm_pmu_support_events(void) > { > create_vpmu_vm(guest_get_pmceid); > @@ -284,4 +320,6 @@ int main(void) > TEST_REQUIRE(kvm_pmu_support_events()); > > run_tests(); > + > + test_invalid_filter(); > } Besides Reviewed-by: Eric Auger Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel