From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC7F0606A880 for ; Fri, 13 Nov 2026 10:35:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=wA7ZwyhI; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=foss header.b=CfPYA20M DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=UpzUl6Ub7qj0VCNsKpvsnstUGxXQkrlCAFOk2MgdIm0=; b=wA7ZwyhIbjFJop 0WrlJgA3DM14h6RUkRS39e2eWhSJOH3KXE2YvDpSTB86hOaGFyJOoKqFgfDMeX9hts1RDYJlFOqZI VTwWErPw+Zh6/fGFIM2tgWAfL3C2o0ECYA1US6JcZzQGVO116eBAo9Gjzp7NupZ13honpBkQtzkux gPR1QPMt5MZZiEoE2lGM8hZBgQ7cpFrJimwHxnrh9iPWGgASo0+Yy6BMA6Ufs1e99G6wFVtf9ulQE l2CzuSlJwwVA+armIgKvxDzKH1CencQDq3o/ICOLU5oHD/qNgYIB6oii58ldyPfShYZ7eLbtrNGjX qTgn48ZAYo67aPWGxtBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRocX-0000000CNyr-2uIB; Fri, 13 Nov 2026 10:35:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRocU-0000000CNxv-47W5 for linux-arm-kernel@lists.infradead.org; Fri, 13 Nov 2026 10:35:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 377331595; Fri, 13 Nov 2026 02:34:54 -0800 (PST) Received: from [10.57.67.215] (unknown [10.57.67.215]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 20A463F673; Fri, 13 Nov 2026 02:34:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1794566097; bh=V47alnlPPG/CS5dBHeIwkAec8FR4ukqqWs4Hqwo3pbA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CfPYA20MM+A5raPXZDz/mUuGGSSceVaPtpGRqFXjqpmrwk7iSsXl4K88biuBYGQ0Y /6UK9BK/uaXymBQaGK8AU3xFZCiHtbgdQ6welb17yYdietgRP0fE7p0ECzsj8ZuGD2 1vYoQOxgNIDxJJEZPsUX5oMzBH5TJhmZfYj6u80g= Message-ID: Date: Fri, 13 Nov 2026 10:34:53 +0000 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v17 03/10] qcom-tgu: Add TGU driver Content-Language: en-GB To: Songwei Chai , andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, konrad.dybcio@oss.qualcomm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, songchai@qti.qualcomm.com, Jie Gan References: <20261113024935.3173715-1-songwei.chai@oss.qualcomm.com> <20261113024935.3173715-4-songwei.chai@oss.qualcomm.com> From: Suzuki K Poulose In-Reply-To: <20261113024935.3173715-4-songwei.chai@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261113_023459_117798_1A4813EB X-CRM114-Status: GOOD ( 24.32 ) X-Spam-Score: -4.4 (----) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-22.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 13/11/2026 02:49, Songwei Chai wrote: > Add driver to support device TGU (Trigger Generation Unit). > TGU is a Data Engine which can be utilized to sense a plurality of > signals and create a trigger into the CTI or generate interrupts to > processors. Add probe/enable/disable functions for tgu. > > Acked-by: Konrad Dybcio > Reviewed-by: Jie Gan > Signed-off-by: Songwei Chai > --- > .../ABI/testing/sysfs-bus-amba-devices-tgu | 9 + > MAINTAINERS | 11 + > drivers/Makefile | 1 + > drivers/hwtracing/Kconfig | 2 + > drivers/hwtracing/qcom/Kconfig | 20 ++ > drivers/hwtracing/qcom/Makefile | 3 + > drivers/hwtracing/qcom/tgu.c | 193 ++++++++++++++++++ > drivers/hwtracing/qcom/tgu.h | 31 +++ > 8 files changed, 270 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > create mode 100644 drivers/hwtracing/qcom/Kconfig > create mode 100644 drivers/hwtracing/qcom/Makefile > create mode 100644 drivers/hwtracing/qcom/tgu.c > create mode 100644 drivers/hwtracing/qcom/tgu.h > > diff --git a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > new file mode 100644 > index 000000000000..66b12ffc2892 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > @@ -0,0 +1,9 @@ > +What: /sys/bus/amba/devices//enable_tgu > +Date: November 2026 > +KernelVersion: 7.5 > +Contact: Jinlong Mao , Songwei Chai > +Description: > + (RW) Set/Get the enable/disable status of TGU > + Accepts only one of the 2 values - 0 or 1. > + 0 : disable TGU. > + 1 : enable TGU. > diff --git a/MAINTAINERS b/MAINTAINERS > index fe23913b1e43..faf8706b6584 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -23264,6 +23264,17 @@ S: Maintained > F: Documentation/tee/qtee.rst > F: drivers/tee/qcomtee/ > > +QUALCOMM HARDWARETRACING DRIVER nit: HARDWARE TRACING DRIVER > +M: Songwei Chai > +M: Jie Gan > +M: Suzuki K Poulose > +L: linux-arm-msm@vger.kernel.org > +S: Maintained > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git > +F: Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > +F: Documentation/devicetree/bindings/arm/qcom,tgu.yaml > +F: drivers/hwtracing/qcom/ > + > QUALCOMM TRUST ZONE MEMORY ALLOCATOR > M: Bartosz Golaszewski > L: linux-arm-msm@vger.kernel.org > diff --git a/drivers/Makefile b/drivers/Makefile > index 0841ea851847..f37edcf34e0d 100644 > --- a/drivers/Makefile > +++ b/drivers/Makefile > @@ -176,6 +176,7 @@ obj-$(CONFIG_RAS) += ras/ > obj-$(CONFIG_USB4) += thunderbolt/ > obj-$(CONFIG_CORESIGHT) += hwtracing/coresight/ > obj-y += hwtracing/intel_th/ > +obj-$(CONFIG_QCOM_TGU) += hwtracing/qcom/ > obj-$(CONFIG_STM) += hwtracing/stm/ > obj-$(CONFIG_HISI_PTT) += hwtracing/ptt/ > obj-y += android/ > diff --git a/drivers/hwtracing/Kconfig b/drivers/hwtracing/Kconfig > index 911ee977103c..8a640218eed8 100644 > --- a/drivers/hwtracing/Kconfig > +++ b/drivers/hwtracing/Kconfig > @@ -7,4 +7,6 @@ source "drivers/hwtracing/intel_th/Kconfig" > > source "drivers/hwtracing/ptt/Kconfig" > > +source "drivers/hwtracing/qcom/Kconfig" > + > endmenu > diff --git a/drivers/hwtracing/qcom/Kconfig b/drivers/hwtracing/qcom/Kconfig > new file mode 100644 > index 000000000000..5c94c75ffa39 > --- /dev/null > +++ b/drivers/hwtracing/qcom/Kconfig > @@ -0,0 +1,20 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# QCOM specific hwtracing drivers > +# > +menu "Qualcomm specific hwtracing drivers" > + > +config QCOM_TGU > + tristate "QCOM Trigger Generation Unit driver" > + depends on ARCH_QCOM || COMPILE_TEST > + depends on ARM_AMBA > + help > + This driver provides support for Trigger Generation Unit that is > + used to detect patterns or sequences on a given set of signals. > + TGU is used to monitor a particular bus within a given region to > + detect illegal transaction sequences or slave responses. It is also > + used to monitor a data stream to detect protocol violations and to > + provide a trigger point for centering data around a specific event > + within the trace data buffer. > + > +endmenu > diff --git a/drivers/hwtracing/qcom/Makefile b/drivers/hwtracing/qcom/Makefile > new file mode 100644 > index 000000000000..5a0a868c1ea0 > --- /dev/null > +++ b/drivers/hwtracing/qcom/Makefile > @@ -0,0 +1,3 @@ > +# SPDX-License-Identifier: GPL-2.0 > + > +obj-$(CONFIG_QCOM_TGU) += tgu.o > diff --git a/drivers/hwtracing/qcom/tgu.c b/drivers/hwtracing/qcom/tgu.c > new file mode 100644 > index 000000000000..ac1ae8bb0ec4 > --- /dev/null > +++ b/drivers/hwtracing/qcom/tgu.c > @@ -0,0 +1,193 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "tgu.h" ... > +static ssize_t enable_tgu_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ ... > +} > + > +/* enable_tgu_store - Enable or disable the Trigger Generation Unit (TGU). */ > +static ssize_t enable_tgu_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, > + size_t size) > +{ ... > +} > +static DEVICE_ATTR_RW(enable_tgu); minor nit: Do we need "enable_tgu" in the name under /sys/.../tgu0/ ? Couldn' this be "enable" ? Also, the function names could be named as "tgu_enable_store/show" Suzuki