From: "CK Hu (胡俊光)" <ck.hu@mediatek.com>
To: "angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"wenst@chromium.org" <wenst@chromium.org>,
"kernel@collabora.com" <kernel@collabora.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"ehristev@collabora.com" <ehristev@collabora.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Subject: Re: [PATCH v10 14/16] drm/mediatek: aal: Rewrite kerneldoc for struct mtk_disp_aal
Date: Wed, 4 Oct 2023 06:41:02 +0000 [thread overview]
Message-ID: <a62c60b2ab55e3f7594b3d2c3584c27ab7130bd1.camel@mediatek.com> (raw)
In-Reply-To: <20230804072850.89365-15-angelogioacchino.delregno@collabora.com>
Hi, Angelo:
On Fri, 2023-08-04 at 09:28 +0200, AngeloGioacchino Del Regno wrote:
> The kerneldoc for struct mtk_disp_aal was entirely wrong: rewrite it
> to actually document the structure.
Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> Signed-off-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> ---
> drivers/gpu/drm/mediatek/mtk_disp_aal.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_aal.c
> b/drivers/gpu/drm/mediatek/mtk_disp_aal.c
> index 992dc1424c91..e6ab3eaa1126 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_aal.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_aal.c
> @@ -36,9 +36,11 @@ struct mtk_disp_aal_data {
> };
>
> /**
> - * struct mtk_disp_aal - DISP_AAL driver structure
> - * @ddp_comp - structure containing type enum and hardware resources
> - * @crtc - associated crtc to report irq events to
> + * struct mtk_disp_aal - Display Adaptive Ambient Light driver
> structure
> + * @clk: clock for DISP_AAL controller
> + * @regs: MMIO registers base
> + * @cmdq_reg: CMDQ Client register
> + * @data: platform specific data for DISP_AAL
> */
> struct mtk_disp_aal {
> struct clk *clk;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-04 7:02 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 7:28 [PATCH v10 00/16] MediaTek DDP GAMMA - 12-bit LUT support AngeloGioacchino Del Regno
2023-08-04 7:28 ` [PATCH v10 01/16] drm/mediatek: gamma: Adjust mtk_drm_gamma_set_common parameters AngeloGioacchino Del Regno
2023-10-12 7:51 ` CK Hu (胡俊光)
2023-08-04 7:28 ` [PATCH v10 02/16] drm/mediatek: gamma: Reduce indentation in mtk_gamma_set_common() AngeloGioacchino Del Regno
2023-10-12 7:48 ` CK Hu (胡俊光)
2023-08-04 7:28 ` [PATCH v10 03/16] drm/mediatek: gamma: Support SoC specific LUT size AngeloGioacchino Del Regno
2023-09-18 2:30 ` CK Hu (胡俊光)
2023-09-20 8:08 ` AngeloGioacchino Del Regno
2023-10-12 6:56 ` CK Hu (胡俊光)
2023-08-04 7:28 ` [PATCH v10 04/16] drm/mediatek: gamma: Improve and simplify HW LUT calculation AngeloGioacchino Del Regno
2023-10-12 6:45 ` CK Hu (胡俊光)
2023-08-04 7:28 ` [PATCH v10 05/16] drm/mediatek: gamma: Enable the Gamma LUT table only after programming AngeloGioacchino Del Regno
2023-10-12 5:17 ` CK Hu (胡俊光)
2023-08-04 7:28 ` [PATCH v10 06/16] drm/mediatek: gamma: Use bitfield macros AngeloGioacchino Del Regno
2023-10-12 4:12 ` CK Hu (胡俊光)
2023-08-04 7:28 ` [PATCH v10 07/16] drm/mediatek: aal: " AngeloGioacchino Del Regno
2023-10-11 13:18 ` Nícolas F. R. A. Prado
2023-10-12 4:05 ` CK Hu (胡俊光)
2023-08-04 7:28 ` [PATCH v10 08/16] drm/mediatek: De-commonize disp_aal/disp_gamma gamma_set functions AngeloGioacchino Del Regno
2023-10-11 16:05 ` Nícolas F. R. A. Prado
2023-10-12 2:22 ` CK Hu (胡俊光)
2023-08-04 7:28 ` [PATCH v10 09/16] drm/mediatek: gamma: Support specifying number of bits per LUT component AngeloGioacchino Del Regno
2023-10-12 3:52 ` CK Hu (胡俊光)
2023-08-04 7:28 ` [PATCH v10 10/16] drm/mediatek: gamma: Support multi-bank gamma LUT AngeloGioacchino Del Regno
2023-10-12 3:36 ` CK Hu (胡俊光)
2023-08-04 7:28 ` [PATCH v10 11/16] drm/mediatek: gamma: Add support for 12-bit LUT and MT8195 AngeloGioacchino Del Regno
2023-08-15 7:57 ` Chen-Yu Tsai
2023-09-14 10:32 ` AngeloGioacchino Del Regno
2023-10-12 3:20 ` CK Hu (胡俊光)
2023-08-04 7:28 ` [PATCH v10 12/16] drm/mediatek: gamma: Make sure relay mode is disabled AngeloGioacchino Del Regno
2023-10-12 2:29 ` CK Hu (胡俊光)
2023-08-04 7:28 ` [PATCH v10 13/16] drm/mediatek: gamma: Program gamma LUT type for descending or rising AngeloGioacchino Del Regno
2023-10-12 1:40 ` CK Hu (胡俊光)
2023-08-04 7:28 ` [PATCH v10 14/16] drm/mediatek: aal: Rewrite kerneldoc for struct mtk_disp_aal AngeloGioacchino Del Regno
2023-10-04 6:41 ` CK Hu (胡俊光) [this message]
2023-08-04 7:28 ` [PATCH v10 15/16] drm/mediatek: gamma: Add kerneldoc for struct mtk_disp_gamma AngeloGioacchino Del Regno
2023-10-04 6:28 ` CK Hu (胡俊光)
2023-08-04 7:28 ` [PATCH v10 16/16] drm/mediatek: aal: Compress of_device_id entries and add sentinel AngeloGioacchino Del Regno
2023-10-04 3:56 ` CK Hu (胡俊光)
2023-10-11 12:03 ` [PATCH v10 00/16] MediaTek DDP GAMMA - 12-bit LUT support AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a62c60b2ab55e3f7594b3d2c3584c27ab7130bd1.camel@mediatek.com \
--to=ck.hu@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ehristev@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).