From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4731DE8FDD4 for ; Wed, 4 Oct 2023 07:02:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EDTPg0s5EesOmD1q6fzDOtCPMJxJXElmejVmnlYudbM=; b=TyvIM060S6VufC otSIB4n+7PAw4sJbsOJmfb/tFM6yDxEWmkcEANmKcw97Dbh3ZtE8C7VE7lIeCXtn3Ez3RBTDteLcN CIpDHywsJWpHo06vBQ0eDTOypMmaB4XsRtzdkGBemgn9DuqZzoqbgKnzwJry4Xb/9+n6MNYqJ2wQD xTaWTiQHFhPT2iC/6sqznvexNa3NpKDmgPhtZvaIae+b6mI4XuLj28Wws5kADoG6y9598iVNgSnMg 6qugS2FcCldFb1LNm/CamKpb1EEqq5bArAtkjCTNYNwacvA3piJGXbBaOCsPCGMCxReYdHwI4Wy5r kXdpSTNCOxONOVRZ7bRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnvtF-00GWBV-2I; Wed, 04 Oct 2023 07:01:49 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnvtC-00GW8r-2v; Wed, 04 Oct 2023 07:01:48 +0000 X-UUID: df79c5ba628311ee9b7791016c24628a-20231004 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=eotFIPzQxb5iNMDY7eUgoCMJ6lU2KdLM+flKTGBsLGA=; b=JTlZMfgpJm3MyTdkz1wtuTlvThPBirPTOVUABrLjXCqEVDFr2hxdpgMnLzQOmbzDxup2TBdbbOWNgAPFaYa1EkHuUYVIHp37R3T3OiVIDU2T3f7DbxBlPX53jgLcwry7VlGgprR6PrGnbXfzCGvIQB0Xnko+T3iUm7F8t7dtf+4=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.32,REQID:3eeefa95-f8ed-4d25-b2ce-fa8b1a48749a,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:5f78ec9,CLOUDID:782991bf-14cc-44ca-b657-2d2783296e72,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR: NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULN X-UUID: df79c5ba628311ee9b7791016c24628a-20231004 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1693848130; Wed, 04 Oct 2023 00:01:42 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs13n2.mediatek.inc (172.21.101.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 4 Oct 2023 14:41:05 +0800 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Wed, 4 Oct 2023 14:41:05 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ho/DLvyFADV46MpYWIx+bjCSTrx+0XUtSLJsLyUCmmGKuqRPRHQACdHNGyJRca39P9zde0Q9J6Cabk0R67pjASku7+rIDZHso1D1VTpIOYJDC6tgSZBO14folSypopycv4+0lOg44ILA6wQSKdIxGUaUQO8W57eXKW+StkDAU10igRgOOfIxhtb59KBI9+oNhlTj1H44l4FFJ+q5u1T0d0cSQVafZjOQAC5UXbhsAP6syOuNjFytuCDguvNLZeu1AwemIqOcor/otfZWGlufS+VxQqfm4Har/emsNZtW0hLGqJb1p4gYwOzPNTdGky/BhKQhUZpoHV9pQDSHNeicBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eotFIPzQxb5iNMDY7eUgoCMJ6lU2KdLM+flKTGBsLGA=; b=YA7tslVo/12qI0b01/17xsGh8wg1Fg5khz0HN6F8bOb6/PFYm/6aQhe7w17czZbb3KZOblnTiAWtUxBX6jgZtohAegCZ/41coYWTPBPaBoMOq0vgjlHS79a8KdSIEmPozWyhtaxMr3H9P8TB9Hd5myytWZ3h8bF8URDDVc0nR2wfQFNkiWAAylbpEnYTEf+XTDcdSDLaQYdVpSYOyeuSASKJBFBuqJ6eOFJAZ5Jj68c978g47w1fWh8IXt8SdX2Efl4svbkJJKS03nHC9+PSzlg7TSWNtPhDRXEaF7wM74zRNKBhFO9wcZIgg/AGamMdfiGS1pLvkFen0bpLcSpFsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eotFIPzQxb5iNMDY7eUgoCMJ6lU2KdLM+flKTGBsLGA=; b=T3EDxVqY8ThcQY3Q2j0Kws4cKIqs9dQPAqJ1aLcrJ5T2AV3l9WBebWdlDVaWYXo3qy2wKOgDOLRPTnoOKlUzh+kBHcCCtyMKWGMiO27yPkfVyCz4J1dH4vvRmxwRlVmgcNF7hPZbx6Ylj7OoKbku+wrFGfaBSwasgs615+j7FDs= Received: from TYZPR03MB6624.apcprd03.prod.outlook.com (2603:1096:400:1f4::13) by TY0PR03MB6473.apcprd03.prod.outlook.com (2603:1096:400:1bf::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Wed, 4 Oct 2023 06:41:02 +0000 Received: from TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::9c2c:c08a:212f:e984]) by TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::9c2c:c08a:212f:e984%7]) with mapi id 15.20.6792.026; Wed, 4 Oct 2023 06:41:02 +0000 From: =?utf-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= To: "angelogioacchino.delregno@collabora.com" , "chunkuang.hu@kernel.org" CC: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "wenst@chromium.org" , "kernel@collabora.com" , "dri-devel@lists.freedesktop.org" , "ehristev@collabora.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" Subject: Re: [PATCH v10 14/16] drm/mediatek: aal: Rewrite kerneldoc for struct mtk_disp_aal Thread-Topic: [PATCH v10 14/16] drm/mediatek: aal: Rewrite kerneldoc for struct mtk_disp_aal Thread-Index: AQHZxqWQLuwVe/7AdUSFGkEJbvd4YbA5ji+A Date: Wed, 4 Oct 2023 06:41:02 +0000 Message-ID: References: <20230804072850.89365-1-angelogioacchino.delregno@collabora.com> <20230804072850.89365-15-angelogioacchino.delregno@collabora.com> In-Reply-To: <20230804072850.89365-15-angelogioacchino.delregno@collabora.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB6624:EE_|TY0PR03MB6473:EE_ x-ms-office365-filtering-correlation-id: 8cc80ffd-7a3c-4660-fa07-08dbc4a4e083 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7vtxGCdWh58OuJR0b56KtYtJUbFkHkrUM0abas23k6TA4Upu69ElopyglPmG6ATKRiOXX6FDSOOvcUihT/fn1Vt2I5ZYtqT1jPxOhdvlz2aj4kxzDMChSbeX+Dh5RFSCRzPyH1ff3lL2akwJfpX0O/AsicGkA6UtW/waD+p+JwoGUR5MZwbeUUeiUd984ykgwFQ1EtyD5Xeo3bE1N7uH2WL0/rlNCfLio1LFcuzF56gegkwsrbUxfSk2jZE/dcW9Kw16GQmLZrkbO8cS8cM4JANHEpqC1fRIIbRcoiC3p8ErUoz5FvXMCqO+A2ST5oI2TX5FNTkIjFQOE7/+QvuBdY/QjzgpQbp8mVcZMwxL4sr8FO4rITyxLdp6WQql+Daq4Wji/9No4+Pj4Ua0xKnFKly2ths0VAkYrxTJv4rPS0mlew7x3Otu3RlJCRj99AHdNDJdirRavsuk93olr5NevdUfyKJDAkIhd0bk5dlWDHaiffjOT7xqnPPHf24OOmMcMaioGIMtRGStuVSOm/KVgl7r6l4WA3ph4yvNtBZ874uI7gLu6akGkquegSfy3PfF6ZoTpyNwr1mUVQM6F9OquA7v0+8so4Ti2DurzucHRSlQiSjA7JDQMltd+6emrLKKzCJnA8jbIt0lu5CfPlL7qvS3pia+/3wlz+8N95MJ8bo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB6624.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(396003)(376002)(366004)(39860400002)(230922051799003)(1800799009)(186009)(64100799003)(451199024)(6506007)(6486002)(478600001)(71200400001)(83380400001)(2616005)(6512007)(26005)(7416002)(66556008)(2906002)(5660300002)(41300700001)(76116006)(66946007)(66446008)(316002)(4326008)(54906003)(64756008)(110136005)(66476007)(8936002)(8676002)(36756003)(85182001)(38070700005)(122000001)(38100700002)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MEFaSnlvTDAyR0I5WVlQRTUxK29VS0NSN3VSckZyWnJNUlg5Y3drenpGd2s1?= =?utf-8?B?b3J5amtRQWtDRURxd1ZvbG96K2g4MS9meWJ0bmxQclZ2Slk3Y3dBT2ZZSm1p?= =?utf-8?B?aDlhVEpKbXJRZTBXcGkycU1UUzB2ZmhwdmdUdWNZeW1CTC8ycWFjaG93VXFB?= =?utf-8?B?QnBVcm13a2dTNE5HK3Jpb3Y5emtESlpRR1Zya0VFcnM1QkVDUjh5czZkbXNH?= =?utf-8?B?Q0JTajBpcVNVV3RVdlZWN21jYTV0YURKZ1kvbHRFczNrM1lMZCtxbXV2Umh1?= =?utf-8?B?clVUWHhQQ0dqanFIMVRIRjRtVGZwR29yNlhXNHNDMUhscEpsai9mbWRvV1dU?= =?utf-8?B?dUJ5OE5pQ3ZhRFJ5SFVmZldSWjlLN1RwS1ZPb1JsYzFDQlE0Y3dLbW5IVjJh?= =?utf-8?B?TTUwbTZZbmVueTZZL0RrWDVya2ZGVG5mUGxoTmt0ZGwrc2xVR0pIbndZRTJ4?= =?utf-8?B?d1ZVSC9Lc3NVK2VqVmxwdm85cTdRcWhGK053c0dxSi8wN1B0OHcyN0hsaEc5?= =?utf-8?B?VVBVNXU0UEN0WktOT3NmZ3RwOXhBOTJqSzFja05kS2sxc2piV215cy9xRTd6?= =?utf-8?B?NGdXdnVOVEZ5MjM1OVRTdUZTbmQyMDNOTTRSR0kxUlZucTd6YXJFUFZtQ2JD?= =?utf-8?B?T0lMcTVRU2JHNWJMNzJGbnNvaCtKbUZmeHJacTNXZS95L2xoQUIzK2NPQ0pY?= =?utf-8?B?bkRESGlJZ1ltUGFWL1IzWmVFWUVlSW1SaDVvRHJZSG9oMWI4aDVJQVN3L3dv?= =?utf-8?B?cFhTRXAzN0JFSXYwa2lvNzNhOWFtOW9SVkFHTURmMWRtSkFNMWU1SS9EVDdr?= =?utf-8?B?WHRYQWdrdThhc0t0MzU3dVBCeitGelJCWXJ5dmI1amc0N0RKOXkvWnh2NHVX?= =?utf-8?B?b0NLbWkyRUdCdW1nSU5QLytRckt6UzNWUnNiaEJXcDY5TzQyTGR0VzdXUVRR?= =?utf-8?B?TUF6QWY2aDFTaHhhQlJOak4ydzEvOWc2Y21HK3psaW4rTlJ0M2V4NXFITEV2?= =?utf-8?B?TXRsUXkrUWhXWjBDT0Q1b3I3OVV4OXkwRm9VSldtOTllaDRNQmh2OHBWaWRJ?= =?utf-8?B?RVlFWXVFUEdPODJJQWdoVXU1dVdXZUpZNHpWYytJR25qN1ZOM1IxQVNiaElk?= =?utf-8?B?K0JnaHJQNlovdzkxWCt0STRCV29nV21nNFUrK0xROTRYY1FNMzBndCtoMkdW?= =?utf-8?B?SmlOa2RnbEc4N3JsNU5Ia1ZXQW1zV2lUMWhRUkVsWDV2WlA5Y3hHcXlJWm9D?= =?utf-8?B?bzdHbVFobFJIeVBtZWlLWHkvNzRDbGc1NTRMMmlOa2VBZklRRUppSFFxWFps?= =?utf-8?B?WG5KdE9aOUw5bkFnZyt1MTlyWEViMU16TUdPeFZBN2dzWTd2R09Cc0NYcS8y?= =?utf-8?B?R05rb3NEMStDeUI0N1U4cEppQmduMnRNR3BIMUJJMVZuenZ6ZENjSE5qQ09N?= =?utf-8?B?bzJXK2I5dzZUVStkU3Z6YVNjNHlLYkhzOXFHUkFiMnhka0x1THNFZW10T2pR?= =?utf-8?B?Q01lakJiS1Zmc20yaW1YNGlFdDlCKzk1V0ZWcDZVdkx6TEtMNkFxSDFpTE9o?= =?utf-8?B?YS9GR0NGcEE0eDRWLy9CYk95dTAvK3ZtT253VDduWGJYUys3VEwxZ3ZueTl6?= =?utf-8?B?ZXRyazRpcjlrVkpVSmppTEFBYXQwK09pUjdkeXAwMUhZa1pXUmlpdFZiUVRS?= =?utf-8?B?dUdyUEYyaGo3ZzJmWDgwOU55OEVDZTV2cXdybDZpS1pyRFFtZU54d3RRSlBV?= =?utf-8?B?Mlk4YlFIck56RFpqV1VnM3lWRi95WHUvR1ZnSzBVdFpmRHBNSWYvR2M2RTNZ?= =?utf-8?B?Vk40L2hzaWs1WThVMlZ1bkY1bDhRZ2dWTUYzVk9QK0FySndOSWV0WGIwRXQr?= =?utf-8?B?a1RidEZLNGxCazF5TEo1N29iTmZkMEZFdUJ4T3BjN0ZEcW43QXIxZ0FOb2gy?= =?utf-8?B?UGJ4eS9ZQkFTWC9UbmRTaEkyVDFGdHdzOUhYditoKzZpdGkrSzR2dzlwdktM?= =?utf-8?B?eDd4cnFpT0RxejF0dzRzQVNZNThqOTNoZm5IRVRzSXYvYVRXbExVR0FtWlQv?= =?utf-8?B?VUFvVjN2SFJ6MEFlR3lrSGJUUi8xN3g5WXlMUm5EdzdnUTNkKzdzaUpLM0Nz?= =?utf-8?Q?G5Wq4A9STGjZJKlS/ST4NkAU1?= Content-ID: <358F72B6CBBF374DAC33801D5FE6F770@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6624.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8cc80ffd-7a3c-4660-fa07-08dbc4a4e083 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2023 06:41:02.3353 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oIhWkAoSqBY4jnm3I4a8Y+JkGHoZtlhxxbkIY4Jru6SqRKGbp3aL6ggtlueRXb2Lv7gIslAEfRQi57DvTdGD7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR03MB6473 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231004_000146_979747_4405FD3F X-CRM114-Status: GOOD ( 16.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Angelo: On Fri, 2023-08-04 at 09:28 +0200, AngeloGioacchino Del Regno wrote: > The kerneldoc for struct mtk_disp_aal was entirely wrong: rewrite it > to actually document the structure. Reviewed-by: CK Hu > > Signed-off-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > --- > drivers/gpu/drm/mediatek/mtk_disp_aal.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_aal.c > b/drivers/gpu/drm/mediatek/mtk_disp_aal.c > index 992dc1424c91..e6ab3eaa1126 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_aal.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_aal.c > @@ -36,9 +36,11 @@ struct mtk_disp_aal_data { > }; > > /** > - * struct mtk_disp_aal - DISP_AAL driver structure > - * @ddp_comp - structure containing type enum and hardware resources > - * @crtc - associated crtc to report irq events to > + * struct mtk_disp_aal - Display Adaptive Ambient Light driver > structure > + * @clk: clock for DISP_AAL controller > + * @regs: MMIO registers base > + * @cmdq_reg: CMDQ Client register > + * @data: platform specific data for DISP_AAL > */ > struct mtk_disp_aal { > struct clk *clk; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel