From: Heiner Kallweit <hkallweit1@gmail.com>
To: Tony Lindgren <tony@atomide.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Andrew Lunn <andrew@lunn.ch>,
Clemens Gruber <clemens.gruber@pqgruber.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
WingMan Kwok <w-kwok2@ti.com>, Keerthy <j-keerthy@ti.com>,
Sekhar Nori <nsekhar@ti.com>,
linux-kernel@vger.kernel.org, Tero Kristo <t-kristo@ti.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Murali Karicheri <m-karicheri2@ti.com>,
linux-arm-kernel@lists.infradead.org, Rex Chang <rchang@ti.com>,
netdev@vger.kernel.org, linux-omap@vger.kernel.org,
Chris Healy <cphealy@gmail.com>
Subject: Re: Regression in v4.20 with net phy soft reset changes
Date: Wed, 9 Jan 2019 20:28:21 +0100 [thread overview]
Message-ID: <a63ca542-db96-40ed-201d-59c609f565ce@gmail.com> (raw)
In-Reply-To: <20190109190650.GT5544@atomide.com>
On 09.01.2019 20:06, Tony Lindgren wrote:
> Hi all,
>
> Commit 6e2d85ec0559 ("net: phy: Stop with excessive soft reset") caused
> a regression where suspend resume cycle fails to bring up Ethernet on at
> least cpsw on am437x-sk-evm.
>
What kind of PHY and which PHY driver is used with this board?
I found one schematics of am437x where a KSZ9031RN PHY is used.
Is it the same on your board?
As described in the commit message of this commit you would have
the option to implement the soft_reset callback in the PHY driver.
Can you try to add .soft_reset = genphy_soft_reset to the
KSZ9031 driver config in drivers/net/phy/micrel.c and check whether
it fixes the issue?
> Keerthy noticed this may not happen on the first resume, but usually
> happens after few suspend resume cycles. The most working suspend resume
> cycles I've seen with the commit above is three.
>
> Any ideas what might be going wrong?
>
> Note that unrelated to the commit above, there may be other issues too
> as the cpsw phy LED seems to come on only after about five seconds with
> about total of 10 seconds before the Ethernet is up again.
>
> Regards,
>
> Tony
>
Heiner
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-09 19:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 19:06 Regression in v4.20 with net phy soft reset changes Tony Lindgren
2019-01-09 19:28 ` Heiner Kallweit [this message]
2019-01-09 21:36 ` Tony Lindgren
2019-01-09 21:54 ` Heiner Kallweit
[not found] ` <5bdce91b-cd56-75eb-c6d2-5542869b716e@ti.com>
2019-01-10 5:50 ` Keerthy
2019-01-10 11:52 ` Sekhar Nori
2019-01-10 16:09 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a63ca542-db96-40ed-201d-59c609f565ce@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=bgolaszewski@baylibre.com \
--cc=clemens.gruber@pqgruber.com \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=rchang@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
--cc=w-kwok2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).