From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Alexander Dahl <ada@thorsis.com>, <linux-mtd@lists.infradead.org>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Kees Cook <kees@kernel.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
"moderated list:ARM/Microchip (AT91) SoC support"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mtd: nand: raw: atmel: Add message on DMA usage
Date: Thu, 22 Aug 2024 17:54:53 +0200 [thread overview]
Message-ID: <a65c4728-4cec-4fb0-a00f-052b0e08d7c1@microchip.com> (raw)
In-Reply-To: <20240821142006.645306-1-ada@thorsis.com>
On 21/08/2024 at 16:20, Alexander Dahl wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Like for other atmel drivers (serial, crypto, mmc, …), too.
>
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
>
> Notes:
> v1 -> v2:
> - make info message conditional (thanks Miquel)
>
> drivers/mtd/nand/raw/atmel/nand-controller.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
> index dc75d50d52e8..f9ccfd02e804 100644
> --- a/drivers/mtd/nand/raw/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
> @@ -2049,7 +2049,10 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc,
> dma_cap_set(DMA_MEMCPY, mask);
>
> nc->dmac = dma_request_channel(mask, NULL, NULL);
> - if (!nc->dmac)
> + if (nc->dmac)
> + dev_info(nc->dev, "using %s for DMA transfers\n",
> + dma_chan_name(nc->dmac));
> + else
> dev_err(nc->dev, "Failed to request DMA channel\n");
> }
>
>
> base-commit: 47ac09b91befbb6a235ab620c32af719f8208399
> --
> 2.39.2
>
next prev parent reply other threads:[~2024-08-22 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 14:20 [PATCH v2] mtd: nand: raw: atmel: Add message on DMA usage Alexander Dahl
2024-08-22 15:54 ` Nicolas Ferre [this message]
2024-08-23 17:28 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a65c4728-4cec-4fb0-a00f-052b0e08d7c1@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=ada@thorsis.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=kees@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox