From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B30C2C4332B for ; Thu, 21 Jan 2021 15:44:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 690EA2073C for ; Thu, 21 Jan 2021 15:44:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 690EA2073C Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VqIDON0rHxjriuDqJ2yoO8QVaC4ZUCPkVPSKH4tgJrQ=; b=OmnynSo3rWgeDl/SZQJ8mPmB/ 0oM6Njst/hOcMX/I4109g89bMzfcpEXIom+bRryorORow9UC0FBAoXJ8L7Rm8Zv8KZePvjs+53dvv 65NSdUxYC4H4F9AjLU1IKl7a4SVCRO2UR33ZEt80VPc8i6JLexwjpO2ZQ/BDin7+/Urb8g6RNbIi+ 8ZL0hWT2D2AJYXa2q6y2o/tNiOYXd78SeVwo7pP7ca8juj9SENR3j8YcxEXyl/vHbT26sJpu+VnRw Rqp7L5Mvy4D165F1g1RcWyRRzOm3z/+SnzIAMIGdamwXWX59ESU6EJdYDjP962gW4WjzyuIMuShuY YvqdnVG0A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2c75-0000z3-R5; Thu, 21 Jan 2021 15:43:11 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2c73-0000yD-Hl for linux-arm-kernel@lists.infradead.org; Thu, 21 Jan 2021 15:43:10 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 10LFh79f122908; Thu, 21 Jan 2021 09:43:07 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1611243787; bh=WrQobewGlIn8sKRqx821bIVl+itKgFtAGXEKeSHFnuU=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=pHA0oum/m2nel8TT8M6R8PE9xtfLTUHWw+KGQt+cHzILxOy0cczgy7hEbSlgTuKbK 3lCh4NbPDBW6m1Bjn47XujKq+4lcMqNMj6Pp0c0SsMNlYEryCxLNXhCTA3yMoKGNCk wKIzGu6QsfQowW/QhfJtAjkBbjT0M9ROvRYIyGy0= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 10LFh7fq023360 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 21 Jan 2021 09:43:07 -0600 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 21 Jan 2021 09:43:07 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 21 Jan 2021 09:43:07 -0600 Received: from [10.250.35.71] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 10LFh6wd002050; Thu, 21 Jan 2021 09:43:06 -0600 Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am65-main: Add ICSSG nodes To: Nishanth Menon References: <20210114194805.8231-1-s-anna@ti.com> <20210114194805.8231-2-s-anna@ti.com> <20210121153757.kuknwzrzc3xmnase@machine> From: Suman Anna Message-ID: Date: Thu, 21 Jan 2021 09:43:06 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210121153757.kuknwzrzc3xmnase@machine> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210121_104309_675447_193FFA47 X-CRM114-Status: GOOD ( 13.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Grzegorz Jaszczyk , Vignesh Raghavendra , Tero Kristo , Lokesh Vutla , Jan Kiszka , Roger Quadros , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/21/21 9:37 AM, Nishanth Menon wrote: > On 13:48-20210114, Suman Anna wrote: > [...] > >> + >> + icssg1_intc: interrupt-controller@20000 { >> + compatible = "ti,icssg-intc"; >> + reg = <0x20000 0x2000>; >> + interrupt-controller; >> + #interrupt-cells = <3>; >> + interrupts = , >> + , >> + , >> + , >> + , >> + , >> + , >> + ; >> + interrupt-names = "host_intr0", "host_intr1", >> + "host_intr2", "host_intr3", >> + "host_intr4", "host_intr5", >> + "host_intr6", "host_intr7"; > > > Could you look at https://pastebin.ubuntu.com/p/rbZrv3sDFk/ > Yes, I am aware of these, and I have already noted it in my cover-letter. "Note that the interrupt nodes will generate a warning about missing '#address-cells' when compiled using W=2, but adding that currently fails the dtbs_check, so going with the dt binding compliance." I have submitted two incremental patches, one against the binding [1] and another against dts [2]. regards Suman [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210115205819.19426-1-s-anna@ti.com/ [2] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210115210625.20427-1-s-anna@ti.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel