From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F83FC7EE25 for ; Thu, 8 Jun 2023 04:03:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AuNsDuCwnjgHmdwMkR5B2vYXCtQcjCfo1XtP4dgd9to=; b=OrMNV73SI/bq5P aetTvg5bFrPbMPCQXfjAIq6HOLOdBKXq51Ohy17v4jjUH22YHPVFWTE6LgDcCUMxWUGuyzs6xtOv2 +43fkt5zHsucy2LT9YBShkhVrY1P9B+pV59EyJHw1A5NXP74PohpxE7HafzSGhivQwVWxxQ753y5x wTVj0K5+9vdIV3/GmrrpQgM/UnxsTffrL2+UFBsE5VD1floIQGHPFIcTNnJ9rwPpEIrhSYCNME2Wh GborVFDXIfZfoUgVsqaAYhWuVkaMRFGrQ4fdAP6k12FemdAASHFkyeXzK82JEgTXIN4Jem6c3+wQ4 1H4Y4p1jfsteorixI3+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q76rS-007ztX-2m; Thu, 08 Jun 2023 04:02:58 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q76rQ-007zrU-0e; Thu, 08 Jun 2023 04:02:57 +0000 X-UUID: 537fafcc05b111ee912e1518a6540028-20230607 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=yC6Kz3dRax/xXlR6dKczcSVQTuZUEay65JNQl9bu3hk=; b=pM5hyf8Pl9n6ZXMYvrYAxfojC+z/TYQP+DduViB1pN2QDpwBHHirEIuAAqXz53wiMor+y/SW6rVm9srcrGpyvY3WCH+OvvkufQNq8Z5BzfsZ74kFguXJjcG8ojI++78CL8DMRqoAOox+Gtm2zGerA9ZJPXTIJ16RAR+ZnVOl1Aw=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.26,REQID:793e8ba9-e385-4515-92e0-9b6b0f26743d,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:45 X-CID-INFO: VERSION:1.1.26,REQID:793e8ba9-e385-4515-92e0-9b6b0f26743d,IP:0,URL :0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,BULK:0,RULE:Release_Ham,ACTION:r elease,TS:45 X-CID-META: VersionHash:cb9a4e1,CLOUDID:e228f13d-7aa7-41f3-a6bd-0433bee822f3,B ulkID:2306081202473F9DX6TE,BulkQuantity:0,Recheck:0,SF:28|17|19|48|38|29|1 02,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,C OL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SDM,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_SNR X-UUID: 537fafcc05b111ee912e1518a6540028-20230607 Received: from mtkmbs13n1.mediatek.inc [(172.21.101.193)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1588749411; Wed, 07 Jun 2023 21:02:46 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs13n2.mediatek.inc (172.21.101.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 8 Jun 2023 12:02:10 +0800 Received: from APC01-SG2-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Thu, 8 Jun 2023 12:02:10 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g6kYPL9L44bUvsxlE94yHeMbragbRG+nUEx0bmJ+O2ORM1A4nHJZH+qxCr2iPlmqrkDvuDpnriGUh6kC+IFgjHmPSAv2XHBJ8Mq28/GjjrxO3kAXXMJtK7vhLbHWMCg9zd6ceBuBJe5C9tufbfD+fI095eUXyn9+CH5usRbVwdi12mS8cJ/JNSB0+Ur26yDH/wvnyknhVpCipH58xLuJMrZ+exfnwAQfg9NiMSV3O7Z+Jj8r+K21yq2rFnFE5yeVqnyylLfRIiCjTsTxDVFc0MeFfhlZSUjxr4BxGYzWlKfyeKavqiuda3lnvNyHjYa+dZvkdhmRNhZmSMvlSg19oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yC6Kz3dRax/xXlR6dKczcSVQTuZUEay65JNQl9bu3hk=; b=gZVw7LNAPCdXW0rqKdn14d1Z760K9VUIF5r9BlXWZnMxG/TgkQqOLnL2+IitNVQi7QCNKf/tKsBNRmr4IYgNuRyp0OuoCwYc3yNsk5OrmmpkGYPmQjMAWOZtnsLfOjOjkcC66ll/7/lHKHB2uXhj9ye1n/oaLRICuf5/MgPGgLg0P8sl0QimqvFx0hAn5aPDbqs88+6feoKqWnbJVHahQUmCytE/YkGP5aqsKob2wyCID4PUAHBbjyMtoNFM2W8uxiF3BiimVZB0wHfXGXqszb5G8CFhGPVP+FDcLLvgJPnziCRN/L82GpU8oCWrXjzgnsEahz1xGf3ZqON1tV66LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yC6Kz3dRax/xXlR6dKczcSVQTuZUEay65JNQl9bu3hk=; b=RBVPzF3CDNhTV1T9sIs/ew6CnuVpFPxl8fJDqAOh5nAeEzCbezc7zJ7dd2SLJN0tC03W4y2t6HYx9hlBYdGHc6dmwmsWGsrm6j64rnELzY+trJNw+FObiYc93TvUS/AiFwE07oz51pDAiv3AnSgUlBkE3wuX2j0Ks3oJjVHysw4= Received: from SI2PR03MB6686.apcprd03.prod.outlook.com (2603:1096:4:1e9::14) by SEZPR03MB6850.apcprd03.prod.outlook.com (2603:1096:101:95::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.19; Thu, 8 Jun 2023 04:02:07 +0000 Received: from SI2PR03MB6686.apcprd03.prod.outlook.com ([fe80::bfa:5a41:b6e1:63de]) by SI2PR03MB6686.apcprd03.prod.outlook.com ([fe80::bfa:5a41:b6e1:63de%3]) with mapi id 15.20.6455.030; Thu, 8 Jun 2023 04:02:07 +0000 From: =?utf-8?B?VHJldm9yIFd1ICjlkLPmlofoia8p?= To: "lgirdwood@gmail.com" , "dan.carpenter@linaro.org" CC: "kernel-janitors@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "broonie@kernel.org" , "tiwai@suse.com" , "amergnat@baylibre.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "perex@perex.cz" , "alsa-devel@alsa-project.org" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH v2] SoC: mediatek: mt8188-mt6359: clean up a return in codec_init Thread-Topic: [PATCH v2] SoC: mediatek: mt8188-mt6359: clean up a return in codec_init Thread-Index: AQHZmVCY6n4N7oFOFkCvi6A+hdppeK+ASVkA Date: Thu, 8 Jun 2023 04:02:07 +0000 Message-ID: References: <42f2a995-3545-40bf-82a0-fd9b8abc16ce@moroto.mountain> In-Reply-To: <42f2a995-3545-40bf-82a0-fd9b8abc16ce@moroto.mountain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SI2PR03MB6686:EE_|SEZPR03MB6850:EE_ x-ms-office365-filtering-correlation-id: cef2fbc4-7e9f-42f3-e1d0-08db67d5209d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: biHZRCW0iVyyp2K+egGxZBPimsTwEv0D9xJrHN07nQkc3KCHqXJTBhHpKZPISMCv/w0dF3CYolJgySzHmtTHqpaLYVXQYlBXChCWFLfZn1NxLEb6+6nH3D1YmaPUN7H6gf329Rj/dG04lnoeIw2W3e7lCf1Fci5sz59GA84FGJK49e10ShdQCz+q19R6qrT0SMPU5oOJqbr/stJ6IicGLQLxr2p1U61OL/7ajGNMPlCxlBl0QyDoss0pcpkW641a34EZgH5UCsB5KtIFBhGbFyY/b3jiZIxDcYuWqfs3kRLCoSan1U4+d4IOX/ufyuibIU++fDYwRiKeWy6Kylyw7S63Yd5CjrsGrD3m+hKFkVLIdUVNUxfkKrgVfRQsQK8x5FZ18+RVBIVdKOCsGs7hWN2YGxlKeJhwAD/0BtIGHurPbE9LfIxfVVCfjzLGZW7QK8tH/iSYIz0FmH9W4R0DHls+tKyr5tzYfY/QuY0UKVPJsTYNO0WpsdkzHcNBKFLyvSUdP0UAfCL0rrudMob3zxwxVpVR8mouSVSR4ZnSTU7Lf0t3D9Kz6ncf+Bi+pkjeFB0dQpQJMigO1SXk0dzos5luybhAbSr81xXudzyYFGYNkn/Vn0SWIKwsb4worSL20plU76JWNhv2AUtN7hOSvMZdStcKcZdPLm+fSb5dM6Py58HzIxheYooc3CN8xJoK x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SI2PR03MB6686.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(346002)(136003)(39860400002)(366004)(451199021)(2906002)(5660300002)(7416002)(38100700002)(122000001)(186003)(38070700005)(6506007)(26005)(2616005)(83380400001)(6512007)(54906003)(110136005)(478600001)(71200400001)(86362001)(6486002)(85182001)(36756003)(66946007)(66556008)(91956017)(76116006)(8676002)(4326008)(66476007)(66446008)(41300700001)(64756008)(8936002)(316002)(99106002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WmE5OWphS2o1TXc2V3ZseW1VY0ZZanN6NGk3M2psanhEY3UzWWl5Q3oxKzRs?= =?utf-8?B?TmdtaUJxaTgreUdsVytlV3QrZjFzYXpFcTVabHZPQm5WV0VPbjlWYVF4N2U4?= =?utf-8?B?bEV2TzFVVUxQbDRNaFBlb28yTnRyckMyRWhndVA1YWRmbFAzVDMyZGVhNHZK?= =?utf-8?B?R3FBNTF3WThHM2RhRDRwckcxc3hOUjFYWXM4MzYrWnlkamUrNXR0Qmt4Nk1w?= =?utf-8?B?QURoQ1Nsa2Zmc1RhRlFBc3YrVXU0U2NRaXpyUDBhb3I4QjBUUmVwK3NBczZY?= =?utf-8?B?eEx0R09ERDVhS3Jjb2l0a2c4SjhYR3BOZlBSZndlNW5tc2x0amFwQ0IrK1FJ?= =?utf-8?B?bVpWOGVmM1ZKdlZLOGZYWS9JNXJLdFF2bmhtSTNsT2JtaC9zTGRDbElQT1Fo?= =?utf-8?B?V3gvL2dCUGcxR1RTd0sydzVKUk1jVEFRMy92ZTV3cE82NHh6Z1FEeWJiUGli?= =?utf-8?B?SlQrYndMQ3VHMGovYTdxemJqaVNhVDZGSzliQlhHWGZjNkZaK0dBZThSdHEv?= =?utf-8?B?Z1hOV1NUWHFGM2V5WHVYbWZNSFJtUm0wVDBXcW5DZDNiZlFmcUNHaGRIenZB?= =?utf-8?B?cTFGZXZ2SWFUWDIyMi9JWUR1K2QyaU1kUmdyVW9wUFdITTBLZ2Y2Y1FaMkds?= =?utf-8?B?VUdwZWZ4UjZ3T2ovQk0xZUQrL3NMdU5BbUtOV1E4Q2JEQXdiaEdxZEJyWG5Z?= =?utf-8?B?T1kvNWNCbHg2VThLMGZPNXNZc1JCTzlXejhGRjdpa3g3TnR1V0JPZkdtRmlO?= =?utf-8?B?aGVjaU54OG9qZXQ4N3I4SjJKN1B3OXJJMDhFeUM5dWN4ZnhmY3pFTFl3SFFl?= =?utf-8?B?V3ZGKzFxOUpsT2RmVmhLQ2U3bm5vUEtuQmVPU05EVjhYdGU5cnBtOUVsdGhv?= =?utf-8?B?SUt3cnI1Tk1yRnB1bFF6Q0NBMFNRZTdncWt6QWFGa0VTSGM3OEgxUDlYUVdR?= =?utf-8?B?WVRVVDNkUXhQazdQVWUzU3VKaXBVWWdWQ0pPZVdDZnY1cUtqYStvQzV0OTVm?= =?utf-8?B?bjdYL0hHbmpQQThlY0VFL0xhTEJ2Z1djN2ZpWVljM3liem82LzRlOCt0bVVQ?= =?utf-8?B?R3RoSUZPS0MvWWlWZEwzT21CSHNROFdWdU4waG5RQkFYWkJmREU0RmN1K3c0?= =?utf-8?B?TTNBd0U0bkdSWTliaGYrWURnajFHZUxIcmZ3UnkyY1JIdEtwcHA1WnBVWElC?= =?utf-8?B?dHpTRFJoN1dtdzd6N285MFhROHF5VitVanplNzIrQUVwVk5pZjlsNjBma3oy?= =?utf-8?B?dzRJRm1FekxKandSZnRLTHBRVjRJd1FPU3dxbkprWFNZa1dCL0dxTzdwZXBD?= =?utf-8?B?OS9YMzdDbDZIQWVzc3VnakQzWDNBL2IwUlE5ZCtCN3haNEwxZCtmZGthYVVT?= =?utf-8?B?L3BjRnFHdnlPY0h6ekhZeXU0ZjFrWkdDelBRYXhVR1ZCL08zbUtHU1VVVXc1?= =?utf-8?B?QzBWeWtGVlkweWc1WGJRc1NVVjlTWTdrQXBXTkh3TjdPMFhZdWVmVkcvSlp5?= =?utf-8?B?MUZiaHc4VnprN3dyT3hDK1dCRVFsQ1JLQU5KbUVTdXdSazc1NlgybHBDeUJ1?= =?utf-8?B?RWxyNUxlWU85SnFRdEJpNUJ2aVVBUXhDdHRWQ21DTG9pTStPeHgxODlkZXR4?= =?utf-8?B?V2tnRUd4UE1GTG5WZFRnMVUrMWZsdlRpK0VzRllkM0MzTkJSaXE2cTZOWTlZ?= =?utf-8?B?ditybkJMcWdCNHB0aFZvVTl2bTAvRlZDbUNiN3c4TlU0a2xjUzVESHpZaWtX?= =?utf-8?B?cGFic1I2MDFhVXVaaUpyQUtLVEVBNy9nVDc5c1ZVd08zVSs2bHZQcU9xUVJ6?= =?utf-8?B?WTVDZndiVCt3c2VtNUdGTmNyRTQrSkllS0x5NG0yVTRRSWhkZS9GYzkxK0Nx?= =?utf-8?B?S0NEMWErKzZQeWRLWUJGa0k4N2xHWXloMlVDdmVtV1JBOVpKR2ZEUnAwTU9h?= =?utf-8?B?OU5aQnhVRXUwcXdOYTJvREtQaU1JY2FldVM0RlpXUk9NSDdTcmhQdnJCODVD?= =?utf-8?B?SEZ1YnRLRFNOejhNUmp3T2hseWdDOXptQ2kyKzZZMFhIa0MrTWZkdTdTbHpS?= =?utf-8?B?OVNNdjVtSENObkM0NXZ6aVdSdHh3c1NKa3AwQU9OZzJWMjdTNWkrMXNYMzNt?= =?utf-8?B?LytxaUVuQlBKQjl1RE5sdVhZdk9UQnV0OWcwU1JkWk1TVXJ1Zi9kb3hwTGc2?= =?utf-8?B?bWc9PQ==?= Content-ID: <497CFB3B1918DC4B959282E9CFC5EFD1@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SI2PR03MB6686.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cef2fbc4-7e9f-42f3-e1d0-08db67d5209d X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2023 04:02:07.5947 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sm+6LDMzAfKrYj+q3BSSo88dJ98nbWKhRNxf5TB58N4kIw9NLLkqJwU8ak8sTxslzgklgyftrA/j6EGYKWcKjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR03MB6850 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230607_210256_253064_10F864F2 X-CRM114-Status: GOOD ( 19.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2023-06-07 at 17:57 +0300, Dan Carpenter wrote: > This code triggers a Smatch static checker warning and does sort of > look like an error path. > > sound/soc/mediatek/mt8188/mt8188-mt6359.c:597 > mt8188_max98390_codec_init() warn: missing error code? 'ret' > > However, returning 0 is intentional. Make that explicit. Hi Dan, There are several similar instances in this file. If using 'return ret;' is not recommended, should we update all of them simultaneously? For instance, the value of 'ret' at the end of this function should also be zero. Thanks, Trevor > > Signed-off-by: Dan Carpenter > --- > v2: At first I thought this was an error path but it is a not. > > sound/soc/mediatek/mt8188/mt8188-mt6359.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/mediatek/mt8188/mt8188-mt6359.c > b/sound/soc/mediatek/mt8188/mt8188-mt6359.c > index bc4b74970a46..5ad8d2a5bbc4 100644 > --- a/sound/soc/mediatek/mt8188/mt8188-mt6359.c > +++ b/sound/soc/mediatek/mt8188/mt8188-mt6359.c > @@ -594,7 +594,7 @@ static int mt8188_max98390_codec_init(struct > snd_soc_pcm_runtime *rtd) > } > > if (rtd->dai_link->num_codecs <= 2) > -return ret; > +return 0; > > /* add widgets/controls/dapm for rear speakers */ > ret = snd_soc_dapm_new_controls(&card->dapm, > mt8188_rear_spk_widgets, > -- > 2.39.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel