From: Joe Perches <joe@perches.com>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Peter Chen <peter.chen@nxp.com>,
linux-usb@vger.kernel.org, Alim Akhtar <alim.akhtar@samsung.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Binghui Wang <wangbinghui@hisilicon.com>,
Yu Chen <chenyu56@huawei.com>,
linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-msm@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
Seungwon Jeon <essuuj@gmail.com>
Subject: Re: [PATCH 0/8] drivers: phy: Constify static phy_ops structs
Date: Sun, 23 Aug 2020 15:07:39 -0700 [thread overview]
Message-ID: <a6763ea3eba3cbcf27ffd4584d4daf9cc1759d35.camel@perches.com> (raw)
In-Reply-To: <20200823220025.17588-1-rikard.falkeborn@gmail.com>
On Mon, 2020-08-24 at 00:00 +0200, Rikard Falkeborn wrote:
> This series constifies all static phy_ops structs in drivers/phy.
> Typically the only usage is to pass the address of it to devm_phy_create()
> which takes a const pointer. The lone exception is in
> drivers/phy/qualcomm/phy-qcom-ipq4019-usb.c where the address of the
> structs is assigned to the data-field in of_device_id, which is a const
> void pointer.
>
> Making the structs const allows the compiler to put them in read-only
> memory.
>
> The patches are all independent of each other, and have been
> compile-tested only.
Perhaps add phy_ops to scripts/const_structs.checkpatch too
---
scripts/const_structs.checkpatch | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/const_structs.checkpatch b/scripts/const_structs.checkpatch
index e9df9cc28a85..cd45cb3c2b04 100644
--- a/scripts/const_structs.checkpatch
+++ b/scripts/const_structs.checkpatch
@@ -39,6 +39,7 @@ nlmsvc_binding
nvkm_device_chip
of_device_id
pci_raw_ops
+phy_ops
pipe_buf_operations
platform_hibernation_ops
platform_suspend_ops
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-23 22:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 22:00 [PATCH 0/8] drivers: phy: Constify static phy_ops structs Rikard Falkeborn
2020-08-23 22:00 ` [PATCH 2/8] phy: fsl-imx8mq-usb: Constify imx8mq_usb_phy_ops Rikard Falkeborn
2020-08-23 22:07 ` Joe Perches [this message]
2020-08-31 9:06 ` [PATCH 0/8] drivers: phy: Constify static phy_ops structs Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6763ea3eba3cbcf27ffd4584d4daf9cc1759d35.camel@perches.com \
--to=joe@perches.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=chenyu56@huawei.com \
--cc=essuuj@gmail.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=peter.chen@nxp.com \
--cc=rikard.falkeborn@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
--cc=wangbinghui@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox