From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DEFCC433DF for ; Fri, 10 Jul 2020 08:36:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 623F22078D for ; Fri, 10 Jul 2020 08:36:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QV+dmwnr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 623F22078D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AAZdzQkuHynU2xI6/Oo309wE3eolhH6JA4xL+qAjA28=; b=QV+dmwnr9OzCibwoBf9VCMyB4 w4smciM8vIR9ydEy9zd81RLmFBOtA+owOM0SWvuqF2ZB+F/kclpy9FYCSe5ejNhiddoUm4i7BFRmh wCVcSoQKZQv4UiSWhNzLUWHI5O4n9068GUPV4DaTDaakvenyCtZ2UBkADeSioEpBvkonlttvGB1ca M7bJU78enbZDMFBIqPRCtbI1Jj5VWgtsOPsN4wzcRtGsegxWaqtW7QYR7Idij+Ad9/4Jgr13y5zGa t5w7f5FVqCm438+gDL7b0Wtzi1UEmkGMVKc5P/Mk/Y9BHB2ZFjWZxt/QdGXxRj8obpArxAJPi6N4O WoJuSUuEg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtoUi-000464-5m; Fri, 10 Jul 2020 08:34:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtoUe-00044h-TI for linux-arm-kernel@lists.infradead.org; Fri, 10 Jul 2020 08:34:53 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F0CDB31B; Fri, 10 Jul 2020 01:34:49 -0700 (PDT) Received: from [10.37.12.58] (unknown [10.37.12.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DA9263F9AB; Fri, 10 Jul 2020 01:34:46 -0700 (PDT) Subject: Re: [PATCH 1/2] memory: samsung: exynos5422-dmc: Adjust polling interval and uptreshold To: Chanwoo Choi , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20200708153420.29484-1-lukasz.luba@arm.com> <20200708153420.29484-2-lukasz.luba@arm.com> From: Lukasz Luba Message-ID: Date: Fri, 10 Jul 2020 09:34:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200710_043453_006453_81EBC8C0 X-CRM114-Status: GOOD ( 20.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: willy.mh.wolff.ml@gmail.com, s.nawrocki@samsung.com, b.zolnierkie@samsung.com, k.konieczny@samsung.com, krzk@kernel.org, kyungmin.park@samsung.com, myungjoo.ham@samsung.com, kgene@kernel.org, chanwoo@kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Chanwoo, On 7/9/20 5:08 AM, Chanwoo Choi wrote: > Hi Lukasz, > > On 7/9/20 12:34 AM, Lukasz Luba wrote: >> In order to react faster and make better decisions under some workloads, >> benchmarking the memory subsystem behavior, adjust the polling interval >> and upthreshold value used by the simple_ondemand governor. >> >> Reported-by: Willy Wolff >> Signed-off-by: Lukasz Luba >> --- >> drivers/memory/samsung/exynos5422-dmc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c >> index 93e9c2429c0d..e03ee35f0ab5 100644 >> --- a/drivers/memory/samsung/exynos5422-dmc.c >> +++ b/drivers/memory/samsung/exynos5422-dmc.c >> @@ -1466,10 +1466,10 @@ static int exynos5_dmc_probe(struct platform_device *pdev) >> * Setup default thresholds for the devfreq governor. >> * The values are chosen based on experiments. >> */ >> - dmc->gov_data.upthreshold = 30; >> + dmc->gov_data.upthreshold = 10; >> dmc->gov_data.downdifferential = 5; >> >> - exynos5_dmc_df_profile.polling_ms = 500; >> + exynos5_dmc_df_profile.polling_ms = 100; >> } >> >> >> > > Reviewed-by: Chanwoo Choi > Thank you for the review. Do you think this patch could go through your tree together with your patches? I don't know Krzysztof's opinion about the patch 2/2, but I would expect, assuming the patch itself is correct, he would like to take it into his next/dt branch. Regards, Lukasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel