From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F802C54EEB for ; Sun, 22 Mar 2020 19:36:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5D2D2072E for ; Sun, 22 Mar 2020 19:36:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Tzt5EmWF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="kAXEx17a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5D2D2072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Kq2QOHw9nNvm5JbohDTClhuXYxT1Fy46GSlb4LeNkto=; b=Tzt5EmWF41lDnnvC1FGqFBxiQ DtESRjjrCHNZpWukjOZIH2mwO2prbRBbqdnKulJPw2P91I69zlClpTdDzllFcOEvsmlwzlnPj+It3 dsYNRY9BTyEMhv5OCL7dLSS8NmtMiVq/uq6rBOY70+E7wdbTK8jRz1xxs4egWkQ59Wo3WTsSZgXUq AP8E/3Csq3wWe8Fx0X/OyxJ5aS4IJwGYHf45SmM7XByZsVQSwE5O1E+UweBVWCbhH37SloXgGvQk9 pm6u5PIZJApX0YlWMFuwtycQppX/p3NVBxzL9mYYd8cqOO98ofqs5uiZL4lZ30FzbmXDMwdm/qg3s z9i8+W+vw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jG6OA-0007l2-GT; Sun, 22 Mar 2020 19:36:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jG6O7-0007hG-IW for linux-arm-kernel@lists.infradead.org; Sun, 22 Mar 2020 19:36:00 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB6172070A; Sun, 22 Mar 2020 19:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584905759; bh=iL1sjTLvw1JVu+N++3CO4C0/tIF4N6blP9U1IKYS5gQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kAXEx17aS3TrizisnrRafSOkN+ibt5U0Y7672k6/Yrcv7ai6MHzcqZgalHr4qyo/W A215K6TVqFPDF3E6GPENUbZiJDMKPTfFhFXiwNllNT5vdOKjOmD9nBjxHQmuWx7aLI wpzmhLnSjrqktPegHm6AwDxvzGfDny/5xovTe7Yk= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jG6O5-00Eknk-0F; Sun, 22 Mar 2020 19:35:57 +0000 MIME-Version: 1.0 Date: Sun, 22 Mar 2020 19:35:56 +0000 From: Marc Zyngier To: Daniel Baluta Subject: Re: [PATCH] irqchip: irq-imx-gpcv2: Remove unnecessary blank lines In-Reply-To: References: <1584421001-2647-1-git-send-email-Anson.Huang@nxp.com> <86mu89zqce.wl-maz@kernel.org> Message-ID: X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.10 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: daniel.baluta@gmail.com, Anson.Huang@nxp.com, tglx@linutronix.de, jason@lakedaemon.net, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linux-imx@nxp.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200322_123559_655823_5A29EFFC X-CRM114-Status: GOOD ( 19.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jason@lakedaemon.net, Anson Huang , Fabio Estevam , Sascha Hauer , Linux Kernel Mailing List , dl-linux-imx , Pengutronix Kernel Team , tglx@linutronix.de, Shawn Guo , linux-arm-kernel Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Daniel, On 2020-03-22 19:08, Daniel Baluta wrote: > On Sat, Mar 21, 2020 at 5:22 PM Marc Zyngier wrote: >> >> On Tue, 17 Mar 2020 04:56:41 +0000, >> Anson Huang wrote: >> > >> > Remove unnecessary blank lines for cleanup. >> > >> > Signed-off-by: Anson Huang >> > --- >> > drivers/irqchip/irq-imx-gpcv2.c | 2 -- >> > 1 file changed, 2 deletions(-) >> > >> > diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c >> > index 4f74c15..4f11b9b 100644 >> > --- a/drivers/irqchip/irq-imx-gpcv2.c >> > +++ b/drivers/irqchip/irq-imx-gpcv2.c >> > @@ -17,7 +17,6 @@ >> > #define GPC_IMR1_CORE2 0x1c0 >> > #define GPC_IMR1_CORE3 0x1d0 >> > >> > - >> > struct gpcv2_irqchip_data { >> > struct raw_spinlock rlock; >> > void __iomem *gpc_base; >> > @@ -287,6 +286,5 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node, >> > of_node_clear_flag(node, OF_POPULATED); >> > return 0; >> > } >> > - >> > IRQCHIP_DECLARE(imx_gpcv2_imx7d, "fsl,imx7d-gpc", imx_gpcv2_irqchip_init); >> > IRQCHIP_DECLARE(imx_gpcv2_imx8mq, "fsl,imx8mq-gpc", imx_gpcv2_irqchip_init); >> >> I honestly don't think this deserves a patch. Next time you work on >> this driver, add the cleanups to it. But on its own, it's only churn. > > While you are technically right, it's only churn I think we need this > for code consistency and cleanup. Get real. We really don't. Two blank lines do not lead to a misinterpretation of the code, do not get in the way of normal maintenance, do not lead to *any* practical issue. What's next? Cc stable? > Even if we fix this when we work on the driver we still need > to make the cleanup in a separate patch. Neither. As well as removing blank lines, you could also remove the dead code in this driver. That would be a good cleanup. You could also have a look at what feels like a potential deadlock in the mask/unmask callbacks. That'd be a good thing to do too. Certainly more useful than just dropping two blank lines. M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel