From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C553FC43334 for ; Wed, 20 Jul 2022 09:42:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e13Rk+rDgosTYwGazR8lkWwKe78sMb5hQxh07Awi1YQ=; b=S3ddOHrOlwo15L MHRutSiSeY/zX9srZzGb6Tw1i+HR1okDjCyrw/PMXD27P21o80YuX6J6AKQf/uG6uUeIdOC/offUm 61Cm0n/VhKvJs9Px2lVZ72seZCSjdDqVhXvpm33hjkVKWS5MxY/w4dSoz/5AQaMkNXXtPcCuYHLhy xfNxsafcOhviMsfTdbt6gRaJxaQXc+te3oJFce+kSbUfBf/hUHR7VQDJB7HIgsmz/TvQdS5x5fHpL 6i5OzkkPF3A88FYv8XsVyVLbOV9raia82KFs4MGHiQnUG2Of50bXJUZUpwENcOLkqRElOAbdBxHxS AgPAHWHWahcORFHXp2vA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oE6Cc-003QGl-Dl; Wed, 20 Jul 2022 09:41:10 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oE6CY-003QEx-TA for linux-arm-kernel@lists.infradead.org; Wed, 20 Jul 2022 09:41:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D992E1576; Wed, 20 Jul 2022 02:41:05 -0700 (PDT) Received: from [10.57.41.17] (unknown [10.57.41.17]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A7E7E3F73D; Wed, 20 Jul 2022 02:41:03 -0700 (PDT) Message-ID: Date: Wed, 20 Jul 2022 10:41:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 13/13] coresight: trace-id: Add debug & test macros to Trace ID allocation To: Mike Leach , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: mathieu.poirier@linaro.org, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, linux-perf-users@vger.kernel.org, leo.yan@linaro.org, quic_jinlmao@quicinc.com References: <20220704081149.16797-1-mike.leach@linaro.org> <20220704081149.16797-14-mike.leach@linaro.org> From: Suzuki K Poulose In-Reply-To: <20220704081149.16797-14-mike.leach@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220720_024107_063884_9B2E0C4D X-CRM114-Status: GOOD ( 18.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/07/2022 09:11, Mike Leach wrote: > Adds in a number of pr_debug macros to allow the debugging and test of > the trace ID allocation system. > > Signed-off-by: Mike Leach > --- > .../hwtracing/coresight/coresight-trace-id.c | 33 +++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-trace-id.c b/drivers/hwtracing/coresight/coresight-trace-id.c > index dac9c89ae00d..841307e0d899 100644 > --- a/drivers/hwtracing/coresight/coresight-trace-id.c > +++ b/drivers/hwtracing/coresight/coresight-trace-id.c > @@ -71,6 +71,27 @@ static int coresight_trace_id_find_new_id(struct coresight_trace_id_map *id_map) > return id; > } > > +/* #define TRACE_ID_DEBUG 1 */ > +#ifdef TRACE_ID_DEBUG > +static void coresight_trace_id_dump_table(struct coresight_trace_id_map *id_map, > + const char *func_name) > +{ > + /* currently 2 u64s are sufficient to hold all the ids */ > + pr_debug("%s id_map::\n", func_name); > + pr_debug("Avial= 0x%016lx%016lx\n", id_map->avail_ids[1], id_map->avail_ids[0]); > + pr_debug("Pend = 0x%016lx%016lx\n", id_map->pend_rel_ids[1], id_map->pend_rel_ids[0]); minor nit: You may use bitmap_print_to_pagebuf() to print the bitmaps. > +} > +#define DUMP_ID_MAP(map) coresight_trace_id_dump_table(map, __func__) > +#define DUMP_ID_CPU(cpu, id) pr_debug("%s called; cpu=%d, id=%d\n", __func__, cpu, id) > +#define DUMP_ID(id) pr_debug("%s called; id=%d\n", __func__, id) > +#define PERF_SESSION(n) pr_debug("%s perf count %d\n", __func__, n) > +#else > +#define DUMP_ID_MAP(map) > +#define DUMP_ID(id) > +#define DUMP_ID_CPU(cpu, id) > +#define PERF_SESSION(n) > +#endif > + > /* release all pending IDs for all current maps & clear CPU associations */ > static void coresight_trace_id_release_all_pending(void) > { > @@ -81,6 +102,7 @@ static void coresight_trace_id_release_all_pending(void) > clear_bit(bit, id_map->avail_ids); > clear_bit(bit, id_map->pend_rel_ids); > } > + DUMP_ID_MAP(id_map); > > for_each_possible_cpu(cpu) { > if (per_cpu(cpu_ids, cpu).pend_rel) { > @@ -126,6 +148,8 @@ static int coresight_trace_id_map_get_cpu_id(int cpu, struct coresight_trace_id_ > > get_cpu_id_out: > spin_unlock_irqrestore(&id_map_lock, flags); > + DUMP_ID_CPU(cpu, id); > + DUMP_ID_MAP(id_map); > return id; > } > > @@ -151,6 +175,8 @@ static void coresight_trace_id_map_put_cpu_id(int cpu, struct coresight_trace_id > > put_cpu_id_out: > spin_unlock_irqrestore(&id_map_lock, flags); > + DUMP_ID_CPU(cpu, id); > + DUMP_ID_MAP(id_map); > } > > static int coresight_trace_id_map_get_system_id(struct coresight_trace_id_map *id_map) > @@ -164,6 +190,8 @@ static int coresight_trace_id_map_get_system_id(struct coresight_trace_id_map *i > coresight_trace_id_set_inuse(id, id_map); > spin_unlock_irqrestore(&id_map_lock, flags); > > + DUMP_ID(id); > + DUMP_ID_MAP(id_map); > return id; > } > > @@ -174,6 +202,9 @@ static void coresight_trace_id_map_put_system_id(struct coresight_trace_id_map * > spin_lock_irqsave(&id_map_lock, flags); > coresight_trace_id_clear_inuse(id, id_map); > spin_unlock_irqrestore(&id_map_lock, flags); > + > + DUMP_ID(id); > + DUMP_ID_MAP(id_map); > } > > /* API functions */ > @@ -207,6 +238,7 @@ void coresight_trace_id_perf_start(void) > int n; > spin_lock_irqsave(&id_map_lock, flags); > perf_cs_etm_session_active++; n = perf_cs_etm_session_active++; > spin_unlock_irqrestore(&id_map_lock, flags); PERF_SESSION(n); Not a good idea to print something from within spin_lock. > } > EXPORT_SYMBOL_GPL(coresight_trace_id_perf_start); > @@ -217,6 +249,7 @@ void coresight_trace_id_perf_stop(void) > > spin_lock_irqsave(&id_map_lock, flags); > perf_cs_etm_session_active--; > + PERF_SESSION(perf_cs_etm_session_active); Same as above. > if (!perf_cs_etm_session_active) > coresight_trace_id_release_all_pending(); > spin_unlock_irqrestore(&id_map_lock, flags); Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel