From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C95F7C63797 for ; Tue, 17 Jan 2023 10:16:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s8wp9GSfm+GSyvI5DflvtH7ONhUMr8AXUB33pbWj1mQ=; b=wKkQA1NR7mrdXb tyT5FmTWsFsaiT0XbohOLwSf3UKNjb2Vom1md8BgCEAbpEmkPqeDvVtclb8AiSi+Nnmu1u/wIXR+I lWdtQTDsH1qFusnPlz6EH260TDlOoI8H7bPF4smGcZ7mLw3D/hzQH3iJVkx3Qfg1w8tbGeQiirOw0 g8RbU4hbg1t5YRReCcorzAfeANugVCkBzoePzClIPbyVLduExz8+47jaciF1jmA3XAs1JQQiKTk6i 7I3EFIkCaRG/+3x9bgrWUJaeE65lPRvXL/PlRhhkOJMkx8S3GmuXZQNrq9s5BF6nLr37jwA+4lsih AAaGDh8VZvYGEHSkKCRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHj0T-00DiZk-1m; Tue, 17 Jan 2023 10:15:53 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHj0P-00DiYm-18 for linux-arm-kernel@lists.infradead.org; Tue, 17 Jan 2023 10:15:50 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 041533200976; Tue, 17 Jan 2023 05:15:41 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Tue, 17 Jan 2023 05:15:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1673950541; x=1674036941; bh=XKPMNAyWjO 5bizn8aYIilfV14edG3KsI/pCa+0iqYeY=; b=RsTUlsCP5+0mD/5GnmSUTdJf99 zah1MhwXxfftnOQLzqebONzyrYjfGAhOjYGBhj7L4maM6yMoZQ5GZQeP5TVJwWc9 1Z2tRYVGWu79PaLu9tU9ucqTR432+bf/M7qFYvAd0dEHES7qIXA0DTW+hDpophXg OlMmUBufJw3RDDMPLzq4CAygIG7WL9Kej2il/YTZSL0Hn2LLQtEqDHAwqmhIChls gK0jm1FU0llZ1PnuCcqD+3TFM2xoaa8W+Bp8tKDm+7bTmlDrHes4jZSmzvJ4XldW YDqKVBU5oWlcsC26V2qL7KiaU/O81yK55YNWYVgdimTo1dTgE7GdTx/Yckuw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1673950541; x=1674036941; bh=XKPMNAyWjO5bizn8aYIilfV14edG 3KsI/pCa+0iqYeY=; b=h6BZnIehpQI/LEW8ZCQUUvp2rv01TCxOPSAfZ4Om+lcL UczDG5NsVuF9/wbBKrexYrnZsPTX4KbgPcaHWk2C9xK5gUGmdVUjfeu80xp1bESr riHSnGfxAuWzpaHmq8pww07Y+hduSK9yguVWnzXYj+l+KbBwfgjPimb/zeVyhB0l whdm0WErVDlpDQSvI35C1XO827z0HaXw4IKKF+HJr7zQIWpIYfRWztxfr+03yeIv UBLS0wjdq9B5kDwVseLF79X6QoUamkH+29Nn6+lbrIsJzrsEc41PPZMRiEEIw8gX BzM8zKo9eI52ZvLzBGpMm2dp7Ww+wIcWrOcW1N2Kyw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtiedguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 01C10B60086; Tue, 17 Jan 2023 05:15:40 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1187-g678636ba0d-fm-20230113.001-g678636ba Mime-Version: 1.0 Message-Id: In-Reply-To: <20230117100845.16708-1-nikita.shubin@maquefel.me> References: <20230117100845.16708-1-nikita.shubin@maquefel.me> Date: Tue, 17 Jan 2023 11:15:20 +0100 From: "Arnd Bergmann" To: "Nikita Shubin" , "open list:GPIO SUBSYSTEM" Cc: "Linus Walleij" , "Hartley Sweeten" , "Alexander Sverdlin" , "Russell King" , "Lukasz Majewski" , "Bartosz Golaszewski" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] gpio: ep93xx: convert driver to DT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230117_021549_557214_171F181C X-CRM114-Status: GOOD ( 13.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 17, 2023, at 11:08, Nikita Shubin wrote: > > +#ifdef CONFIG_OF > +static const struct of_device_id ep93xx_gpio_match[] = { > + { .compatible = "cirrus,ep93xx-gpio" }, > + { /* end of table */ }, > +}; > +MODULE_DEVICE_TABLE(of, ep93xx_gpio_match); > +#endif > + > static struct platform_driver ep93xx_gpio_driver = { > .driver = { > .name = "gpio-ep93xx", > + .of_match_table = ep93xx_gpio_match, > }, > .probe = ep93xx_gpio_probe, The #ifdef here is wrong and will cause a build failure because of the unconditional reference to the variable. Just remove the #ifdef/#endif. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel