From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E287CD6E43 for ; Wed, 11 Oct 2023 08:49:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O6ITz32j593HFsWCdzurQKxvpu9xjayYV7uTsTWYcEs=; b=EmIWa+mC7IRFfR LE5yRDyVctdlEaDLOjnu02a1cEya5pDrff+NzHivbQcPT1BDcTSOu5bJhj6/QYrKAXM5dk+AtcGMd 6PPPhqi1gHJcGYXWJAJgHcz+7kYLasjNoCJsF55GPqlwVtTT4fcRBqmqKdzqdzgZQrO5qIRcuAmGL I9w1V6RbK3+P2EFKiMSLfWdlXCR+cxcYQU+YxAEI7Qyo8ihH+YFSlMg4gBxnQrgYdRkZI0AgEQgVR 91KoAgrlELQ/zu0LFzft1hzdykt+8o6pd9he375QY8pLzOjuf0cphRIJsPtaA+qBBhHf26uyJbafz ivObV75YBlmRA2sGDIig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqUu7-00FGQh-0M; Wed, 11 Oct 2023 08:49:19 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqUu3-00FGPv-1a for linux-arm-kernel@lists.infradead.org; Wed, 11 Oct 2023 08:49:18 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-9b6559cbd74so1194506166b.1 for ; Wed, 11 Oct 2023 01:49:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697014151; x=1697618951; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=goU66zG1Z8ZGxlkEzc0eoZzJ+tEswmSUbrbJMfgUSLU=; b=YnhhckJwByQkjt0i2JW5bPjsxiQSY/+ciEXSjTGo8kt3w8RGv9n9ZpQauvp+FWIuoG 6cSX1Nf3qpNHUqa7l0Wihv3kTgwomaJt4ZXuNfG0LvwR2oAl3pBUFRLgFyPwzBW2Ygiz xWRdx8U+nW/LiVAPtKbv3NV1cUJEP6n/HB+l58FNV0nD6an7xZCWfB72klnw4J6lj3cx 2DfyWGhoZ2Zko5tCl/3MYSQta7kCOFByOZ68D82v5+UiY6JuZmdFRsmYRrejbmYqE7nE kux5h/BsZr0yz2vA6Hg9R1/5a3B97EOYAvJX2NqINEvB2yS5lg9vFuqo8ETNXF+Xna0n PZjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697014151; x=1697618951; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=goU66zG1Z8ZGxlkEzc0eoZzJ+tEswmSUbrbJMfgUSLU=; b=vayDMcp/DYCnM0I7F9GSsC5OXTVbdRExMMxEg25qnLj9O4Au7kdr8dAPTBQOSzMKae Wrs8iAKGV02UdmQt02+oTQNvI1avu4tNoZHUkevQTHidMk2NZD8bMYCe92EBqbjtxJIk CM0z6w7g168z9gVOtQZS2pE8NaI0FMyrf/neCDfMW0v0vCNbtuTZfm0qNh/CB9vS0TId bSZeH7KcP9LTrtp/EmzYvLIt4G0RZ1ITc13cFP3bhWaI+XvphaFvfKSkgLo+6cfVxaFc +qSrablUPQDECJGC20+KuUc2b9hoVzjmipeLZ8Wzf0gZtcO7UxzYQbm2bpYDS999cJ25 BPBg== X-Gm-Message-State: AOJu0YxjoU6uTzhlWbkum6+gAUwgDCwSs8WVycX0A/xsRqAUr4CCXmR1 qjdsrG+vk+lappR3UUHKj3+1+w== X-Google-Smtp-Source: AGHT+IExnFJCom6CH9oUPktlA1Qk1vtPOJTjoCod0Pf9vHRdBJj4j6vUQMY9Dt2O6Rng+8xy+rHUpA== X-Received: by 2002:a17:906:844a:b0:9ae:73ca:bbae with SMTP id e10-20020a170906844a00b009ae73cabbaemr15809476ejy.62.1697014151564; Wed, 11 Oct 2023 01:49:11 -0700 (PDT) Received: from [192.168.2.107] ([79.115.63.123]) by smtp.gmail.com with ESMTPSA id dc4-20020a170906c7c400b0098e34446464sm9555049ejb.25.2023.10.11.01.49.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Oct 2023 01:49:10 -0700 (PDT) Message-ID: Date: Wed, 11 Oct 2023 09:49:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/20] dt-bindings: serial: samsung: Add google-gs101-uart compatible Content-Language: en-US To: Greg KH , Peter Griffin Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, cw00.choi@samsung.com, andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org References: <20231010224928.2296997-1-peter.griffin@linaro.org> <20231010224928.2296997-9-peter.griffin@linaro.org> <2023101111-banknote-satin-1f77@gregkh> From: Tudor Ambarus In-Reply-To: <2023101111-banknote-satin-1f77@gregkh> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231011_014915_528355_2EAECC09 X-CRM114-Status: GOOD ( 15.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Greg, On 10/11/23 08:48, Greg KH wrote: > On Tue, Oct 10, 2023 at 11:49:16PM +0100, Peter Griffin wrote: >> Add dedicated google-gs101-uart compatible to the dt-schema for >> representing uart of the Google Tensor gs101 SoC. >> >> Signed-off-by: Peter Griffin >> --- >> Documentation/devicetree/bindings/serial/samsung_uart.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml >> index 8bd88d5cbb11..72471ebe5734 100644 >> --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml >> +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml >> @@ -19,11 +19,13 @@ properties: >> compatible: >> oneOf: >> - items: >> + - const: google,gs101-uart >> - const: samsung,exynosautov9-uart >> - const: samsung,exynos850-uart >> - enum: >> - apple,s5l-uart >> - axis,artpec8-uart >> + - google,gs101-uart > > These shouldn't be needed, just declare the device as the same as what We should have SoC specific compatibles so that any further quirks or incompatibilities can be easily addressed. It's not only the IP itself that can differ, it's also the integration of the IP into the final product that could have an influence on the behavior. Cheers, ta > the chip really is (i.e. a samsung uart), that way no .yaml or kernel > driver changes are needed at all. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel