* [PATCH] ARM: dts: socfpga: Fix NAND controller node compatible
@ 2018-05-10 12:52 Marek Vasut
2018-05-14 7:11 ` Steffen Trumtrar
0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2018-05-10 12:52 UTC (permalink / raw)
To: linux-arm-kernel
The compatible string for the Denali NAND controller is incorrect,
fix it by replacing it with one matching the DT bindings and the
driver.
Signed-off-by: Marek Vasut <marex@denx.de>
Fixes: d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: Dinh Nguyen <dinguyen@kernel.org>
---
arch/arm/boot/dts/socfpga.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
index 7e24dc8e82d4..d697f5062624 100644
--- a/arch/arm/boot/dts/socfpga.dtsi
+++ b/arch/arm/boot/dts/socfpga.dtsi
@@ -744,7 +744,7 @@
nand0: nand at ff900000 {
#address-cells = <0x1>;
#size-cells = <0x1>;
- compatible = "denali,denali-nand-dt";
+ compatible = "altr,socfpga-denali-nand";
reg = <0xff900000 0x100000>,
<0xffb80000 0x10000>;
reg-names = "nand_data", "denali_reg";
--
2.16.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: socfpga: Fix NAND controller node compatible
2018-05-10 12:52 [PATCH] ARM: dts: socfpga: Fix NAND controller node compatible Marek Vasut
@ 2018-05-14 7:11 ` Steffen Trumtrar
2018-05-14 15:11 ` Dinh Nguyen
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: Steffen Trumtrar @ 2018-05-14 7:11 UTC (permalink / raw)
To: linux-arm-kernel
Marek Vasut <marex@denx.de> writes:
> The compatible string for the Denali NAND controller is
> incorrect,
> fix it by replacing it with one matching the DT bindings and the
> driver.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Fixes: d837a80d19 ("ARM: dts: socfpga: add nand controller
> nodes")
> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> Cc: Dinh Nguyen <dinguyen@kernel.org>
> ---
> arch/arm/boot/dts/socfpga.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/socfpga.dtsi
> b/arch/arm/boot/dts/socfpga.dtsi
> index 7e24dc8e82d4..d697f5062624 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -744,7 +744,7 @@
> nand0: nand at ff900000 {
> #address-cells = <0x1>;
> #size-cells = <0x1>;
> - compatible = "denali,denali-nand-dt";
> + compatible = "altr,socfpga-denali-nand";
> reg = <0xff900000 0x100000>,
> <0xffb80000 0x10000>;
> reg-names = "nand_data", "denali_reg";
Ack. As the binding was changed after d837a80d19 this is obviously
correct.
@Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It
has
both compatibles, but the "denali,denali-nand-dt" seems to be
obsolete.
Thanks,
Steffen
--
Pengutronix e.K. | Steffen Trumtrar
|
Industrial Linux Solutions |
http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone:
+49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax:
+49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: socfpga: Fix NAND controller node compatible
2018-05-14 7:11 ` Steffen Trumtrar
2018-05-14 15:11 ` Dinh Nguyen
2018-05-14 15:11 ` Dinh Nguyen
@ 2018-05-14 15:11 ` Dinh Nguyen
2018-05-14 15:21 ` Dinh Nguyen
2018-05-14 15:21 ` Dinh Nguyen
4 siblings, 0 replies; 7+ messages in thread
From: Dinh Nguyen @ 2018-05-14 15:11 UTC (permalink / raw)
To: linux-arm-kernel
On 05/14/2018 02:11 AM, Steffen Trumtrar wrote:
>
> Marek Vasut <marex@denx.de> writes:
>
>> The compatible string for the Denali NAND controller is incorrect,
>> fix it by replacing it with one matching the DT bindings and the
>> driver.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Fixes: d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
>> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>> Cc: Dinh Nguyen <dinguyen@kernel.org>
>> ---
>> ?arch/arm/boot/dts/socfpga.dtsi | 2 +-
>> ?1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/socfpga.dtsi
>> b/arch/arm/boot/dts/socfpga.dtsi
>> index 7e24dc8e82d4..d697f5062624 100644
>> --- a/arch/arm/boot/dts/socfpga.dtsi
>> +++ b/arch/arm/boot/dts/socfpga.dtsi
>> @@ -744,7 +744,7 @@
>> ???????? nand0: nand at ff900000 {
>> ???????????? #address-cells = <0x1>;
>> ???????????? #size-cells = <0x1>;
>> -??????????? compatible = "denali,denali-nand-dt";
>> +??????????? compatible = "altr,socfpga-denali-nand";
>> ???????????? reg = <0xff900000 0x100000>,
>> ?????????????????? <0xffb80000 0x10000>;
>> ???????????? reg-names = "nand_data", "denali_reg";
>
> Ack. As the binding was changed after d837a80d19 this is obviously
> correct.
>
> @Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It has
> both compatibles, but the "denali,denali-nand-dt" seems to be obsolete.
>
Patch applied and cc'd stable kernel.
Will clean up arria10.
Thanks,
Dinh
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: socfpga: Fix NAND controller node compatible
2018-05-14 7:11 ` Steffen Trumtrar
@ 2018-05-14 15:11 ` Dinh Nguyen
2018-05-14 15:11 ` Dinh Nguyen
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Dinh Nguyen @ 2018-05-14 15:11 UTC (permalink / raw)
To: linux-arm-kernel
On 05/14/2018 02:11 AM, Steffen Trumtrar wrote:
>
> Marek Vasut <marex@denx.de> writes:
>
>> The compatible string for the Denali NAND controller is incorrect,
>> fix it by replacing it with one matching the DT bindings and the
>> driver.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Fixes: d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
>> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>> Cc: Dinh Nguyen <dinguyen@kernel.org>
>> ---
>> ?arch/arm/boot/dts/socfpga.dtsi | 2 +-
>> ?1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/socfpga.dtsi
>> b/arch/arm/boot/dts/socfpga.dtsi
>> index 7e24dc8e82d4..d697f5062624 100644
>> --- a/arch/arm/boot/dts/socfpga.dtsi
>> +++ b/arch/arm/boot/dts/socfpga.dtsi
>> @@ -744,7 +744,7 @@
>> ???????? nand0: nand at ff900000 {
>> ???????????? #address-cells = <0x1>;
>> ???????????? #size-cells = <0x1>;
>> -??????????? compatible = "denali,denali-nand-dt";
>> +??????????? compatible = "altr,socfpga-denali-nand";
>> ???????????? reg = <0xff900000 0x100000>,
>> ?????????????????? <0xffb80000 0x10000>;
>> ???????????? reg-names = "nand_data", "denali_reg";
>
> Ack. As the binding was changed after d837a80d19 this is obviously
> correct.
>
> @Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It has
> both compatibles, but the "denali,denali-nand-dt" seems to be obsolete.
>
Patch applied and cc'd stable kernel.
Will clean up arria10.
Thanks,
Dinh
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: socfpga: Fix NAND controller node compatible
2018-05-14 7:11 ` Steffen Trumtrar
2018-05-14 15:11 ` Dinh Nguyen
@ 2018-05-14 15:11 ` Dinh Nguyen
2018-05-14 15:11 ` Dinh Nguyen
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Dinh Nguyen @ 2018-05-14 15:11 UTC (permalink / raw)
To: linux-arm-kernel
On 05/14/2018 02:11 AM, Steffen Trumtrar wrote:
>
> Marek Vasut <marex@denx.de> writes:
>
>> The compatible string for the Denali NAND controller is incorrect,
>> fix it by replacing it with one matching the DT bindings and the
>> driver.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Fixes: d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
>> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>> Cc: Dinh Nguyen <dinguyen@kernel.org>
>> ---
>> ?arch/arm/boot/dts/socfpga.dtsi | 2 +-
>> ?1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/socfpga.dtsi
>> b/arch/arm/boot/dts/socfpga.dtsi
>> index 7e24dc8e82d4..d697f5062624 100644
>> --- a/arch/arm/boot/dts/socfpga.dtsi
>> +++ b/arch/arm/boot/dts/socfpga.dtsi
>> @@ -744,7 +744,7 @@
>> ???????? nand0: nand at ff900000 {
>> ???????????? #address-cells = <0x1>;
>> ???????????? #size-cells = <0x1>;
>> -??????????? compatible = "denali,denali-nand-dt";
>> +??????????? compatible = "altr,socfpga-denali-nand";
>> ???????????? reg = <0xff900000 0x100000>,
>> ?????????????????? <0xffb80000 0x10000>;
>> ???????????? reg-names = "nand_data", "denali_reg";
>
> Ack. As the binding was changed after d837a80d19 this is obviously
> correct.
>
> @Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It has
> both compatibles, but the "denali,denali-nand-dt" seems to be obsolete.
>
Patch applied and cc'd stable kernel.
Will clean up arria10.
Thanks,
Dinh
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: socfpga: Fix NAND controller node compatible
2018-05-14 7:11 ` Steffen Trumtrar
` (3 preceding siblings ...)
2018-05-14 15:21 ` Dinh Nguyen
@ 2018-05-14 15:21 ` Dinh Nguyen
4 siblings, 0 replies; 7+ messages in thread
From: Dinh Nguyen @ 2018-05-14 15:21 UTC (permalink / raw)
To: linux-arm-kernel
On 05/14/2018 02:11 AM, Steffen Trumtrar wrote:
>
> Marek Vasut <marex@denx.de> writes:
>
>> The compatible string for the Denali NAND controller is incorrect,
>> fix it by replacing it with one matching the DT bindings and the
>> driver.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Fixes: d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
>> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>> Cc: Dinh Nguyen <dinguyen@kernel.org>
>> ---
>> ?arch/arm/boot/dts/socfpga.dtsi | 2 +-
>> ?1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/socfpga.dtsi
>> b/arch/arm/boot/dts/socfpga.dtsi
>> index 7e24dc8e82d4..d697f5062624 100644
>> --- a/arch/arm/boot/dts/socfpga.dtsi
>> +++ b/arch/arm/boot/dts/socfpga.dtsi
>> @@ -744,7 +744,7 @@
>> ???????? nand0: nand at ff900000 {
>> ???????????? #address-cells = <0x1>;
>> ???????????? #size-cells = <0x1>;
>> -??????????? compatible = "denali,denali-nand-dt";
>> +??????????? compatible = "altr,socfpga-denali-nand";
>> ???????????? reg = <0xff900000 0x100000>,
>> ?????????????????? <0xffb80000 0x10000>;
>> ???????????? reg-names = "nand_data", "denali_reg";
>
> Ack. As the binding was changed after d837a80d19 this is obviously
> correct.
>
> @Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It has
> both compatibles, but the "denali,denali-nand-dt" seems to be obsolete.
>
Applied and cc'd stable.
Will fix up for Arria10.
Thanks
Dinh
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: socfpga: Fix NAND controller node compatible
2018-05-14 7:11 ` Steffen Trumtrar
` (2 preceding siblings ...)
2018-05-14 15:11 ` Dinh Nguyen
@ 2018-05-14 15:21 ` Dinh Nguyen
2018-05-14 15:21 ` Dinh Nguyen
4 siblings, 0 replies; 7+ messages in thread
From: Dinh Nguyen @ 2018-05-14 15:21 UTC (permalink / raw)
To: linux-arm-kernel
On 05/14/2018 02:11 AM, Steffen Trumtrar wrote:
>
> Marek Vasut <marex@denx.de> writes:
>
>> The compatible string for the Denali NAND controller is incorrect,
>> fix it by replacing it with one matching the DT bindings and the
>> driver.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Fixes: d837a80d19 ("ARM: dts: socfpga: add nand controller nodes")
>> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>> Cc: Dinh Nguyen <dinguyen@kernel.org>
>> ---
>> ?arch/arm/boot/dts/socfpga.dtsi | 2 +-
>> ?1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/socfpga.dtsi
>> b/arch/arm/boot/dts/socfpga.dtsi
>> index 7e24dc8e82d4..d697f5062624 100644
>> --- a/arch/arm/boot/dts/socfpga.dtsi
>> +++ b/arch/arm/boot/dts/socfpga.dtsi
>> @@ -744,7 +744,7 @@
>> ???????? nand0: nand at ff900000 {
>> ???????????? #address-cells = <0x1>;
>> ???????????? #size-cells = <0x1>;
>> -??????????? compatible = "denali,denali-nand-dt";
>> +??????????? compatible = "altr,socfpga-denali-nand";
>> ???????????? reg = <0xff900000 0x100000>,
>> ?????????????????? <0xffb80000 0x10000>;
>> ???????????? reg-names = "nand_data", "denali_reg";
>
> Ack. As the binding was changed after d837a80d19 this is obviously
> correct.
>
> @Dinh: Maybe you also want to cleanup the socfpga_arria10.dtsi? It has
> both compatibles, but the "denali,denali-nand-dt" seems to be obsolete.
>
Applied and cc'd stable.
Will fix up for Arria10.
Thanks
Dinh
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-05-14 15:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-10 12:52 [PATCH] ARM: dts: socfpga: Fix NAND controller node compatible Marek Vasut
2018-05-14 7:11 ` Steffen Trumtrar
2018-05-14 15:11 ` Dinh Nguyen
2018-05-14 15:11 ` Dinh Nguyen
2018-05-14 15:11 ` Dinh Nguyen
2018-05-14 15:21 ` Dinh Nguyen
2018-05-14 15:21 ` Dinh Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox