From: Florian Fainelli <f.fainelli@gmail.com>
To: "Mark Brown" <broonie@kernel.org>,
"Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: f.fainelli@gmail.com, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
p.zabel@pengutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/4] spi: bcm63xx-spi: allow building for BMIPS
Date: Tue, 16 Jun 2020 10:15:15 -0700 [thread overview]
Message-ID: <a6edd50d-db3f-8988-157c-ff66e2fd474a@gmail.com> (raw)
In-Reply-To: <20200616170724.GT4447@sirena.org.uk>
On 6/16/2020 10:07 AM, Mark Brown wrote:
> On Tue, Jun 16, 2020 at 09:02:21AM +0200, Álvaro Fernández Rojas wrote:
>> bcm63xx-spi controller is present on several BMIPS SoCs (BCM6358, BCM6362,
>> BCM6368 and BCM63268).
>
> Please do not submit new versions of already applied patches, please
> submit incremental updates to the existing code. Modifying existing
> commits creates problems for other users building on top of those
> commits so it's best practice to only change pubished git commits if
> absolutely essential.
>
In Alvaro's defense, you applied the patches despite me requesting that
specific changes be made (use the optional reset control API variant).
Having a FAQ entry about what your expectations as a subsystem
maintainer are (ala netdev-FAQ.rst) could save you time along the way.
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-16 17:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 7:02 [PATCH v3 0/4] spi: bcm63xx: add BMIPS support Álvaro Fernández Rojas
2020-06-16 7:02 ` [PATCH v3 1/4] spi: bcm63xx-spi: add reset support Álvaro Fernández Rojas
2020-06-16 17:05 ` Florian Fainelli
2020-06-16 7:02 ` [PATCH v3 2/4] spi: bcm63xx-spi: allow building for BMIPS Álvaro Fernández Rojas
2020-06-16 17:07 ` Mark Brown
2020-06-16 17:15 ` Florian Fainelli [this message]
2020-06-16 17:25 ` Mark Brown
2020-06-16 17:31 ` Florian Fainelli
2020-06-16 18:30 ` Mark Brown
2020-06-16 7:02 ` [PATCH v3 3/4] spi: bcm63xx-hsspi: add reset support Álvaro Fernández Rojas
2020-06-16 17:07 ` Florian Fainelli
2020-06-16 7:02 ` [PATCH v3 4/4] spi: bcm63xx-hsspi: allow building for BMIPS Álvaro Fernández Rojas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6edd50d-db3f-8988-157c-ff66e2fd474a@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).