From: Neil Armstrong <neil.armstrong@linaro.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Amlogic Meson SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson SoC support"
<linux-amlogic@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/6] arm64: dts: meson-g12-common: Add reference to NNA reset to pwrc
Date: Fri, 25 Nov 2022 14:00:17 +0100 [thread overview]
Message-ID: <a714a297-fa5f-4238-c6ad-bc22cbc1d14c@linaro.org> (raw)
In-Reply-To: <20221125111921.37261-5-tomeu.vizoso@collabora.com>
On 25/11/2022 12:19, Tomeu Vizoso wrote:
> Based on the power sequence in the downstream driver.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index 45947c1031c4..fa96fddf4633 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -1625,10 +1625,11 @@ pwrc: power-controller {
> <&reset RESET_VDAC>,
> <&reset RESET_VDI6>,
> <&reset RESET_VENCL>,
> - <&reset RESET_VID_LOCK>;
> + <&reset RESET_VID_LOCK>,
> + <&reset RESET_NNA>;
I think this should go in the npu node instead, those are for the VPU power domain.
> reset-names = "viu", "venc", "vcbus", "bt656",
> "rdma", "venci", "vencp", "vdac",
> - "vdi6", "vencl", "vid_lock";
> + "vdi6", "vencl", "vid_lock", "nna";
> clocks = <&clkc CLKID_VPU>,
> <&clkc CLKID_VAPB>;
> clock-names = "vpu", "vapb";
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-25 13:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 11:19 [PATCH 0/6] Support for the NPU in Vim3 Tomeu Vizoso
2022-11-25 11:19 ` [PATCH 1/6] dt-bindings: reset: meson-g12a: Add missing NNA reset Tomeu Vizoso
2022-11-25 12:54 ` Neil Armstrong
2022-11-25 11:19 ` [PATCH 2/6] dt-bindings: power: Add NNA power domain Tomeu Vizoso
2022-11-25 12:54 ` Neil Armstrong
2022-11-25 11:19 ` [PATCH 3/6] soc: amlogic: meson-pwrc: Add NNA power domain for A311D Tomeu Vizoso
2022-11-25 12:59 ` Neil Armstrong
2022-11-25 11:19 ` [PATCH 4/6] arm64: dts: meson-g12-common: Add reference to NNA reset to pwrc Tomeu Vizoso
2022-11-25 13:00 ` Neil Armstrong [this message]
2022-11-25 11:19 ` [PATCH 5/6] arm64: dts: Add DT node for the VIPNano-QI on the A311D Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a714a297-fa5f-4238-c6ad-bc22cbc1d14c@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh+dt@kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).