From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25816ECE577 for ; Sun, 8 Sep 2024 23:57:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3Eay2AcB10eOA0g7b1zM6F5JSavvwWWINu74NLyTeAA=; b=DK4G1ALjiZuh/ytwRlGdVN4/CS aJzzPPT9IGRbMaUq070d9wY94Shp3CPglux0v18IapStoKSNj5/R2DKq0wNMbUpVmQOOecySqnCb7 TwBmHIKbOaaXItyobEW89JEJtPBhAN6n46CKNJ6/cK/3wAIvwPulwOT9k7A3ddLai9bNuc9QMHIgQ GLBCTvXqNn3M991H2F+CuuP0QqExXpf21lxUBp42OWm+38GS4qtkku+0BmelBFyXik/3gxw4aCykZ DEFRMv+es1a2WQiXyk/Dkt+5nBUYKiWA0e9pUzgiCSWinnGqdO3/rclDlOKhabOKh4BL/V2N9VCpy Udv/YaIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1snRml-000000004yd-46bK; Sun, 08 Sep 2024 23:57:40 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1snRli-000000004l4-1MN4 for linux-arm-kernel@lists.infradead.org; Sun, 08 Sep 2024 23:56:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725839793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Eay2AcB10eOA0g7b1zM6F5JSavvwWWINu74NLyTeAA=; b=BJs0hktgKxAiWXWtfjRHMi7LNey9OMtST6XU0eU8d/nZr1OVBMDrTzTNS9yDxhfT62bHHe bHSt/ybJIwAQXAKYsQCEO0QJyr3VUfZXC8Z89P7i0f8Al3WEbJJAf8soyHZWNDul+YQMLL Thra1np/SGSloBPwcBr3318XTiR8Jck= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-500-wCghVJGiMuiiVHgc6dhTpQ-1; Sun, 08 Sep 2024 19:56:32 -0400 X-MC-Unique: wCghVJGiMuiiVHgc6dhTpQ-1 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-7179469744dso4157841b3a.2 for ; Sun, 08 Sep 2024 16:56:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725839791; x=1726444591; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3Eay2AcB10eOA0g7b1zM6F5JSavvwWWINu74NLyTeAA=; b=lapD5HQPyDHXqUV3X1HEBqZ7R0sPLxWOCWfY/3TD9W5stjZFmFMwOuajs521CA3/OD AjAmECZEJ77aN1aEZ1zb0EDI36HyYgRimVCpf0oKd7R3hQFOc6HljFUZ4bxM9MTjRcQV 8bh37tC7qDE4zNV/8yoemx6svEo/0BXu6oqQGUCJgXrVTDWfc9wIsorNGffJXm9kHT1o uUiiEBZRDYs/5sJlKTcdWFVkOOG5wGcEhgVyVI9M/VogpKTH7nqmD4gQsWTDi8tBYdq0 WCl2bJTu/kvzz0noBNHpZtjhr44YH2JHoM8cbv6CTfc6h4JtQSTKG9u4XIl+91SmsJS6 VqSQ== X-Forwarded-Encrypted: i=1; AJvYcCUh4awW3n6WzVb/E64m0R1HVHM2Yb/MJ09Ku9aS3lOxSfH85GcOg3PuzKv9CmK4aQtJPrWkpCl0QN8InzRKJwne@lists.infradead.org X-Gm-Message-State: AOJu0YzuPd6U5gZ01h5oxd3Dqz+LL1j2qEXgPw51d7DZuczWTOWR+KBz 4FC0ih1SL3QmWEQ9j2h+zzvv9KLMIsJBlZO+sUvYIuysjv1NXXioeRK//kMYcUXqrqgz4hgdYna OSRjjNKZcakrkaN5HO4D/5rwZmQRy0wyuK8bmvZbAgRKDjasvcULOcyM1MNrFpF182cOsRCaL X-Received: by 2002:a05:6a21:1796:b0:1cc:e3a1:b9e3 with SMTP id adf61e73a8af0-1cf2a0b0411mr6502656637.25.1725839790879; Sun, 08 Sep 2024 16:56:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHHG8rnmzacFhD7eXK/M1BWkW92PLgR0E8PqBkp5IEXjFxmE+Aw+DEcmm9s8X9PHOrtvGDYEA== X-Received: by 2002:a05:6a21:1796:b0:1cc:e3a1:b9e3 with SMTP id adf61e73a8af0-1cf2a0b0411mr6502634637.25.1725839790369; Sun, 08 Sep 2024 16:56:30 -0700 (PDT) Received: from [192.168.68.54] ([103.210.27.31]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-718e58966efsm2486357b3a.34.2024.09.08.16.56.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Sep 2024 16:56:29 -0700 (PDT) Message-ID: Date: Mon, 9 Sep 2024 09:56:21 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 05/43] arm64: RME: Add SMC definitions for calling the RMM From: Gavin Shan To: Steven Price , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Shanker Donthineni , Alper Gun References: <20240821153844.60084-1-steven.price@arm.com> <20240821153844.60084-6-steven.price@arm.com> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240908_165634_460971_01F3DFE3 X-CRM114-Status: GOOD ( 17.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/6/24 10:11 AM, Gavin Shan wrote: > On 8/22/24 1:38 AM, Steven Price wrote: >> The RMM (Realm Management Monitor) provides functionality that can be >> accessed by SMC calls from the host. >> >> The SMC definitions are based on DEN0137[1] version 1.0-rel0-rc1 >> >> [1] https://developer.arm.com/-/cdn-downloads/permalink/PDF/Architectures/DEN0137_1.0-rel0-rc1_rmm-arch_external.pdf >> >> Signed-off-by: Steven Price >> --- >> Changes since v3: >>   * Update to match RMM spec v1.0-rel0-rc1. >> Changes since v2: >>   * Fix specification link. >>   * Rename rec_entry->rec_enter to match spec. >>   * Fix size of pmu_ovf_status to match spec. >> --- >>   arch/arm64/include/asm/rmi_smc.h | 253 +++++++++++++++++++++++++++++++ >>   1 file changed, 253 insertions(+) >>   create mode 100644 arch/arm64/include/asm/rmi_smc.h >> > > [...] > >> + >> +#define RMI_FEATURE_REGISTER_0_S2SZ        GENMASK(7, 0) >> +#define RMI_FEATURE_REGISTER_0_LPA2        BIT(8) >> +#define RMI_FEATURE_REGISTER_0_SVE_EN        BIT(9) >> +#define RMI_FEATURE_REGISTER_0_SVE_VL        GENMASK(13, 10) >> +#define RMI_FEATURE_REGISTER_0_NUM_BPS        GENMASK(19, 14) >> +#define RMI_FEATURE_REGISTER_0_NUM_WPS        GENMASK(25, 20) >> +#define RMI_FEATURE_REGISTER_0_PMU_EN        BIT(26) >> +#define RMI_FEATURE_REGISTER_0_PMU_NUM_CTRS    GENMASK(31, 27) >> +#define RMI_FEATURE_REGISTER_0_HASH_SHA_256    BIT(32) >> +#define RMI_FEATURE_REGISTER_0_HASH_SHA_512    BIT(33) >> +#define RMI_FEATURE_REGISTER_0_GICV3_NUM_LRS    GENMASK(37, 34) >> +#define RMI_FEATURE_REGISTER_0_MAX_RECS_ORDER    GENMASK(41, 38) >> + > > Those definitions aren't consistent to tf-rmm at least. For example, the latest tf-rmm > has bit-28 and bit-29 for RMI_FEATURE_REGISTER_0_HASH_SHA_{256, 512}. I didn't check the > specification yet, but they need to be corrected in Linux host or tf-rmm. > >   git@github.com:TF-RMM/tf-rmm.git >   head: 258b7952640b Merge "fix(tools/clang-tidy): ignore header include check" into integration > >   [gshan@gshan tf-rmm]$ git grep RMI_FEATURE_REGISTER_0_HASH_SHA.*_SHIFT >   lib/smc/include/smc-rmi.h:#define RMI_FEATURE_REGISTER_0_HASH_SHA_256_SHIFT     UL(28) >   lib/smc/include/smc-rmi.h:#define RMI_FEATURE_REGISTER_0_HASH_SHA_512_SHIFT     UL(29) > > Due to the inconsistent definitions, I'm unable to start a guest with the following > combination: linux-host/cca-host/v4, linux-guest/cca-guest/v5, kvmtool/cca/v2. > >   # ./start_guest.sh >   Info: # lkvm run -k Image -m 256 -c 2 --name guest-152 >   [  145.894085] config_realm_hash_algo: unsupported ALGO_SHA256 by rmm_feat_reg0=0x0000000034488e30 >   KVM_CAP_RME(KVM_CAP_ARM_RME_CONFIG_REALM) hash_algo: Invalid argument > Please ignore above comments. As Steven pointed out in another thread, the TF-RMM needs to be something other than the latest upstream one. With the TF-RMM, I'm able to boot the guest with cca/host-v4 and cca/guest-v5. git fetch https://git.trustedfirmware.org/TF-RMM/tf-rmm.git \ refs/changes/85/30485/11 Thanks, Gavin