From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0F82C44508 for ; Wed, 15 Jul 2026 04:55:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0f6Hx0+X7PBcLwbcoUhv+pHzoGoMBlL/GCpeovfrjJo=; b=tbxmKwmWO3XjpBTlMU+BnwfYmp Pd9Awg3yRiZZvudWipSHIF9rmbeAyeS0XiSQliY1JprLjg9BKVJyq5ZmJlFvTOuuSnMoqkIYXQjC8 s8fUSg2VAXJd49C90S6+f/iztOK+CT2QQM16v+qBUEkwG8ScRxJhQov04L1bJY3bEA14WMFCGdaMq S6CAg3+2FsCWhUobX2xZjZ7TK9vRQeFznDYuoYs1ZBNEUXmmTJ7CZ/G3PgQZsoCWhNHFH35P0S6oF pnBil8RqUlmxs8Sh1cZqirnsuHH7E/SnsKyFU7ZAVCdYROESVL8+Hn3yAe561uzndxt8O9pI3jUPa 5D99AU0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjreu-0000000DlL8-1TJ5; Wed, 15 Jul 2026 04:55:48 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjret-0000000DlL1-0CGG for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2026 04:55:47 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 8B0A3419F6; Wed, 15 Jul 2026 04:55:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EF381F000E9; Wed, 15 Jul 2026 04:55:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784091346; bh=0f6Hx0+X7PBcLwbcoUhv+pHzoGoMBlL/GCpeovfrjJo=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=X5kU5xubfIqHSAo8lJME07VTsIJshHcWsMSV++GShIIT0aOd5L9hvmbO9TZi9/ojr JrJ2BTZIHQpvQpZGg6drp1cfNbLUTroXVOstoTfIJTY4Yw329Lc11zcI7GsMotZELM cKVosj727AN3zs8s/oUboncZ1j7XC6DhErPyg8ASj5I1vXWvMyRTXQ6EI2loucgK2S rRkE4RSsDk27gc1KfihKiAhAMx7Zm8SCtuTH3eEYgJE7UUbXaRA8VFHfs46QlilMtV DPUrGV4+M7KTmcpre04A5YEnFMW9x4gESLhCmAl5xBKT7uKY838wPn3Hi4MIzlKc32 9BQx7mTk/t+gw== Message-ID: Date: Wed, 15 Jul 2026 06:55:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 01/22] dt-bindings: memory: cdns,k3-ddr: Add Cadence K3 DDR controller binding To: MANNURU VENKATESWARLU , robh@kernel.org, conor+dt@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, n-francis@ti.com, s-k6@ti.com, bb@ti.com References: <20260714125537.3304217-1-v-mannuru@ti.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20260714125537.3304217-1-v-mannuru@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/07/2026 14:55, MANNURU VENKATESWARLU wrote: > Add device tree binding for the Cadence DDR controller used in TI K3 SoCs. > > Signed-off-by: Neha Malcom Francis > Signed-off-by: Gandhar Deshpande > Signed-off-by: MANNURU VENKATESWARLU > --- > .../memory-controllers/ti/cdns,k3-ddr.yaml | 81 +++++++++++++++++++ > 1 file changed, 81 insertions(+) > create mode 100644 Documentation/devicetree/bindings/memory-controllers/ti/cdns,k3-ddr.yaml > Where is the rest of 22 patches? I got only these three patches. A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23 > diff --git a/Documentation/devicetree/bindings/memory-controllers/ti/cdns,k3-ddr.yaml b/Documentation/devicetree/bindings/memory-controllers/ti/cdns,k3-ddr.yaml > new file mode 100644 > index 0000000000000..89caeb111627a > --- /dev/null > +++ b/Documentation/devicetree/bindings/memory-controllers/ti/cdns,k3-ddr.yaml > @@ -0,0 +1,81 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/memory-controllers/ti/cdns,k3-ddr.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cadence DDR controller for K3 devices > + > +maintainers: > + - Santhosh Kumar K > + - Neha Malcom Francis > + > +properties: > + compatible: > + const: cdns,k3-ddr cdns does not make a K3 SoC. This is confusing. Are you sure you understand which company products you are working on? > + > + reg: > + minItems: 3 Drop. > + maxItems: 3 > + description: | > + Address ranges for the different register regions of the DDRSS controller. > + - ctl_cfg: Controller configuration registers > + - ctl_cfg_pi: PHY Interface configuration registers > + - ctl_cfg_phy: PHY configuration registers Describe items. > + > + reg-names: > + items: > + - const: ctl_cfg > + - const: ctl_cfg_pi > + - const: ctl_cfg_phy > + > + bootph-pre-ram: true Nope > + > +required: > + - compatible > + - reg > + - reg-names > + > +unevaluatedProperties: false More NO. Really, can't you make some internal review back there in TI to avoid sending something which does not resemble upstream code at all? > + > +examples: > + - | > + #include > + #include > + > + cbass_main { NAK > + #address-cells = <2>; > + #size-cells = <2>; > + > + memorycontroller: memorycontroller@2980000 { git grep memorycontroller And it did not made you thinking that name is wrong? I am done with it. > + compatible = "ti,j721e-ddrss"; Irrelevant. Which binding are you describing here? Best regards, Krzysztof