Re: [PATCH 4/4] memory: brcmstb_dpfe: introduce best-effort API detection

Florian Fainelli
2023-12-06T16:25:24Z

[-- Attachment #1.1: Type: text/plain, Size: 685 bytes --]

On 12/6/2023 3:13 AM, Krzysztof Kozlowski wrote:
> On 05/12/2023 19:47, Markus Mayer wrote:
>> Add a best-effort probe function that tries all known DPFE versions to
>> see if one might actually work. This helps in cases where device tree
>> doesn't provide the proper version information for whatever reason. In
>
> So for incomplete DTS you now add elaborate, own, custom matching
> function. That's not how the code should work.

I suppose that we could drop that change and simply rely upon the Device
Tree containing an adequate compatible string. This change was added as
a transitional step for ourselves mostly. I agree this may not entirely
belong upstream.
--
Florian

[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]