Re: [PATCH 2/4] memory: brcmstb_dpfe: introduce version-specific compatible strings

Krzysztof Kozlowski
2023-12-06T11:10:27Z

On 05/12/2023 19:47, Markus Mayer wrote:
> Introduce compatible strings brcm,dpfe-cpu-v1 through brcm,dpfe-cpu-v3
> to the Broadcom DPFE driver.

No, why?

>
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> ---
> drivers/memory/brcmstb_dpfe.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c
> index a7ab3d377206..66876b409e59 100644
> --- a/drivers/memory/brcmstb_dpfe.c
> +++ b/drivers/memory/brcmstb_dpfe.c
> @@ -924,6 +924,12 @@ static const struct of_device_id brcmstb_dpfe_of_match[] = {
> { .compatible = "brcm,bcm7271-dpfe-cpu", .data = &dpfe_api_old_v2 },
> { .compatible = "brcm,bcm7278-dpfe-cpu", .data = &dpfe_api_old_v2 },
> { .compatible = "brcm,bcm7211-dpfe-cpu", .data = &dpfe_api_new_v2 },
> +
> + /* Match specific DCPU versions */
> + { .compatible = "brcm,dpfe-cpu-v1", .data = &dpfe_api_old_v2 },
> + { .compatible = "brcm,dpfe-cpu-v2", .data = &dpfe_api_new_v2 },
> + { .compatible = "brcm,dpfe-cpu-v3", .data = &dpfe_api_v3 },

Pointless change.

Best regards,
Krzysztof