From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDE57C46CA0 for ; Mon, 27 Nov 2023 11:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VbGpcVyaMRRjreTj3gvCVGznu9RiDQzvfpIEZzspdQA=; b=W4eTu1f2htCuJf utr2AM7anSgBlOU/YdlnW7K+CP0ORnjqxn0qAZRo4m3Kj0qtGVC+FChZgbcDXJaR/k2DeVNWYuyvo wH2PDzUGCtIVqMCuWHNGI6uErAV/l3fR5Otn6fxfIwu1BZrIHvX52E+wtt3IcPNPvHyr6acE5EoGw DTEI53QDdwJSWgzmX3HHEN+UG/CcLGyADIrbW7y0Jf9mkgWMWYNAKru9LgFPSOM1zRfBtvos2p5aU MrP6xYd2PDct6VF2H5vdWVcxkhQrzVafC7uOU7QLX2wJmo3MF9gq5sblXqRZAvL3gtmYH0qQYI5MK syZ5Nzkx6g0r/TOHsvng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r7Zwo-002EYS-2K; Mon, 27 Nov 2023 11:38:42 +0000 Received: from mout.gmx.net ([212.227.17.22]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r7Zwi-002EXU-2p for linux-arm-kernel@lists.infradead.org; Mon, 27 Nov 2023 11:38:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1701085104; x=1701689904; i=wahrenst@gmx.net; bh=SFIH2xcNlah3YTHeM1h2ULCAXeOmNtEhny0Q2XMb7Kk=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=tHjDDjIfaM0cX2L3Qs1V/lT7EhT84reVpLuPO5hYgnw612geui5Ds1hfEHyChnsr 8lvTYT7vxj+wwh1KVquAHwLt4nmOhJM4XoepjbmqVSDfwLZzgwlMCUf6HDugQNv4V bOfR5JEijhPdcPyT7UjB8nR8rzRcNqE3jf0ZfFVGJ5UvKw4WnhdU+yIYqfIOFG5Vi j4KrJn2nsYwliBWvDQOJ+TCHm7yF0dd4LLXfTpaZWDtQ7l4vMHvnKkPcJg7PgI7Mq IpxH3lpYOd4XOp4A4qxgIpuagqn4A8kN7bCCYTg7VMCajDDnOLP+6/FB8fjCkon0B CEW6IvHYAfM0G1LmWg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.129] ([37.4.248.43]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mz9Ux-1rURyl2mCx-00wBBy; Mon, 27 Nov 2023 12:38:24 +0100 Message-ID: Date: Mon, 27 Nov 2023 12:38:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] ARM: dts: bcm2711-rpi-cm4-io: Enable xHCI host Content-Language: en-US To: Phil Elwell Cc: Justin Chen , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Mathias Nyman , bcm-kernel-feedback-list@broadcom.com, Cyril Brulebois , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20231126025612.12522-1-wahrenst@gmx.net> <53e1f6e6-a28e-45af-991e-75b283a21b34@broadcom.com> <46320840-09ab-4c86-90c9-bee7b75f248a@gmx.net> From: Stefan Wahren In-Reply-To: X-Provags-ID: V03:K1:5xpmIlJ03s0Oj6NYZwycFK0MHCRodpFkZf5S/GcU6pugugr56+0 beBZvRvneVnp2hkEj6nniiwUD+ZfddsRem7zH61uvOHkhY7lgaVQW2Mz2XArvdaDDz0cVmk AJeU6PeF+uBB0NxaZ7xrerXfLxzibFDJKv1h4s3HzDfcTcpRjqtqOwVFmX94Ha0M4/HJ50V 2Yzl35Q6b3YKW/bGE+EtA== UI-OutboundReport: notjunk:1;M01:P0:uV74jL5nR4E=;gYKDyL+02UWZtwx/DABCpUPJ/Iq pPQNtObT+2mO+1oSyB4NJFP0b1+fmHbtEtPlOWDo2uzn/hsNdWqD0P5kIluT47X10ycN5XoZn EqCqOk3crez+PzaHUntX0e9NWVbk6VGDUiIC7Qg0qnU/3and6pM8dW5yHJN8wzid8czWAKwPp qgndN8DlUFI6Qoum5u6Ggjpq7p04xUgfLSStiEWz3nkn+mCraEEKoHyUInQUDe/pm8BijMSYJ /wsJW+QMpkvues8+EB6AZVCXCfHlyhjRfC6nndFYEJ2Ae0v5Y5mpxtQIA0ZAJveJRSW56wXd1 gh+a3dXWWqVHMzp6xRiZ+ru5JoJ2H5GJcml02nTqsau/dg7FUdycL+PueSDxgBWrcVyn2P9Nx fe9lAC0RFaWaUmU72zgwiFDgI/Ad1dmGeuCYZv7RKEg2tzXvqqFgpOIfzm4zUWbBfuAfsT6D6 jy/DNqOFU8W6Yo3IPhZLX2Y/ZWdna6eBLgK5pRT/DGXn6lAFXxGThaxXYhkRL/WWhJfSqUIEa 2MSqLREOz+2d/YnQoKJIE9lwgtmw3EE0AvSu8x98reang7qI2iCI9XvII5JcXV7poYIYMkVew 3v96iFl7DQJD40/2het2lwe0ifxlABThzXKW/YFIptv10hxe1clEvLKns5KjflmulgaJsndER 2PeFNyIz/z2a/UCEvdzWa1OPEDrur+/+hKygTgmAPcNHxHt7DSPwEiVOBRPLRiAr7OU7SJsU2 pCHvm3qFZsFeqa1IDqneXgGUQ3rk4wjF1Msz5lwVb13IT+J4FfVQ88VhE5FD8zXxUjtaWIejq t4RaK1U1TX1yoCJq9JGdpgBuWaomP4OOiazR5E2/2/GeTy/IuaHuYp6v8Q1eeSA/269cMRQcm KRiAQUOPDaAaPV9tRL2DEBQTvGa1RKTlZ3FgWqYuuqstAAnH3bpsYfEjAY+lcKSs3ulVtyld8 iugNrw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231127_033837_628113_294FCC4C X-CRM114-Status: GOOD ( 16.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Phil, Am 27.11.23 um 12:22 schrieb Phil Elwell: > On Mon, 27 Nov 2023 at 11:08, Stefan Wahren wrote: >> Hi Justin, >> >> [add Phil] >> >> Am 27.11.23 um 07:02 schrieb Justin Chen: >>> >>> On 11/25/23 6:56 PM, Stefan Wahren wrote: >>>> In contrast to the Raspberry Pi 4, the Compute Module 4 or the IO board >>>> does not have a VL805 USB 3.0 host controller, which is connected via >>>> PCIe. Instead, the BCM2711 on the Compute Module provides the built-in >>>> xHCI. >>>> >>> Does this work? I maintain this built-in xHCI controller internally. I >>> wasn't aware the Compute Module uses this block. >> i successful tested this with a CM4 (arm 32 bit, >> multi_v7_lpae_defconfig) with eMMC. Before this series the USB devices >> (mouse, keyboard) connected to the host interface didn't work. After >> comparing vendor DTS with mainline i noticed the missing xHCI block [1]. >> Unfortunately i wasn't able to get further information from the public >> datasheets. I don't know if the VideoCore does some magic tricks on the >> xHCI or i missed some downstream xHCI changes. >> >>> This block is held in reset and needs a bit toggled to get things >>> going. Florian, just to confirm, this is our "brcm,xhci-brcm-v2" block >>> correct? >>> >>> Justin >> [1] - >> https://github.com/raspberrypi/linux/blob/rpi-6.1.y/arch/arm/boot/dts/bcm2711-rpi-ds.dtsi#L119 > What's the question here? Does the XHCI block present in the > raspberrypi/linux dtsi file really exist? Yes it does. since i don't have any documentation about the xHCI block, i assumed the compatible generic-xhci is correct. But Justin seems to suggest that the xHCI block needs some special treatment and we need a specific compatible. Did i missed some xHCI driver changes? Does the VC firmware something to the xHCI especially on CM4? Thanks > > Phil _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel