[PATCH 0/2] SCMI performance protocol power scale interface

[PATCH 0/2] SCMI performance protocol power scale interface

[Lukasz Luba]

Hi all,

The Energy Model (EM) supports power values expressed in an abstract scale
via new API. The SCMI performance protocol provides the information about
power scale. This patch set implements the needed interface and updates
cpufreq driver to set the right scale in the EM.

It is based on top of patch series adding milli-Watts flag in EM [1]
(next-20201124 was used as a base).

Regards,
Lukasz

[1] https://lore.kernel.org/linux-pm/20201103090600.29053-1-lukasz.luba@arm.com/

Lukasz Luba (2):
  firmware: arm_scmi: Add power_scale_mw_get() interface
  cpufreq: arm_scmi: Discover the power scale in performance protocol

 drivers/cpufreq/scmi-cpufreq.c   | 4 +++-
 drivers/firmware/arm_scmi/perf.c | 8 ++++++++
 include/linux/scmi_protocol.h    | 1 +
 3 files changed, 12 insertions(+), 1 deletion(-)

-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 1/2] firmware: arm_scmi: Add power_scale_mw_get() interface

[Lukasz Luba]

Add a new interface to the existing perf_ops and export the information
about the power values scale.

This would be used by the cpufreq driver and Energy Model framework to
set the performance domains scale: milli-Watts or abstract scale.

Suggested-by: Morten Rasmussen <morten.rasmussen@arm.com>
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
 drivers/firmware/arm_scmi/perf.c | 8 ++++++++
 include/linux/scmi_protocol.h    | 1 +
 2 files changed, 9 insertions(+)

diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c
index 82fb3babff72..e374b1125fca 100644
--- a/drivers/firmware/arm_scmi/perf.c
+++ b/drivers/firmware/arm_scmi/perf.c
@@ -750,6 +750,13 @@ static bool scmi_fast_switch_possible(const struct scmi_handle *handle,
 	return dom->fc_info && dom->fc_info->level_set_addr;
 }
 
+static bool scmi_power_scale_mw_get(const struct scmi_handle *handle)
+{
+	struct scmi_perf_info *pi = handle->perf_priv;
+
+	return pi->power_scale_mw;
+}
+
 static const struct scmi_perf_ops perf_ops = {
 	.limits_set = scmi_perf_limits_set,
 	.limits_get = scmi_perf_limits_get,
@@ -762,6 +769,7 @@ static const struct scmi_perf_ops perf_ops = {
 	.freq_get = scmi_dvfs_freq_get,
 	.est_power_get = scmi_dvfs_est_power_get,
 	.fast_switch_possible = scmi_fast_switch_possible,
+	.power_scale_mw_get = scmi_power_scale_mw_get,
 };
 
 static int scmi_perf_set_notify_enabled(const struct scmi_handle *handle,
diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h
index dd9e94849fc1..ecb3aad1a964 100644
--- a/include/linux/scmi_protocol.h
+++ b/include/linux/scmi_protocol.h
@@ -122,6 +122,7 @@ struct scmi_perf_ops {
 			     unsigned long *rate, unsigned long *power);
 	bool (*fast_switch_possible)(const struct scmi_handle *handle,
 				     struct device *dev);
+	bool (*power_scale_mw_get)(const struct scmi_handle *handle);
 };
 
 /**
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] firmware: arm_scmi: Add power_scale_mw_get() interface

[Sudeep Holla]

On Tue, Nov 24, 2020 at 10:43:45AM +0000, Lukasz Luba wrote:
> Add a new interface to the existing perf_ops and export the information
> about the power values scale.
> 
> This would be used by the cpufreq driver and Energy Model framework to
> set the performance domains scale: milli-Watts or abstract scale.
>

Looks good to me. I saw this after I sent pull request this afternoon.
In case you want to take it via PM tree:

Acked-by: Sudeep Holla <sudeep.holla@arm.com>

-- 
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] firmware: arm_scmi: Add power_scale_mw_get() interface

[Lukasz Luba]

On 11/24/20 4:56 PM, Sudeep Holla wrote:
> On Tue, Nov 24, 2020 at 10:43:45AM +0000, Lukasz Luba wrote:
>> Add a new interface to the existing perf_ops and export the information
>> about the power values scale.
>>
>> This would be used by the cpufreq driver and Energy Model framework to
>> set the performance domains scale: milli-Watts or abstract scale.
>>
> 
> Looks good to me. I saw this after I sent pull request this afternoon.
> In case you want to take it via PM tree:
> 
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> 

Thank you Sudeep!

Regards,
Lukasz


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/2] cpufreq: arm_scmi: Discover the power scale in performance protocol

[Lukasz Luba]

Add mechanism to discover the power scale present in the performance
protocol for all domains. Provide this information to Energy Model,
which then can be checked in other frameworks, e.g. thermal.

Suggested-by: Morten Rasmussen <morten.rasmussen@arm.com>
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
 drivers/cpufreq/scmi-cpufreq.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
index dfd87752f054..491a0a24fb1e 100644
--- a/drivers/cpufreq/scmi-cpufreq.c
+++ b/drivers/cpufreq/scmi-cpufreq.c
@@ -126,6 +126,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
 	struct scmi_data *priv;
 	struct cpufreq_frequency_table *freq_table;
 	struct em_data_callback em_cb = EM_DATA_CB(scmi_get_cpu_power);
+	bool power_scale_mw;
 
 	cpu_dev = get_cpu_device(policy->cpu);
 	if (!cpu_dev) {
@@ -189,8 +190,9 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
 	policy->fast_switch_possible =
 		handle->perf_ops->fast_switch_possible(handle, cpu_dev);
 
+	power_scale_mw = handle->perf_ops->power_scale_mw_get(handle);
 	em_dev_register_perf_domain(cpu_dev, nr_opp, &em_cb, policy->cpus,
-				    false);
+				    power_scale_mw);
 
 	return 0;
 
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] SCMI performance protocol power scale interface

[Lukasz Luba]

Hi Rafael,

On 11/24/20 10:43 AM, Lukasz Luba wrote:
> Hi all,
> 
> The Energy Model (EM) supports power values expressed in an abstract scale
> via new API. The SCMI performance protocol provides the information about
> power scale. This patch set implements the needed interface and updates
> cpufreq driver to set the right scale in the EM.
> 
> It is based on top of patch series adding milli-Watts flag in EM [1]
> (next-20201124 was used as a base).
> 
> Regards,
> Lukasz
> 
> [1] https://lore.kernel.org/linux-pm/20201103090600.29053-1-lukasz.luba@arm.com/
> 
> Lukasz Luba (2):
>    firmware: arm_scmi: Add power_scale_mw_get() interface
>    cpufreq: arm_scmi: Discover the power scale in performance protocol
> 
>   drivers/cpufreq/scmi-cpufreq.c   | 4 +++-
>   drivers/firmware/arm_scmi/perf.c | 8 ++++++++
>   include/linux/scmi_protocol.h    | 1 +
>   3 files changed, 12 insertions(+), 1 deletion(-)
> 

Could you take this patch set, please?

Patch 1/2, which is ARM firmware protocol change, got ACK from Sudeep in
case it would go via your PM tree.

The patch series is a follow up to the EM changes, which you have taken
recently into your PM tree (link in the cover letter above).

Regards,
Lukasz

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] SCMI performance protocol power scale interface

[Viresh Kumar]

On 24-11-20, 10:43, Lukasz Luba wrote:
> Hi all,
> 
> The Energy Model (EM) supports power values expressed in an abstract scale
> via new API. The SCMI performance protocol provides the information about
> power scale. This patch set implements the needed interface and updates
> cpufreq driver to set the right scale in the EM.
> 
> It is based on top of patch series adding milli-Watts flag in EM [1]
> (next-20201124 was used as a base).
> 
> Regards,
> Lukasz
> 
> [1] https://lore.kernel.org/linux-pm/20201103090600.29053-1-lukasz.luba@arm.com/
> 
> Lukasz Luba (2):
>   firmware: arm_scmi: Add power_scale_mw_get() interface
>   cpufreq: arm_scmi: Discover the power scale in performance protocol
> 
>  drivers/cpufreq/scmi-cpufreq.c   | 4 +++-
>  drivers/firmware/arm_scmi/perf.c | 8 ++++++++
>  include/linux/scmi_protocol.h    | 1 +
>  3 files changed, 12 insertions(+), 1 deletion(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] SCMI performance protocol power scale interface

[Viresh Kumar]

On 07-12-20, 12:43, Viresh Kumar wrote:
> On 24-11-20, 10:43, Lukasz Luba wrote:
> > Hi all,
> > 
> > The Energy Model (EM) supports power values expressed in an abstract scale
> > via new API. The SCMI performance protocol provides the information about
> > power scale. This patch set implements the needed interface and updates
> > cpufreq driver to set the right scale in the EM.
> > 
> > It is based on top of patch series adding milli-Watts flag in EM [1]
> > (next-20201124 was used as a base).
> > 
> > Regards,
> > Lukasz
> > 
> > [1] https://lore.kernel.org/linux-pm/20201103090600.29053-1-lukasz.luba@arm.com/
> > 
> > Lukasz Luba (2):
> >   firmware: arm_scmi: Add power_scale_mw_get() interface
> >   cpufreq: arm_scmi: Discover the power scale in performance protocol
> > 
> >  drivers/cpufreq/scmi-cpufreq.c   | 4 +++-
> >  drivers/firmware/arm_scmi/perf.c | 8 ++++++++
> >  include/linux/scmi_protocol.h    | 1 +
> >  3 files changed, 12 insertions(+), 1 deletion(-)
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

More scmi stuff came in which I had to apply and so I applied this to
the ARM tree.

Rafael: I had to rebase this over one of the patches from your tree,
which was based on rc3:

commit c250d50fe2ce ("PM: EM: Add a flag indicating units of power values in Energy Model")

I hope you won't rebase it any further.

Applied. Thanks.

-- 
viresh

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 0/2] SCMI performance protocol power scale interface

[Lukasz Luba]

On 12/8/20 4:48 AM, Viresh Kumar wrote:
> On 07-12-20, 12:43, Viresh Kumar wrote:
>> On 24-11-20, 10:43, Lukasz Luba wrote:
>>> Hi all,
>>>
>>> The Energy Model (EM) supports power values expressed in an abstract scale
>>> via new API. The SCMI performance protocol provides the information about
>>> power scale. This patch set implements the needed interface and updates
>>> cpufreq driver to set the right scale in the EM.
>>>
>>> It is based on top of patch series adding milli-Watts flag in EM [1]
>>> (next-20201124 was used as a base).
>>>
>>> Regards,
>>> Lukasz
>>>
>>> [1] https://lore.kernel.org/linux-pm/20201103090600.29053-1-lukasz.luba@arm.com/
>>>
>>> Lukasz Luba (2):
>>>    firmware: arm_scmi: Add power_scale_mw_get() interface
>>>    cpufreq: arm_scmi: Discover the power scale in performance protocol
>>>
>>>   drivers/cpufreq/scmi-cpufreq.c   | 4 +++-
>>>   drivers/firmware/arm_scmi/perf.c | 8 ++++++++
>>>   include/linux/scmi_protocol.h    | 1 +
>>>   3 files changed, 12 insertions(+), 1 deletion(-)
>>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> More scmi stuff came in which I had to apply and so I applied this to
> the ARM tree.
> 
> Rafael: I had to rebase this over one of the patches from your tree,
> which was based on rc3:
> 
> commit c250d50fe2ce ("PM: EM: Add a flag indicating units of power values in Energy Model")
> 
> I hope you won't rebase it any further.
> 
> Applied. Thanks.
> 

Thank you Viresh!

Regards,
Lukasz

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel