From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19BBBC001B0 for ; Mon, 7 Aug 2023 21:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gs5mHNQpLqWklH+cczWgfvpT9fYixFpQCT58Rx/nOqg=; b=1rQPmnyElAunoe oUtdfjBpgbEgRSsJcstjtxXPfwKAsmogbCGmgJm+NfrhgZvpa4SdXjxU9lDGSE3tDDLs6tTE2pIOv MtkF0r0ar1XZsAOTy3r7uV6RzsUMN1EFwedWAUZDlgVIR1KxBkKVQUxXrwlTzujQsbc2OxAVZ+rxP 72jrrEhDNt5fH3GuVkxm0SYjT39HH1Gr+Bu0N6vdMpBS15FVp3dpte6/5utz/UarWpQbJNObciJOC 1NYPagvEbIFPMmU1u09rjWhH0Y5NBQ+DjAlT1fj5U+4Wco0TGi6aoEE8i0ba2trleFYklApTd/Ptg T7DIqGynV5laDHMLU+WA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qT7jR-000lKR-28; Mon, 07 Aug 2023 21:25:41 +0000 Received: from out-110.mta0.migadu.com ([91.218.175.110]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qT7jO-000lJ8-2J for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 21:25:40 +0000 Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1691443530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4ru8zGvKg03gqB6GmVvzBu1vOdq2JxR2kLEcmblTX14=; b=cuh5B+hMwOeMx7QNFVS1Me32+fiKBNFaaYoRhBeAHBOYKtgOJC0wx/L9rZ7pnd6JWuZsj1 l8isGq0u03fpSg0CFrSArp3QKInSqeDCSI921ACrN8z0D+4BEti6jYm36NMr6RMffkeg3c SZGEAgFggLraPSp2D0F2sqTGJlg0f3g= Date: Mon, 7 Aug 2023 22:25:25 +0100 MIME-Version: 1.0 Subject: Re: [PATCH net-next v2 2/9] dpll: spec: Add Netlink spec in YAML To: Jiri Pirko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org, Simon Horman References: <20230804190454.394062-1-vadim.fedorenko@linux.dev> <20230804190454.394062-3-vadim.fedorenko@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230807_142539_204607_18058F05 X-CRM114-Status: GOOD ( 17.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/08/2023 08:56, Jiri Pirko wrote: > Fri, Aug 04, 2023 at 09:04:47PM CEST, vadim.fedorenko@linux.dev wrote: >> Add a protocol spec for DPLL. >> Add code generated from the spec. >> >> Signed-off-by: Jakub Kicinski >> Signed-off-by: Michal Michalik >> Signed-off-by: Vadim Fedorenko >> Signed-off-by: Arkadiusz Kubalewski >> --- > > Hmm, running tools/net/ynl/ynl-regen.sh generates following diff: > diff --git a/drivers/dpll/dpll_nl.c b/drivers/dpll/dpll_nl.c > index ff3f55f0ca94..638e21a9a06d 100644 > --- a/drivers/dpll/dpll_nl.c > +++ b/drivers/dpll/dpll_nl.c > @@ -17,7 +17,6 @@ const struct nla_policy dpll_pin_parent_device_nl_policy[DPLL_A_PIN_STATE + 1] = > [DPLL_A_PIN_PRIO] = { .type = NLA_U32, }, > [DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3), > }; > - > const struct nla_policy dpll_pin_parent_pin_nl_policy[DPLL_A_PIN_STATE + 1] = { > [DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3), > [DPLL_A_PIN_ID] = { .type = NLA_U32, }, > diff --git a/include/uapi/linux/dpll.h b/include/uapi/linux/dpll.h > index f659fabb1041..18d4fda484e8 100644 > --- a/include/uapi/linux/dpll.h > +++ b/include/uapi/linux/dpll.h > @@ -163,7 +163,6 @@ enum dpll_a { > DPLL_A_PIN_PARENT_DEVICE, > DPLL_A_PIN_PARENT_PIN, > > - /* private: */ > __DPLL_A_MAX, > DPLL_A_MAX = (__DPLL_A_MAX - 1) > }; > @@ -182,7 +181,6 @@ enum dpll_cmd { > DPLL_CMD_PIN_DELETE_NTF, > DPLL_CMD_PIN_CHANGE_NTF, > > - /* private: */ > __DPLL_CMD_MAX, > DPLL_CMD_MAX = (__DPLL_CMD_MAX - 1) > }; > > Do you base this patchset on top of recent net-next? If not, please do > rebase. > Well, in my case after rebasing on latest net-next I got just part of your diff: diff --git a/drivers/dpll/dpll_nl.c b/drivers/dpll/dpll_nl.c index ff3f55f0ca94..638e21a9a06d 100644 --- a/drivers/dpll/dpll_nl.c +++ b/drivers/dpll/dpll_nl.c @@ -17,7 +17,6 @@ const struct nla_policy dpll_pin_parent_device_nl_policy[DPLL_A_PIN_STATE + 1] = [DPLL_A_PIN_PRIO] = { .type = NLA_U32, }, [DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3), }; - const struct nla_policy dpll_pin_parent_pin_nl_policy[DPLL_A_PIN_STATE + 1] = { [DPLL_A_PIN_STATE] = NLA_POLICY_RANGE(NLA_U8, 1, 3), [DPLL_A_PIN_ID] = { .type = NLA_U32, }, The "/* private: */" comment was added to the generator after Simon's comment. But I'll include this part into the next version. > > Other than this, looks fine to me. > > Signed-off-by: Jiri Pirko Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel