From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DE0CC6FD1F for ; Tue, 14 Mar 2023 19:47:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mtLqBh5E1WjB4DEkSVZyyLXUKrtf5zfyBve5XM0B6hE=; b=WjFDD0Zs3JJx4x yfrIwwvfTQZb6v76Tv7liYeMJHViElaNg+cjLPnp7G6Klhh07S96jvdwSqxVvAWKbSlb9DBnpHoZo AYh1trlywFO3ykFrNxBX24Ww/r5OAn7LzGRO/vsO5IhmNkBt/VncZr3ZFMoxEDt3IG0Thxctdq5wv qBy7R1h0+cDBBx1XYVdb16PLvflIvVaTHMSNSyCb559/EN884ejQOzSrdqjoV0CAfjUmCYEwzX1QR Om4V0uaj6R/SNKdUppE0fw3Jzd8v0kM8sBLMY3OL5i5c9+37h4GYY1oR50umQMyshFrAQRSPZvfGQ Oo5L6+qlUhAAyeCWmPEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcAb5-00BN3S-19; Tue, 14 Mar 2023 19:46:11 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcAaw-00BN1h-0I for linux-arm-kernel@lists.infradead.org; Tue, 14 Mar 2023 19:46:10 +0000 Received: by mail-ed1-x529.google.com with SMTP id x13so19327864edd.1 for ; Tue, 14 Mar 2023 12:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678823160; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XhnhusYpso9h8+/nIXY/oJLXEHrnKb2XiVlsQ9b08H4=; b=ONDiRQagLTVyvzhrwFbGYhO7MweGA6aPWx0XzV66MsRpmOqC6Koe729Wn1HCEVWNFQ D3o27iD9GCWZfCNB4KhCIsODlMZxTigsYuoteSZOS9Y7p11mUUaRrQkvKBvltukPpzuR YwCcPUUdHntD26Vgi/eXntOrEzlV/zygRL/d/wkxClarxgzUrqu3sWTkkYcHVspsILbB SN36+f4tzy7P6L/PCVmwVJ3s6mm8+I4nLQ4z+4q9fzE6weT6jOG+/nwCjMV7AAEJdvVD rBzagmtkh6wwMMixWUcbRj32wjyYdywdmT0HdUzyUQWa7C4uGFnVNmvmVH9wGDf434Tw iD6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678823160; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XhnhusYpso9h8+/nIXY/oJLXEHrnKb2XiVlsQ9b08H4=; b=APxmgTyDl+VUCnh/IrE4R5qtMFdQ9/1NqR3MLPdZLpjZWmKAJKGfRJvJXkLyYUtxI9 7KMqKoEUp/dTdQjA72k0j2shCrglGFqlquodW8uBFbr+vLXeAVfjqbGfzm8FQCMW1yqC oiJ2DywHOp6254DlDuAB7Tw3mH7zMfZgO9Y0/OXShLTeisLBiS5PV6+ECuzM/Efz+QtV vNnWNku1W/O5XLonqP83AEUn/ysMB0vW3nLYPk6oT2o3FQc4GS6Q2bmmHWaGYMKOlwcJ /AO/WxE+He4SoFwx66DscJ206vhrIL90x89leclz0LC8npht5rwP2PoBaQZIdwHDGqvo h+oQ== X-Gm-Message-State: AO0yUKVn8ikNh/SVb2f1M86jlzOlIRYwTbydygUibbUL5kRYDR3Z2qQ/ wOBiB7eJBBC3vyjk2e1DgYCILXvR6lK8f/UlYlg= X-Google-Smtp-Source: AK7set8dJIX6MG0tfCB9Nt2ztaf3oOfZDw/JWQK995BqtVEHbWKwofAbRL4CvEuHlmwte2N8XPGQCA== X-Received: by 2002:a17:906:32d4:b0:878:7f6e:38a7 with SMTP id k20-20020a17090632d400b008787f6e38a7mr3667050ejk.44.1678823160567; Tue, 14 Mar 2023 12:46:00 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:642b:87c2:1efc:c8af? ([2a02:810d:15c0:828:642b:87c2:1efc:c8af]) by smtp.gmail.com with ESMTPSA id hb12-20020a170907160c00b008d9ddd2da88sm1533268ejc.6.2023.03.14.12.45.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Mar 2023 12:46:00 -0700 (PDT) Message-ID: Date: Tue, 14 Mar 2023 20:45:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v11 03/13] dt-bindings: Convert gpio-mmio to yaml To: Sean Anderson , Vinod Koul , Kishon Vijay Abraham I , linux-phy@lists.infradead.org Cc: Krzysztof Kozlowski , Rob Herring , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Camelia Alexandra Groza , Madalin Bucur , Bagas Sanjaya , Ioana Ciornei , linuxppc-dev@lists.ozlabs.org, Linus Walleij , Bartosz Golaszewski , =?UTF-8?Q?Fern=c3=a1ndez_Rojas?= , Jonas Gorski , linux-gpio@vger.kernel.org References: <20230313161138.3598068-1-sean.anderson@seco.com> <20230313161138.3598068-4-sean.anderson@seco.com> <684eb04d-aeaa-07e1-34d6-783e85e379f0@linaro.org> <3c19e6d2-4df2-6187-36d5-98ceef07235a@seco.com> <7c7311ad-fbdf-3c7e-dab5-28a562fb7e8d@seco.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <7c7311ad-fbdf-3c7e-dab5-28a562fb7e8d@seco.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_124602_150711_CC86D1E4 X-CRM114-Status: GOOD ( 15.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/03/2023 19:50, Sean Anderson wrote: > On 3/14/23 14:32, Krzysztof Kozlowski wrote: >> On 14/03/2023 19:09, Sean Anderson wrote: >>> On 3/14/23 13:56, Krzysztof Kozlowski wrote: >>>> On 13/03/2023 17:11, Sean Anderson wrote: >>>> + reg-names: >>>>> + minItems: 1 >>>>> + maxItems: 5 >>>>> + items: >>>>> + enum: >>>> >>>> Why this is in any order? Other bindings were here specific, your 'reg' >>>> is also specific/fixed. >>> >>> Some devicetrees have dirout first, and other have dat first. There is no >>> mandatory order, and some registers can be included or left out as is >>> convenient to the devicetree author. >>> >>> reg is not specific/fixed either. It is just done that way for >>> convenience (and to match the names here). >> >> The items have order and usually we require strict order from DTS, >> unless there is a reason. If there is no reason, use fixed order and >> then fix the DTS. > > The items do not have order. That is the whole point of having a > separate names property. The DTs are not "broken" for taking advantage > of a longstanding feature. There is no advantage to rewriting them to > use a fixed order, especially when there is no precedent. This is just > an area where json schema cannot completely validate devicetrees. I don't understand "there is no precedent". There is - we rewrite hundreds of DTS. Just look at mine and other people commits. The reg-names are helper and entries were always expected to be ordered. On the other hand if different devices use different order, then it cannot be changed obviously (as the order is fixed). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel