From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 249A8C67861 for ; Tue, 9 Apr 2024 09:27:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:In-Reply-To: Subject:cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9o2VlIsGeFI5EP4KB6mjS+KgmRfxAPLDAoMAksM+Dj4=; b=OfDJQtQp5Zksl49RhhQLLF28B4 4F64P8N0R/7+cr2muM4ro3vzSW0gUL9HzKeFEAVGsepgsGd3l9yWwe322Jj92DBSdPESXGaB4lX8/ mjJftFrQeCnewoee36zbhEPtWdr9dRBLmgud/befioF44OynsMEjEEPJxhV4G+TIS27IMkFKF8QbK SYwrYeV060CZ0G5dFuiIVoV/SVkzzMfeWHNPWZF/9uNKSzyjJf7BJpGDBuE49x+0Y4ltBxkgXClPC yBjoIh6Z2FCUI2fDn+5zy923S4dmCrRJCPSN19e+h0X6fBRWTIPGzLjFBbIO/tW4gwSZ+EliaJHLB Pel4U9MA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru7kT-00000001Cf5-02it; Tue, 09 Apr 2024 09:26:37 +0000 Received: from andre.telenet-ops.be ([2a02:1800:120:4::f00:15]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru7kP-00000001Ccn-3gLH for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2024 09:26:35 +0000 Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed80:76d0:2bff:fec8:549]) by andre.telenet-ops.be with bizsmtp id 8xSR2C00c0SSLxL01xSRx9; Tue, 09 Apr 2024 11:26:28 +0200 Received: from geert (helo=localhost) by ramsan.of.borg with local-esmtp (Exim 4.95) (envelope-from ) id 1ru7kH-00D2QY-KH; Tue, 09 Apr 2024 11:26:25 +0200 Date: Tue, 9 Apr 2024 11:26:25 +0200 (CEST) From: Geert Uytterhoeven To: Maxime Ripard cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jani Nikula , dri-devel@lists.freedesktop.org, Jani Nikula , Lucas De Marchi , kernel test robot , linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 00/13] drm/display: Convert helpers Kconfig symbols to depends on In-Reply-To: <20240327-kms-kconfig-helpers-v3-0-eafee11b84b3@kernel.org> Message-ID: References: <20240327-kms-kconfig-helpers-v3-0-eafee11b84b3@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_022634_146756_E1CF6688 X-CRM114-Status: GOOD ( 22.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime, On Wed, 27 Mar 2024, Maxime Ripard wrote: > Jani recently pointed out that the Kconfig symbols are a bit difficult > to work with at the moment when they depend on each other, and that > using depends on would be a better idea, but no one really did the work > so far. > > So here it goes :) > > It's been tested by comparing the riscv defconfig, arm > multi_v7_defconfig, arm64 defconfig, drm-misc-arm, drm-misc-arm64 and > drm-misc-x86 before and after this series and making sure they are > identical. That is not true: comparing drm-misc/for-linux-next to v6.9-rc2, arm/multi_v7_defconfig, arm64/defconfig, and riscv/defconfig lost several of: - CONFIG_DRM_DW_HDMI, - CONFIG_DRM_DW_HDMI_AHB_AUDIO, - CONFIG_DRM_DW_HDMI_CEC, - CONFIG_DRM_DW_HDMI_I2S_AUDIO, - CONFIG_DRM_IMX_HDMI. - CONFIG_DRM_MESON_DW_HDMI, - CONFIG_DRM_RCAR_DW_HDMI, - CONFIG_DRM_SUN8I_DW_HDMI, - CONFIG_ROCKCHIP_DW_HDMI, - CONFIG_SND_MESON_G12A_TOHDMITX, > Let me know what you think, IMHO this series looks like a big usuability issue for anyone configuring the kernel, and you try to work around this by sprinkling "default y" around. The user should not need to know which helpers are needed for the driver he is interested in. When a symbol selects another symbol, it should just make sure the dependencies of the target symbol are met. Thanks for reverting ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel