From: Yonghong Song <yonghong.song@linux.dev>
To: Puranjay Mohan <puranjay@kernel.org>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Song Liu <song@kernel.org>, Xu Kuohai <xukuohai@huaweicloud.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: Use at least 10 args in stack argument tests
Date: Thu, 28 May 2026 13:55:43 -0700 [thread overview]
Message-ID: <a81c1628-685e-42dc-9860-8c8ed507328f@linux.dev> (raw)
In-Reply-To: <20260528161750.1900674-3-puranjay@kernel.org>
On 5/28/26 9:17 AM, Puranjay Mohan wrote:
> On arm64, the first 8 arguments are passed in registers (x0-x7), so
> tests with 8 or fewer arguments never exercise the native stack argument
> path in the JIT. Increase argument counts to at least 10 across all
> BPF-to-BPF subprog and kfunc stack argument tests so that at least 2
> arguments land on the arm64 stack.
>
> For the two-callees test, bump foo1 from 8 to 10 and foo2 from 10 to 12
> args to preserve the different-stack-depth flavor of the test.
>
> The bpf_kfunc_call_stack_arg_mem kfunc is left unchanged at 7 args to
> avoid breaking the precision backtracking test which relies on hardcoded
> verifier log instruction indices.
>
> Suggested-by: Will Deacon <will@kernel.org>
> Signed-off-by: Puranjay Mohan <puranjay@kernel.org>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
prev parent reply other threads:[~2026-05-28 21:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 16:17 [PATCH bpf-next 0/2] bpf, arm64: Stack argument fixes Puranjay Mohan
2026-05-28 16:17 ` [PATCH bpf-next 1/2] bpf, arm64: Fix redundant MOV and clarify stack arg comments Puranjay Mohan
2026-05-28 16:17 ` [PATCH bpf-next 2/2] selftests/bpf: Use at least 10 args in stack argument tests Puranjay Mohan
2026-05-28 20:55 ` Yonghong Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a81c1628-685e-42dc-9860-8c8ed507328f@linux.dev \
--to=yonghong.song@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=puranjay@kernel.org \
--cc=song@kernel.org \
--cc=will@kernel.org \
--cc=xukuohai@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox