From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1FEFEE3EC1 for ; Sat, 9 Sep 2023 16:26:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b7zeUh5xnVl3gVQrNiFPa2s5ogBOcUZK2pJAZGyNfH8=; b=11V+RHyhfLY60T G5GIqsAAYHOMptbZydRCirIFEa5I51fwWfBu+TeuOpbWLC0YmHxoc6l8YhPXLpajHJJMRqz8OFdoF /Wv/wvtM5i5M1jo5fYedArbgiCm6rjX3citCepCKAvKd5/D/5MHXalm3wcxaf3oNCaM8j0ixLsl5C nYHHaPbBJfx08R565aJnMXN1DHTMXa0b4oc+18+FtaVT5GYmtR1KgusflKDqYXooiPtcyeGIxTi+y P2fh3c/AY0hQ93No9o6ZOtYvhvrZw8UuuEsR7NuYkSYIAUNiksWSPfdBjgjVywfKUikctPvTOZKgg JcIfbQwBU9FyNIu+bS9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qf0m3-00FdCi-10; Sat, 09 Sep 2023 16:25:31 +0000 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qf0m0-00FdAf-03 for linux-arm-kernel@lists.infradead.org; Sat, 09 Sep 2023 16:25:29 +0000 Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-502b0d23f28so292624e87.2 for ; Sat, 09 Sep 2023 09:25:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1694276724; x=1694881524; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eQE6ckc0oZWZqJvmZPgbajkRP4Z8CAIaomWfQSYs+5o=; b=eUKF350UspyQClJQ/mBqS2EYGiCn6mpwZPZj/pc1WMf9NpM4edUayEfl7Z63ANDmwQ cOS9yOA7nPrdCKWav6udTq7N46QiTR3W14vf3Ns/dmmScrmvXDoHww9TSHHDU1YJD4AC NRqQbFZrhZeJi3o65fDEB2S+PRJ4XLQ06RN6dwwCmP26UTYl+3mnWJHYazcEgR4umoGu JGbq6K/oN/hKr2pYyoypCMJsZSqXZkcos8ThIprvVsZ+6XgZB0PErkF2LciSszTkbCTX yKPoYjZTO7CIjtXeVR+QnQxcxflnXfpW1XNVWSJ1Hwl5Y1FLQgV2/Qf3pCALTPK4cnJK IQQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694276724; x=1694881524; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eQE6ckc0oZWZqJvmZPgbajkRP4Z8CAIaomWfQSYs+5o=; b=UExAiqkbmfur2Y3BDLRA5SFGm8ZH3YXLxtbj8rApnfSK3p43PESJcIWHRA1S6sOlVs bycSYvlEdef4r4sAJIlM0xHUngCr+gbIPVTyN2RE7hCV9bYM5LOiSJ0ZybwUtQw4DAhX 5j0y6U05c1oU5TAzXjPmwgUBCBG0zOOHfLgrZgMMtN/J0xD5zLXf1yBqafBLLLPCGkOG BgLON+cPJ9W152HGEoaMfuucvkkvqGonvHketjw93P5Q32ka2OhjBQiRjoMEzdoBpckW kj2A2nCAlE03r/mFkImi/ah2n+p6nFWcAGfpE3GTtwuT/PVNgoK1qLUecw+04B2Mr+Hs FX3Q== X-Gm-Message-State: AOJu0YyKvHGDKnWyOWweeVLYJVr2QRA5Eoxbt7IaUrPNaF5ICbyqyAvY kEYq4W7cZCiCL2YE8WAHCx2MlA== X-Google-Smtp-Source: AGHT+IEfVZuS1Jpmntu4yEY561Ek36RST0fB8NMR+natsnsDl43t7oQj2yqxoe5fUi+Dr4a/NGrLQQ== X-Received: by 2002:a05:6512:6c9:b0:500:86cf:124b with SMTP id u9-20020a05651206c900b0050086cf124bmr5353066lff.62.1694276723592; Sat, 09 Sep 2023 09:25:23 -0700 (PDT) Received: from [192.168.32.2] ([82.78.167.145]) by smtp.gmail.com with ESMTPSA id f22-20020a056402069600b0052a626daf4csm2346689edy.47.2023.09.09.09.25.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Sep 2023 09:25:23 -0700 (PDT) Message-ID: Date: Sat, 9 Sep 2023 19:25:21 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v4 6/8] drm: atmel-hlcdc: add DPI mode support for XLCDC Content-Language: en-US To: Manikandan Muralidharan , sam@ravnborg.org, bbrezillon@kernel.org, airlied@gmail.com, daniel@ffwll.ch, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, lee@kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Hari.PrasathGE@microchip.com, Balamanikandan.Gunasundar@microchip.com, Durai.ManickamKR@microchip.com, Nayabbasha.Sayed@microchip.com, Dharma.B@microchip.com, Varshini.Rajendran@microchip.com, Balakrishnan.S@microchip.com References: <20230825125444.93222-1-manikandan.m@microchip.com> <20230825125444.93222-7-manikandan.m@microchip.com> From: claudiu beznea In-Reply-To: <20230825125444.93222-7-manikandan.m@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230909_092528_055742_910B7BF9 X-CRM114-Status: GOOD ( 21.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/25/23 15:54, Manikandan Muralidharan wrote: > Add support for Display Pixel Interface (DPI) Compatible Mode > support in atmel-hlcdc driver for XLCDC IP along with legacy > pixel mapping.DPI mode BIT is configured in LCDC_CFG5 register. > > Signed-off-by: Manikandan Muralidharan > [durai.manickamkr@microchip.com: update DPI mode bit using is_xlcdc flag] > Signed-off-by: Durai Manickam KR > --- > .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 22 ++++++++++++++++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > index 4b11a1de8af4..c3d0c60ba419 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > @@ -30,10 +30,12 @@ > * > * @base: base CRTC state > * @output_mode: RGBXXX output mode > + * @dpi: output DPI mode > */ > struct atmel_hlcdc_crtc_state { > struct drm_crtc_state base; > unsigned int output_mode; > + bool dpi; To avoid confusion, better use u8 to avoid shifting a boolean value in configuration phase. > }; > > static inline struct atmel_hlcdc_crtc_state * > @@ -164,6 +166,8 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c) > > state = drm_crtc_state_to_atmel_hlcdc_crtc_state(c->state); > cfg = state->output_mode << 8; > + if (is_xlcdc) > + cfg |= state->dpi << 11; > > if (!is_xlcdc && (adj->flags & DRM_MODE_FLAG_NVSYNC)) > cfg |= ATMEL_HLCDC_VSPOL; > @@ -176,7 +180,9 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c) > ATMEL_HLCDC_VSPDLYS | ATMEL_HLCDC_VSPDLYE | > ATMEL_HLCDC_DISPPOL | ATMEL_HLCDC_DISPDLY | > ATMEL_HLCDC_VSPSU | ATMEL_HLCDC_VSPHO | > - ATMEL_HLCDC_GUARDTIME_MASK | ATMEL_HLCDC_MODE_MASK, > + ATMEL_HLCDC_GUARDTIME_MASK | > + (is_xlcdc ? ATMEL_XLCDC_MODE_MASK | > + ATMEL_XLCDC_DPI : ATMEL_HLCDC_MODE_MASK), > cfg); > > clk_disable_unprepare(crtc->dc->hlcdc->sys_clk); > @@ -366,7 +372,15 @@ static int atmel_hlcdc_crtc_select_output_mode(struct drm_crtc_state *state) > > hstate = drm_crtc_state_to_atmel_hlcdc_crtc_state(state); > hstate->output_mode = fls(output_fmts) - 1; > - > + if (crtc->dc->desc->is_xlcdc) { > + /* check if MIPI DPI bit needs to be set */ > + if (fls(output_fmts) > 3) { > + hstate->output_mode -= 4; > + hstate->dpi = true; > + } else { > + hstate->dpi = false; > + } > + } > return 0; > } > > @@ -470,7 +484,7 @@ static struct drm_crtc_state * > atmel_hlcdc_crtc_duplicate_state(struct drm_crtc *crtc) > { > struct atmel_hlcdc_crtc_state *state, *cur; > - > + struct atmel_hlcdc_crtc *c = drm_crtc_to_atmel_hlcdc_crtc(crtc); > if (WARN_ON(!crtc->state)) > return NULL; > > @@ -481,6 +495,8 @@ atmel_hlcdc_crtc_duplicate_state(struct drm_crtc *crtc) > > cur = drm_crtc_state_to_atmel_hlcdc_crtc_state(crtc->state); > state->output_mode = cur->output_mode; > + if (c->dc->desc->is_xlcdc) > + state->dpi = cur->dpi; > > return &state->base; > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel