From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() forCONFIG_THUMB2_KERNEL
Date: Tue, 7 Dec 2010 11:58:47 +0530 [thread overview]
Message-ID: <a86d8e4b47fad17e71d0202f3c469868@mail.gmail.com> (raw)
In-Reply-To: <1291656937-24992-3-git-send-email-dave.martin@linaro.org>
Dave,
> -----Original Message-----
> From: linaro-dev-bounces at lists.linaro.org [mailto:linaro-dev-
> bounces at lists.linaro.org] On Behalf Of Dave Martin
> Sent: Monday, December 06, 2010 11:06 PM
> To: linux-arm-kernel at lists.infradead.org
> Cc: Tony Lindgren; Dave Martin; linux-omap at vger.kernel.org; linaro-
> dev at lists.linaro.org
> Subject: [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi()
> forCONFIG_THUMB2_KERNEL
>
> For the Thumb-2 case, the "wfi" mnemonic is used, since in this
> case the tools will necessarily be new enough to support it.
>
> Signed-off-by: Dave Martin <dave.martin@linaro.org>
> ---
> KernelVersion: 2.6.37-rc4
The choice of opcode instead of instruction here was not because
of toolchain. The problem was it breaks multi-omap build where
ARMv6 and ARMv7 are build together.
For this reason I NAK this patch.
>
> arch/arm/mach-omap2/include/mach/omap4-common.h | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/include/mach/omap4-common.h
> b/arch/arm/mach-omap2/include/mach/omap4-common.h
> index 2744dfe..c6b1320 100644
> --- a/arch/arm/mach-omap2/include/mach/omap4-common.h
> +++ b/arch/arm/mach-omap2/include/mach/omap4-common.h
> @@ -17,8 +17,13 @@
> * wfi used in low power code. Directly opcode is used instead
> * of instruction to avoid mulit-omap build break
> */
> +#ifdef CONFIG_THUMB2_KERNEL
> +#define do_wfi() \
> + __asm__ __volatile__ ("wfi" : : : "memory")
> +#else
> #define do_wfi() \
> __asm__ __volatile__ (".word 0xe320f003" : : :
"memory")
> +#endif
>
> #ifdef CONFIG_CACHE_L2X0
> extern void __iomem *l2cache_base;
> --
> 1.7.1
>
>
> _______________________________________________
> linaro-dev mailing list
> linaro-dev at lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/linaro-dev
next prev parent reply other threads:[~2010-12-07 6:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 17:35 [PATCH v2 0/3] ARM: omap: Thumb-2 kernel compatibility fixes Dave Martin
2010-12-06 17:35 ` [PATCH v2 1/3] ARM: omap: Enable low-level omap3 PM code to work with CONFIG_THUMB2_KERNEL Dave Martin
2010-12-06 18:17 ` Catalin Marinas
2010-12-06 18:41 ` Dave Martin
2010-12-07 6:31 ` [PATCH v2 1/3] ARM: omap: Enable low-level omap3 PM code to work withCONFIG_THUMB2_KERNEL Santosh Shilimkar
2010-12-07 10:16 ` Dave Martin
2010-12-07 11:59 ` Jean Pihet
2010-12-07 14:53 ` Dave Martin
2010-12-07 14:55 ` Dave Martin
2010-12-07 19:15 ` Nicolas Pitre
2010-12-08 10:24 ` Dave Martin
2010-12-08 16:56 ` Nicolas Pitre
2010-12-06 17:35 ` [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() for CONFIG_THUMB2_KERNEL Dave Martin
2010-12-07 6:28 ` Santosh Shilimkar [this message]
2010-12-07 16:50 ` [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() forCONFIG_THUMB2_KERNEL Dave Martin
2010-12-07 19:29 ` Russell King - ARM Linux
2010-12-08 11:40 ` Dave Martin
2010-12-08 5:57 ` Santosh Shilimkar
2010-12-08 5:59 ` Santosh Shilimkar
2010-12-08 10:40 ` Dave Martin
2010-12-08 10:45 ` Santosh Shilimkar
2010-12-08 11:05 ` Dave Martin
2010-12-08 11:10 ` Santosh Shilimkar
2010-12-08 11:25 ` Dave Martin
2010-12-06 17:35 ` [PATCH v2 3/3] ARM: omap4: Convert END() to ENDPROC() for correct linkage with CONFIG_THUMB2_KERNEL Dave Martin
2010-12-07 6:29 ` [PATCH v2 3/3] ARM: omap4: Convert END() to ENDPROC() for correctlinkage " Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a86d8e4b47fad17e71d0202f3c469868@mail.gmail.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).