From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53A41E7542B for ; Tue, 3 Oct 2023 06:49:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Us8/8FTByB6freNeCY2V7yosaWL/daHaPO6IhROjAO8=; b=2UmGvb+imRXQyD sPZRqhZ4NDXBN9H8ESp33hMnclWPO9i/kVEo2/sh+iCO9ADhIxSxNSerxLd21AMH3ijG9lTjVbnVK TDlXYvaKB9AWZ5llxkagKFrhsoT6K6rw3lcKqvSXuigAfRiB7nw5WUWWkeIhZWxIKNIvChtsX3fq7 vgdKmPtNfzogwkTvvJbMh6Gwy2uKQKvnNYHcotE/ezYX3bRKkbMu/zFqc7cXdrRu4i9rERPNPbOx3 h1m90fdojKytsvEulmhpIZEDsP4dG23Igjn3bxlroSno75Ephnu0HuSJ9HOFTBqLKMU4HT2u+JkOF 7JPEYCXtCFpRSwd6pKHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qnZD7-00DwL5-00; Tue, 03 Oct 2023 06:48:49 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qnZD3-00DwKg-08 for linux-arm-kernel@lists.infradead.org; Tue, 03 Oct 2023 06:48:47 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3936mV70002180; Tue, 3 Oct 2023 01:48:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1696315711; bh=L8cq9ILA9YOFfOTbj/R2hPdyw38+X5l8GX2variqNi8=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=nTaMkc6+Vl+dsPdyJQfH6ifS+pfB2L1XQlQ+8ZNFPNqXppaG9FQsQ8e5yJmyLwloD TbymWz5VZLfBMH71yZQl9iMdhC/YiROE3OJrKAtYUvbGBFYZRbKsAWhLxn/yICC54h CyquA27Vpmru/8AZQtpZa9xI8HybKQvT2D3NtP7Q= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3936mU7G077467 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 3 Oct 2023 01:48:30 -0500 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 3 Oct 2023 01:48:30 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 3 Oct 2023 01:48:30 -0500 Received: from [172.24.227.94] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3936mRUx021423; Tue, 3 Oct 2023 01:48:27 -0500 Message-ID: Date: Tue, 3 Oct 2023 12:18:26 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v6 4/7] arm64: dts: ti: k3-j784s4-main: Add the main domain watchdog instances Content-Language: en-US To: Keerthy , , , , , CC: , , , References: <20230927023357.9883-1-j-keerthy@ti.com> <20230927023357.9883-5-j-keerthy@ti.com> From: Vignesh Raghavendra In-Reply-To: <20230927023357.9883-5-j-keerthy@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231002_234845_223160_F1D43BC1 X-CRM114-Status: GOOD ( 12.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/09/23 08:03, Keerthy wrote: > + /* > + * The following RTI instances are coupled with MCU R5Fs, c7x and > + * GPU so keeping them disabled as these will be used by their > + * respective firmware > + */ > + watchdog16: watchdog@2300000 { > + compatible = "ti,j7-rti-wdt"; > + reg = <0x00 0x2300000 0x00 0x100>; > + clocks = <&k3_clks 356 1>; > + power-domains = <&k3_pds 356 TI_SCI_PD_EXCLUSIVE>; > + assigned-clocks = <&k3_clks 356 0>; > + assigned-clock-parents = <&k3_clks 356 4>; > + status = "disabled"; > + }; > + > + watchdog17: watchdog@2310000 { > + compatible = "ti,j7-rti-wdt"; > + reg = <0x00 0x2310000 0x00 0x100>; > + clocks = <&k3_clks 357 1>; > + power-domains = <&k3_pds 357 TI_SCI_PD_EXCLUSIVE>; > + assigned-clocks = <&k3_clks 357 0>; > + assigned-clock-parents = <&k3_clks 357 4>; > + status = "disabled"; > + }; > + > + watchdog18: watchdog@2320000 { > + compatible = "ti,j7-rti-wdt"; > + reg = <0x00 0x2320000 0x00 0x100>; > + clocks = <&k3_clks 358 1>; > + power-domains = <&k3_pds 358 TI_SCI_PD_EXCLUSIVE>; > + assigned-clocks = <&k3_clks 358 0>; > + assigned-clock-parents = <&k3_clks 358 4>; > + status = "disabled"; > + }; > + > + watchdog19: watchdog@2330000 { > + compatible = "ti,j7-rti-wdt"; > + reg = <0x00 0x2330000 0x00 0x100>; > + clocks = <&k3_clks 359 1>; > + power-domains = <&k3_pds 359 TI_SCI_PD_EXCLUSIVE>; > + assigned-clocks = <&k3_clks 359 0>; > + assigned-clock-parents = <&k3_clks 359 4>; > + status = "disabled"; > + }; > + > + watchdog15: watchdog@22f0000 { I understand you are arranging based on Firmware Device ID. But these numbers don't have much meaning when user maps to TRM. So, I suggest nodes to be arranged by TRM numbering or ascending order of register address so that its easier for end user to map the nodes to IP instance in TRM. > + compatible = "ti,j7-rti-wdt"; > + reg = <0x00 0x22f0000 0x00 0x100>; > + clocks = <&k3_clks 360 1>; > + power-domains = <&k3_pds 360 TI_SCI_PD_EXCLUSIVE>; > + assigned-clocks = <&k3_clks 360 0>; > + assigned-clock-parents = <&k3_clks 360 4>; > + status = "disabled"; > + }; > + > + watchdog28: watchdog@23c0000 { > + compatible = "ti,j7-rti-wdt"; > + reg = <0x00 0x23c0000 0x00 0x100>; > + clocks = <&k3_clks 361 1>; > + power-domains = <&k3_pds 361 TI_SCI_PD_EXCLUSIVE>; > + assigned-clocks = <&k3_clks 361 0>; > + assigned-clock-parents = <&k3_clks 361 4>; > + status = "disabled"; > + }; > + > + watchdog29: watchdog@23d0000 { > + compatible = "ti,j7-rti-wdt"; > + reg = <0x00 0x23d0000 0x00 0x100>; > + clocks = <&k3_clks 362 1>; > + power-domains = <&k3_pds 362 TI_SCI_PD_EXCLUSIVE>; > + assigned-clocks = <&k3_clks 362 0>; > + assigned-clock-parents = <&k3_clks 362 4>; > + status = "disabled"; > + }; > + > + watchdog30: watchdog@23e0000 { > + compatible = "ti,j7-rti-wdt"; > + reg = <0x00 0x23e0000 0x00 0x100>; > + clocks = <&k3_clks 363 1>; > + power-domains = <&k3_pds 363 TI_SCI_PD_EXCLUSIVE>; > + assigned-clocks = <&k3_clks 363 0>; > + assigned-clock-parents = <&k3_clks 363 4>; > + status = "disabled"; > + }; > + > + watchdog31: watchdog@23f0000 { > + compatible = "ti,j7-rti-wdt"; > + reg = <0x00 0x23f0000 0x00 0x100>; > + clocks = <&k3_clks 364 1>; > + power-domains = <&k3_pds 364 TI_SCI_PD_EXCLUSIVE>; > + assigned-clocks = <&k3_clks 364 0>; > + assigned-clock-parents = <&k3_clks 364 4>; > + status = "disabled"; > + }; > + > + watchdog32: watchdog@2540000 { > + compatible = "ti,j7-rti-wdt"; > + reg = <0x00 0x2540000 0x00 0x100>; > + clocks = <&k3_clks 365 1>; > + power-domains = <&k3_pds 365 TI_SCI_PD_EXCLUSIVE>; > + assigned-clocks = <&k3_clks 365 0>; > + assigned-clock-parents = <&k3_clks 366 4>; > + status = "disabled"; > + }; > + > + watchdog33: watchdog@2550000 { > + compatible = "ti,j7-rti-wdt"; > + reg = <0x00 0x2550000 0x00 0x100>; > + clocks = <&k3_clks 366 1>; > + power-domains = <&k3_pds 366 TI_SCI_PD_EXCLUSIVE>; > + assigned-clocks = <&k3_clks 366 0>; > + assigned-clock-parents = <&k3_clks 366 4>; > + status = "disabled"; > + }; > }; > -- 2.17.1 -- Regards Vignesh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel