From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61DE0C7115B for ; Tue, 24 Jun 2025 00:32:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gPeP8du2qBa6yFfD4N13fXz74Emk3SySRJAz2DZwT+g=; b=KJtEpV3ert7dRtCEzkL4sNleYj xV76En5LPW7PZlh/MYT2bzgGojhdr8AuGRw08ameX67ZyyqSbquyorVtOHaTIxJdB+pXEIblFamhg B/3HTAUQU51oXqVQTMkBiGgf9xpkODy2AWOVMsu770k7EyCEpbGzj/GahS9SH+flO+uiASwFQbR/Q Yu/sx2OXJJnPwY0xHgwf0q3zbqHZsjpdnfkEGioW/lf0bGj6wGrRN70rg2vO4v3MdNazN/B7CN1WV d6lL+5EHmYXd2xCvZdv6ASvxiq/UONOYSnwzPbq8KACRZd9Nda6Wd2ZM+jhGCn6JPySpzXTi/W38w 1vE7hPEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uTraJ-00000004GOl-1GRA; Tue, 24 Jun 2025 00:32:24 +0000 Received: from out-174.mta0.migadu.com ([2001:41d0:1004:224b::ae]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uTmE1-00000003k5T-0OJC for linux-arm-kernel@lists.infradead.org; Mon, 23 Jun 2025 18:49:03 +0000 Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1750704537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gPeP8du2qBa6yFfD4N13fXz74Emk3SySRJAz2DZwT+g=; b=PXieTfFNnH2x0MB6xi3e+6LGZLqrOxLZI3i0CcOdyGfCvdjd7oBe6wW/zwNLrAyB877f21 ejPCyCi4UknfuJ1Xgqn8myevhtFm14NvQVD9OS0Q/Am4s6Dc+xdwaO3JAtIQ1BLfv3DdhU bKacHtVK2GuqyI7UQ2SIZtfsr58L+QE= Date: Mon, 23 Jun 2025 14:48:53 -0400 MIME-Version: 1.0 Subject: Re: [PATCH net 4/4] net: axienet: Split into MAC and MDIO drivers To: Andrew Lunn Cc: Radhey Shyam Pandey , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Greg Kroah-Hartman , Michal Simek , Saravana Kannan , Leon Romanovsky , Dave Ertman , linux-kernel@vger.kernel.org, Ira Weiny , linux-arm-kernel@lists.infradead.org References: <20250619200537.260017-1-sean.anderson@linux.dev> <20250619200537.260017-5-sean.anderson@linux.dev> <16ebbe27-8256-4bbf-ad0a-96d25a3110b2@lunn.ch> <0854ddee-1b53-472c-a4fe-0a345f65da65@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250623_114901_578283_1657B929 X-CRM114-Status: GOOD ( 17.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/23/25 14:27, Andrew Lunn wrote: > On Mon, Jun 23, 2025 at 11:16:08AM -0400, Sean Anderson wrote: >> On 6/21/25 03:33, Andrew Lunn wrote: >> > On Thu, Jun 19, 2025 at 04:05:37PM -0400, Sean Anderson wrote: >> >> Returning EPROBE_DEFER after probing a bus may result in an infinite >> >> probe loop if the EPROBE_DEFER error is never resolved. >> > >> > That sounds like a core problem. I also thought there was a time >> > limit, how long the system will repeat probes for drivers which defer. >> > >> > This seems like the wrong fix to me. >> >> I agree. My first attempt to fix this did so by ignoring deferred probes >> from child devices, which would prevent "recursive" loops like this one >> [1]. But I was informed that failing with EPROBE_DEFER after creating a >> bus was not allowed at all, hence this patch. > > O.K. So why not change the order so that you know you have all the > needed dependencies before registering the MDIO bus? > > Quoting your previous email: > >> Returning EPROBE_DEFER after probing a bus may result in an infinite >> probe loop if the EPROBE_DEFER error is never resolved. For example, >> if the PCS is located on another MDIO bus and that MDIO bus is >> missing its driver then we will always return EPROBE_DEFER. > > Why not get a reference on the PCS device before registering the MDIO > bus? Because the PCS may be on the MDIO bus. This is probably the most-common case. --Sean