From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A181EEB64DA for ; Wed, 19 Jul 2023 05:58:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QqSMDIFvGkHfDM/R/FR78eMwfaTQaYTiWBHYYYKcXdg=; b=ofNrjBq0g/yvLj 2bRDrWoCGI0mwcTC9pEijtmsTJv03O62k/hSaGPQJUTxKDhqJtG1GKPFNVK6mdXEx8B2BSWuVcw+a lm1tjGbqOHglvul3EIYhvCpMmce2HW4Ji7B5hPYy+xGb4ak8cnG7d3VaiVAVGY73GdxOBRg64zKKQ 2hbCUqx+ZhSfA9rNol2vaYaMe9keek9H9oNPzWXZNbAQ2NMY7CsPTO7jGW2bhOqJXd+/SWRjRM/QY X34xY+r3wtFsW2nSoCVZ8ZMjuIZraJSiSETUFAndN+ULQSYJjBH8YI0oQANaFjQk89hKRADgbp3jM QAQHLqEeAmkiUroA9F+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qM0CK-005Tz1-15; Wed, 19 Jul 2023 05:58:04 +0000 Received: from desiato.infradead.org ([90.155.92.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qM0Bd-005TZX-0o for linux-arm-kernel@bombadil.infradead.org; Wed, 19 Jul 2023 05:57:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=OtPAFim1cDpcp/PLXUaQwLiMk8Vxwyxo/NiSi3JW/f0=; b=oJHiz5aDUUsBv7GgdxbJe2kow2 uJFVp1RJyiBMLzOzvJCaJAg9Ef+O/fec/SHTeYsAE8xSvtm6RTwqo+G6ylIeapnT/8vIMLPpqMlOp e6ibJWT/wzbLaKhjf/MvVUxp0KWxa8Cn487LnWDKV/uDoRR5HLSSxfgKkp6SuiK3PcLkWDWDH1/Ny PhtFhc7Lrnmo6UeWoO7ofezXdC4qSH9d1VUHSVSP/C97ogej5kR5GSEIgaD5CsO5ESJnUS+kRVmSw xd3HPFvd56lDaYMa2IiQE8wTviYX9fOXeuMq2jCqxqOYm7zUuaZ4bUR139NRnC2X82DmgL4L+dX4C UQwjJfZw==; Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qLii1-00BSgi-2E for linux-arm-kernel@lists.infradead.org; Tue, 18 Jul 2023 11:17:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689679055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OtPAFim1cDpcp/PLXUaQwLiMk8Vxwyxo/NiSi3JW/f0=; b=TjVjCONXNajXgq5t1XpGWWJwqQE3zgXQjCg0K8E+SWHmIxEnOwq4QE6xQ9T6ov3dnKM26S pFKwtlZH559Cbh0V8UIaezc9Kxd+hXAuJ5ZTu1478VQg1xefgwE42jCOUzfeOHM8W5PPMq rhrvzYxbt/XtWrIZPffGjlRoEzuj9oE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689679056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OtPAFim1cDpcp/PLXUaQwLiMk8Vxwyxo/NiSi3JW/f0=; b=RkL8vKx2Zd5iNYwkoYmbri21xrOpVc6+nICWn9MPe54SkRMfveTX2AvKmaFsYdFclTpapH G/NIRqMS+3KIJY5IaMhpzLwok1gquEHQcKZCOz1pOUcy+cw0vVKMcuYEEFpZUzhbdh5Bfp fuB4Ii5KB1rOXmrZmL9ijeim9pScdXI= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-60--SOwuFXdP1OgEIg0AgYvlA-1; Tue, 18 Jul 2023 07:17:34 -0400 X-MC-Unique: -SOwuFXdP1OgEIg0AgYvlA-1 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-543c2538071so769013a12.1 for ; Tue, 18 Jul 2023 04:17:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689679053; x=1692271053; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OtPAFim1cDpcp/PLXUaQwLiMk8Vxwyxo/NiSi3JW/f0=; b=fSU9ZcjGlXqgmVLDy3uci00h7zRBRnuXH1ULATdyyMmRzvPXwTgvVjjFxlnRVVfw05 2700Z6QXzfiS8Q5+L4OMRbqR9X4nJeBj5gOmgCB8aTggzhnsvyHKi0kjB0xXG+t2AYV3 5We+1A1fYAoT265NoBbM9hSRyrgZs+Wi9ZoJggcKmjnRbze9Uq796TCKeIpsAzGBapQY l66b9GrwXNv2l4a9DVdndMDIdIgyJno6ZDDcCGAOI4zzirpTlxrTJOJ6rNLoHrddx8Z3 pdP2CrZ1g0XY2Ch5ZsYXLJCTK4+M4obPJ15sk9bzLTV7jfNlAZbj7aYxVAAdKs/og+Cl boMQ== X-Gm-Message-State: ABy/qLYcNMWcW8ax7W5KhkpqwI43eM52Go7pjonHKH7goZ9XdNH+UF1a lx8KFrlxhVGzp2U6AZRntLDqw51CtL0LoND74gCzj0irpngtUzXIGyfxSKGDWTGtySwUJ/2zqK3 uMP6F9s+All89Zcz0pN8gwc97O/OOUKtzvlo= X-Received: by 2002:a05:6a20:3d07:b0:133:89e:bf1a with SMTP id y7-20020a056a203d0700b00133089ebf1amr12988277pzi.4.1689679053253; Tue, 18 Jul 2023 04:17:33 -0700 (PDT) X-Google-Smtp-Source: APBJJlGlX4aGknKfPCjhtPs4zbhCwYUKXUWNkmQcI4lBrRW+0354cqKkBfpbN1eJEAJfM+P9UQWRbQ== X-Received: by 2002:a05:6a20:3d07:b0:133:89e:bf1a with SMTP id y7-20020a056a203d0700b00133089ebf1amr12988260pzi.4.1689679052990; Tue, 18 Jul 2023 04:17:32 -0700 (PDT) Received: from [10.72.112.40] ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id k22-20020aa792d6000000b00682868714fdsm1369203pfa.95.2023.07.18.04.17.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jul 2023 04:17:32 -0700 (PDT) Message-ID: Date: Tue, 18 Jul 2023 19:17:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v6 10/11] KVM: arm64: Invalidate the table entries upon a range To: Raghavendra Rao Ananta , Oliver Upton , Marc Zyngier , James Morse , Suzuki K Poulose Cc: Paolo Bonzini , Sean Christopherson , Huacai Chen , Zenghui Yu , Anup Patel , Atish Patra , Jing Zhang , Colton Lewis , David Matlack , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Gavin Shan References: <20230715005405.3689586-1-rananta@google.com> <20230715005405.3689586-11-rananta@google.com> From: Shaoqin Huang In-Reply-To: <20230715005405.3689586-11-rananta@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230718_121738_145864_45075310 X-CRM114-Status: GOOD ( 18.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/15/23 08:54, Raghavendra Rao Ananta wrote: > Currently, during the operations such as a hugepage collapse, > KVM would flush the entire VM's context using 'vmalls12e1is' > TLBI operation. Specifically, if the VM is faulting on many > hugepages (say after dirty-logging), it creates a performance > penalty for the guest whose pages have already been faulted > earlier as they would have to refill their TLBs again. > > Instead, leverage kvm_tlb_flush_vmid_range() for table entries. > If the system supports it, only the required range will be > flushed. Else, it'll fallback to the previous mechanism. > > Signed-off-by: Raghavendra Rao Ananta > Reviewed-by: Gavin Shan Reviewed-by: Shaoqin Huang > --- > arch/arm64/kvm/hyp/pgtable.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > index 5d14d5d5819a..5ef098af1736 100644 > --- a/arch/arm64/kvm/hyp/pgtable.c > +++ b/arch/arm64/kvm/hyp/pgtable.c > @@ -806,7 +806,8 @@ static bool stage2_try_break_pte(const struct kvm_pgtable_visit_ctx *ctx, > * evicted pte value (if any). > */ > if (kvm_pte_table(ctx->old, ctx->level)) > - kvm_call_hyp(__kvm_tlb_flush_vmid, mmu); > + kvm_tlb_flush_vmid_range(mmu, ctx->addr, > + kvm_granule_size(ctx->level)); > else if (kvm_pte_valid(ctx->old)) > kvm_call_hyp(__kvm_tlb_flush_vmid_ipa, mmu, > ctx->addr, ctx->level); -- Shaoqin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel