From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97191D1814B for ; Tue, 15 Oct 2024 14:48:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dTOzRJXoYvbxUyohvN943MiezBmjJyS6cKCc+PEBZPo=; b=CXDheJqegwOau6RACCcBC97+0s Dnza1LDV3WmkyGQUJDFcMdBd03btssy9Mt9Z5TBk8/DO89JiohT7ymm2dLzEzdTJrcUHTTLne0x0U y+YUxK+OqqpsJlDBxQNvmy9rq/GVeshthhjAXH7imhL1JhjxghnFlC88kJTg9Y7G2Kklw/d4ymIGz s+UaEFy0Bb7cE+PqtfPp8T2ONsa1Jwmezd+jSBZ/8heOemnzkUYGv8eMrjtsOkn+xh53pgu2hBR9M 1Z0s6qH/er/RXqVVqhdn+KdRzC2J2J61mJ8YvH1kOwP9Ar845JYLx8Bu9weV6NqTgoVy2dlBWw3YY obnfGlLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0iqu-00000008ZYN-17Jg; Tue, 15 Oct 2024 14:48:48 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0ipU-00000008ZKp-3dqp for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2024 14:47:22 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 37591FEC; Tue, 15 Oct 2024 07:47:43 -0700 (PDT) Received: from [10.57.87.12] (unknown [10.57.87.12]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 731B63F71E; Tue, 15 Oct 2024 07:47:11 -0700 (PDT) Message-ID: Date: Tue, 15 Oct 2024 15:47:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 0/2] iommu/arm-smmu-v3: bypass streamid zero on i.MX95 To: "Peng Fan (OSS)" , Will Deacon , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Joy Zou , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan , Jason Gunthorpe References: <20241015-smmuv3-v1-0-e4b9ed1b5501@nxp.com> From: Robin Murphy Content-Language: en-GB In-Reply-To: <20241015-smmuv3-v1-0-e4b9ed1b5501@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241015_074721_031893_81B90E5E X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024-10-15 4:14 am, Peng Fan (OSS) wrote: > i.MX95 eDMA3 connects to DSU ACP, supporting dma coherent memory to > memory operations. However TBU is in the path between eDMA3 and ACP, > need to bypass the default SID 0 to make eDMA3 work properly. I'm confused, why not just describe that the device owns this StreamID in the DT the normal way, i.e, "iommus = <&smmu 0>;"? Thanks, Robin. > I was also thinking to introduce "bypass-sids = <0xA 0xB 0xC ...>" to > make this reusable for others, but not sure. I could switch to > "bypass-sids" if you prefer. > > Signed-off-by: Peng Fan > --- > Peng Fan (2): > dt-bindings: iommu: arm,smmu-v3: introduce nxp,imx95-bypass-sid-zero > iommu/arm-smmu-v3: Bypass SID0 for NXP i.MX95 > > .../devicetree/bindings/iommu/arm,smmu-v3.yaml | 4 ++++ > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 19 ++++++++++++++++--- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 1 + > 3 files changed, 21 insertions(+), 3 deletions(-) > --- > base-commit: d61a00525464bfc5fe92c6ad713350988e492b88 > change-id: 20241014-smmuv3-120b24bc4659 > > Best regards,