From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jammy Huang <jammy_huang@aspeedtech.com>,
jassisinghbrar@gmail.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: mailbox: Add ASPEED AST2700 series SoC
Date: Tue, 3 Jun 2025 11:52:00 +0200 [thread overview]
Message-ID: <a8c4ec8e-51bb-48f3-a47a-b7a848a44951@kernel.org> (raw)
In-Reply-To: <273da934-deeb-4129-917c-5d7038930941@kernel.org>
On 03/06/2025 11:22, Krzysztof Kozlowski wrote:
>> +required:
>> + - compatible
>> + - reg
>> + - interrupts
>> + - "#mbox-cells"
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/irq.h>
>> +
>> + mbox@12c1c200 {
>
> mailbox@
>
> With these fixed:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Huh, not tested.... so obviously un-reviewed.
Test your code BEFORE you send, not via community services.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-03 10:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 7:54 [PATCH v1 0/2] ASPEED: Add mailbox driver for AST2700 series Jammy Huang
2025-06-03 7:54 ` [PATCH v1 1/2] dt-bindings: mailbox: Add ASPEED AST2700 series SoC Jammy Huang
2025-06-03 9:22 ` Krzysztof Kozlowski
2025-06-03 9:52 ` Krzysztof Kozlowski [this message]
2025-06-04 0:46 ` Jammy Huang
2025-06-03 9:42 ` Rob Herring (Arm)
2025-06-04 0:45 ` Jammy Huang
2025-06-03 7:54 ` [PATCH v1 2/2] mailbox: aspeed: add mailbox driver for AST27XX " Jammy Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8c4ec8e-51bb-48f3-a47a-b7a848a44951@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jammy_huang@aspeedtech.com \
--cc=jassisinghbrar@gmail.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox