From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27656C433FE for ; Mon, 30 May 2022 08:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hoex+8iI2hBgpbfDspmfl5vqSy8EaOswxjJzjiue8dQ=; b=b3RtzNQOuabcma gW0rc9JdpzmdBsQcZ1+aMF4yYkapIeTtZomTj6FR/DqniJLoHto7dJFH5T81ijDoEFXpRu9Ygs3ve syopSvD9MyzV/4Jwu78aTT+xHA7fGNEe7jh9NcwA9t8TXKP/kvyt24jM6GQg7FbwgOLHz+o9Lj6N+ RJuO4/f3TBTgz85HhWcxNhBsWb/JgPREFwVqYTxg/BJgs7D8uJF2Sjl1doF7iLWOQSF8YGXe5acAs p2wKvbTsIm++7vEAUhCyhZZVs67aABojhUnO7gyQ/V4RzywAH9Amhu0Ew0Ue+mzj1FDFVVopHiIIy MWV1YHCqatPAjhDh+HlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nvb9R-00610j-3i; Mon, 30 May 2022 08:53:25 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nvb9N-0060xH-IB for linux-arm-kernel@lists.infradead.org; Mon, 30 May 2022 08:53:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653900796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RhvgJCFXfv5RG+0oVTAct7gmCCzDguggkQSBJ+VAo/A=; b=jUyl4v1DIWAxH3aJqAMDe2eFcp+t5N+xnWazHJK9G1SJ6M8wapKhb4q4FdgAQ0PviY4tkj WnE+rhJtp8eg828swerCQeZw0nvX2gZf5/nkLk155V5kMHGm6wU7wBibSYFWU/E+rFnjw2 rWQ8Q2z93dAej3YQ5T55T3HFtgWP5Qk= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-577-YBk__BrcMe6il5jqJY55ag-1; Mon, 30 May 2022 04:53:14 -0400 X-MC-Unique: YBk__BrcMe6il5jqJY55ag-1 Received: by mail-ej1-f72.google.com with SMTP id ks1-20020a170906f84100b006fee53b22c2so3824801ejb.10 for ; Mon, 30 May 2022 01:53:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=RhvgJCFXfv5RG+0oVTAct7gmCCzDguggkQSBJ+VAo/A=; b=rALHY3ObMYpRyV1u0KhDSJqxzFb/AxF0773PR/cxwrNWGQHMjmIiyRg9xaca07XZ4C ry1D8JGF0CCUK3jnhjMDfM8tjEC1kBPLx3O3JyDdQy2itk73/qyQyNncEf3xEf+GyKmM lXoRnzT51Yzh2wD/OZdqdwc7k5Zh9TBZx8xAP/AOu7+Kh+47IqKXyJzuEE47rL1JLII2 hyMcRF6Vln34PAeK5Tntart4JIUGX9HpnG8H5iNoM84NRLHr0CMrOmKyfOMNVVj58JSt g2NGNnRU38C2iYb56XvSfn17xADNX7uPVq99+IAKpV3Hgiwx0SJdIgPBKTuw5/Eb4Pmc /WWQ== X-Gm-Message-State: AOAM532te6o7hRPVNZBtndcddfJ3oLiuagj50Oeg53Zvl36ekczEQtwi teBgPGQPoe7sGzHvqR1Zy12rR0oopGCm47rn7YbdA48P7EsWe9wxLzxZqbOeB6VGw5n6GWcyyK5 0su+bNV6LaQcANqrdQWokV1BHNJnFcrY4zaU= X-Received: by 2002:a17:907:6e20:b0:6ff:1541:8d34 with SMTP id sd32-20020a1709076e2000b006ff15418d34mr20498802ejc.447.1653900793058; Mon, 30 May 2022 01:53:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLS9X1+J2YlCZd50xUKza5F2TAaKjqsoBWgZZta9P6P5hLJgXAWFm13+BAHE9yuTPrdLSHXw== X-Received: by 2002:a17:907:6e20:b0:6ff:1541:8d34 with SMTP id sd32-20020a1709076e2000b006ff15418d34mr20498786ejc.447.1653900792873; Mon, 30 May 2022 01:53:12 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id v16-20020a1709062f1000b006fea2705d18sm3807438eji.210.2022.05.30.01.53.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 May 2022 01:53:12 -0700 (PDT) Message-ID: Date: Mon, 30 May 2022 10:53:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v10 0/4] Separate panel orientation property creating and value setting To: Hsin-Yi Wang , dri-devel@lists.freedesktop.org, David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: Rob Clark , Stephen Boyd , Douglas Anderson , Chun-Kuang Hu , Sean Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Simon Ser , Harry Wentland , Alex Deucher , Jani Nikula , Emil Velikov References: <20220530081910.3947168-1-hsinyi@chromium.org> From: Hans de Goede In-Reply-To: <20220530081910.3947168-1-hsinyi@chromium.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220530_015321_707526_5CD3905A X-CRM114-Status: GOOD ( 20.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 5/30/22 10:19, Hsin-Yi Wang wrote: > Some drivers, eg. mtk_drm and msm_drm, rely on the panel to set the > orientation. Panel calls drm_connector_set_panel_orientation() to create > orientation property and sets the value. However, connector properties > can't be created after drm_dev_register() is called. The goal is to > separate the orientation property creation, so drm drivers can create it > earlier before drm_dev_register(). Sorry for jumping in pretty late in the discussion (based on the v10 I seem to have missed this before). This sounds to me like the real issue here is that drm_dev_register() is getting called too early? To me it seems sensible to delay calling drm_dev_register() and thus allowing userspace to start detecting available displays + features until after the panel has been probed. I see a devicetree patch in this series, so I guess that the panel is described in devicetree. Especially in the case of devicetree I would expect the kernel to have enough info to do the right thing and make sure the panel is probed before calling drm_dev_register() ? Regards, Hans > > After this series, drm_connector_set_panel_orientation() works like > before. It won't affect existing callers of > drm_connector_set_panel_orientation(). The only difference is that > some drm drivers can call drm_connector_init_panel_orientation_property() > earlier. > > Hsin-Yi Wang (4): > gpu: drm: separate panel orientation property creating and value > setting > drm/mediatek: init panel orientation property > drm/msm: init panel orientation property > arm64: dts: mt8183: Add panel rotation > > .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + > drivers/gpu/drm/drm_connector.c | 58 ++++++++++++++----- > drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++ > drivers/gpu/drm/msm/dsi/dsi_manager.c | 4 ++ > include/drm/drm_connector.h | 2 + > 5 files changed, 59 insertions(+), 13 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel