From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 421CEC636CC for ; Thu, 16 Feb 2023 11:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aRKtC4aDuPGZfv/B8SS7QDyGJxNYa5LNeKgtKjIfsKI=; b=gLfPAfuu6mILUH enpHDdl6PebzFm4q6JqQi9HB/9yJ3GKwsQ7/rgJciFX60bZQmB50dVAuJbXrbYq9drMGbblLLg1rV /jwTf4LrQGa6i/3Qp2ajGA7NSg8OyeUe9Fi+EzOWJwkzxbIk7w3mjSPNqrHBgNBNp7bS6LKCcAYj1 an1wtHAap8MRN3UBAYwNY4Lt9pRqJxgKeIU9+TTigu+sq8ebMBZgBBd9cVZ/EinWo/DNt1ONIEhiN VqFNzS4lsc2jo0F0aca1U2n0KgA8A74qfTFzFCrTxOb7Uq65LRHvIkHbyFqiTSPx1TrQxbLGove+w faJmNSTFx+1peZMepHpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSc8v-009rEm-KI; Thu, 16 Feb 2023 11:09:38 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSc8r-009rBp-W7 for linux-arm-kernel@lists.infradead.org; Thu, 16 Feb 2023 11:09:35 +0000 Received: by mail-ed1-x533.google.com with SMTP id t16so2206023edd.10 for ; Thu, 16 Feb 2023 03:09:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=R3iiqH06nUTpPWYilgK2IFHj13BbO9uCZQ5Bymri4gs=; b=cmzSs1x1uugc4EQOj+4Gw22iLIlzjJkEO/Pz7kDoPraCLYFaLp7LK7gxHRSb4Rhrxj PXPCvcsjd1LOKa5sC/+YFMAol7I6Gi6WcmqSSNf3J8Vb8dpJEyEwlHJHLJ7Rkd6wgDV1 I4GfUatKxHSck7cIL7jhaQAUuxr2hJ6WECjfITXdl9UGxvQwsnHEjiQiah0j4Pa4Fw4P WbfM/yLLq093PHgwbM5x+UMEqFPhoXiRlvfneB3BP9THB7DmxbDR0suzmIs8kqazRPBT muSRLpK2kvpJWKUtlL5RZ5HSh71t8OJsdD+mOrGnGxaIhAvp598jeJ010eAQwXbzGuMZ B4Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R3iiqH06nUTpPWYilgK2IFHj13BbO9uCZQ5Bymri4gs=; b=yNJYwqAGyegLrI4jtD+n/ugx8gSBLsEW30T0GOb9hrTBMd1NI7FJNdVOfk8/W0IM/R kGRRjUtEoR7SkprG3G2TtsWEHKi89UokqrbKUGBJLJii9ckEmPojCbfnMx+oDDTC27Qo YY9NZZVOyrbI+uSvKj9aGpVCuD/2rahgXVYjX8jd0x1csfRB3wRDkn7SDMu8uCM4/vh5 kWyx+KkIHx001Ur/C7n1gnqUr3xHgwjWEzSqW7Cz367jZg7kn8of6z43C71NUQnR79wj ayWXzuQcD6pDj0etu6jv9ETWVNpKP9c8F82US4hVnmVmOuHjbVH/qnHAILcDb98knpZj GfOg== X-Gm-Message-State: AO0yUKWCIaCq2/GreO0ljlpsAb3wOb62ryWc/haMOMQQieZn3rddx5O+ IGO1iqrEsdwXXxClXBrxH5KlOg== X-Google-Smtp-Source: AK7set+atTYUvsw9Bi58sXSveqCbuDXNoORblsEZyFSBSAF12mVmwb9zx0f0LjR4QO0iZYzNQH+X0w== X-Received: by 2002:aa7:d4c1:0:b0:4ad:6fc6:ae9c with SMTP id t1-20020aa7d4c1000000b004ad6fc6ae9cmr466265edr.17.1676545769139; Thu, 16 Feb 2023 03:09:29 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id b12-20020a50cccc000000b004acc123cd94sm693183edj.30.2023.02.16.03.09.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 03:09:28 -0800 (PST) Message-ID: Date: Thu, 16 Feb 2023 12:09:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 13/16] PCI: samsung: Rename common functions to samsung Content-Language: en-US To: Shradha Todi , lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzysztof.kozlowski+dt@linaro.org, alim.akhtar@samsung.com, jingoohan1@gmail.com, Sergey.Semin@baikalelectronics.ru, lukas.bulwahn@gmail.com, hongxing.zhu@nxp.com, tglx@linutronix.de, m.szyprowski@samsung.com, jh80.chung@samsung.co, pankaj.dubey@samsung.com Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230214121333.1837-1-shradha.t@samsung.com> <20230214121333.1837-14-shradha.t@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20230214121333.1837-14-shradha.t@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230216_030934_078264_C5900355 X-CRM114-Status: GOOD ( 18.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/02/2023 13:13, Shradha Todi wrote: > Use samsung instead of exynos for all common functions > like probe/remove/suspend/resume. > > Suggested-by: Pankaj Dubey > Signed-off-by: Shradha Todi > --- > drivers/pci/controller/dwc/pci-samsung.c | 42 ++++++++++++------------ > 1 file changed, 21 insertions(+), 21 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-samsung.c b/drivers/pci/controller/dwc/pci-samsung.c > index 719d284e1552..dc8ec0b546fd 100644 > --- a/drivers/pci/controller/dwc/pci-samsung.c > +++ b/drivers/pci/controller/dwc/pci-samsung.c > @@ -60,7 +60,7 @@ struct samsung_pcie { > struct regulator_bulk_data supplies[2]; > }; > > -static int exynos_pcie_init_clk_resources(struct samsung_pcie *sp) > +static int samsung_pcie_init_clk_resources(struct samsung_pcie *sp) Same as before - I don't see here benefit. > { > struct device *dev = sp->pci.dev; > int ret; > @@ -74,7 +74,7 @@ static int exynos_pcie_init_clk_resources(struct samsung_pcie *sp) > return clk_bulk_prepare_enable(sp->clk_cnt, sp->clks); > } > (...) > > -static struct platform_driver exynos_pcie_driver = { > - .probe = exynos_pcie_probe, > - .remove = __exit_p(exynos_pcie_remove), > +static struct platform_driver samsung_pcie_driver = { > + .probe = samsung_pcie_probe, > + .remove = __exit_p(samsung_pcie_remove), > .driver = { > - .name = "exynos-pcie", > - .of_match_table = exynos_pcie_of_match, > - .pm = &exynos_pcie_pm_ops, > + .name = "samsung-pcie", This "name" has some point... but I think it would break now all module users. > + .of_match_table = samsung_pcie_of_match, > + .pm = &samsung_pcie_pm_ops, > }, > }; > -module_platform_driver(exynos_pcie_driver); > +module_platform_driver(samsung_pcie_driver); > MODULE_LICENSE("GPL v2"); > -MODULE_DEVICE_TABLE(of, exynos_pcie_of_match); > +MODULE_DEVICE_TABLE(of, samsung_pcie_of_match); Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel