From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD158C433E0 for ; Wed, 29 Jul 2020 08:10:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57423207F5 for ; Wed, 29 Jul 2020 08:10:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jCNPhgwF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57423207F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ftJgO0NRejclds75FFK57aazB417pK3zYZ4ZBzaOk94=; b=jCNPhgwFLEi1Dgt3rseXMl1m6 4vNfJt4pNrt8jHp1v6BII8uwlLyBt90lhaYJkMRRGXBEXvuqkWzgwJmS9OUacjYBf6r5yK/yfh2CI D9ogclh2uXKXoN4eWtvFMJj7KOCGnP1QRnlplhjOHIKVZgGw6byX1up0r9wRxSQ/hzIhH0J2WlD/w MIHLqyaBhDs7Q6SUP5O87qXaLVrXQ2qw0sCDqp3utNALw39un2KUfjKW0SxI72j7Hj4vk7SjBFMtb AL7MYjukXbRIEJ1eMjqAwjJWJxLwljczTDD79tKYYLEM30GJpuErVOfluJkYAOxJ/9Prt2JaCvW2x HWBSdtaRg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0h8B-0008WJ-Tc; Wed, 29 Jul 2020 08:08:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0h7h-0008OQ-Ne for linux-arm-kernel@lists.infradead.org; Wed, 29 Jul 2020 08:07:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 383B631B; Wed, 29 Jul 2020 01:07:33 -0700 (PDT) Received: from [192.168.178.2] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0BD393F71F; Wed, 29 Jul 2020 01:07:24 -0700 (PDT) Subject: Re: [PATCH v2 2/3] sched: Cleanup SCHED_THERMAL_PRESSURE kconfig entry To: Valentin Schneider References: <20200712165917.9168-1-valentin.schneider@arm.com> <20200712165917.9168-3-valentin.schneider@arm.com> <20200727141825.GA4174@lca.pw> <16f8c1d4-778b-3ab8-f328-bae80f3973b4@arm.com> From: Dietmar Eggemann Message-ID: Date: Wed, 29 Jul 2020 10:07:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200729_040740_187301_CDD92123 X-CRM114-Status: GOOD ( 21.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juri Lelli , Vincent Guittot , linux-pm@vger.kernel.org, Peter Zijlstra , Viresh Kumar , Amit Daniel Kachhap , Daniel Lezcano , Russell King , Thara Gopinath , linux-kernel@vger.kernel.org, Qian Cai , Sudeep Holla , Ingo Molnar , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/07/2020 18:16, Valentin Schneider wrote: > > Hi, > > On 27/07/20 18:45, Dietmar Eggemann wrote: >> On 27/07/2020 16:18, Qian Cai wrote: >>> On Sun, Jul 12, 2020 at 05:59:16PM +0100, Valentin Schneider wrote: [...] > I went for having SCHED_THERMAL_PRESSURE in arm64/Kconfig because of where > the discussion went in the original thread ([1] in the changelog). > > One point is that selecting this option requires having the right > infrastructure in place (arch_{set, scale}_thermal_pressure() must be > redefined by the architecture), which cannot be easily expressed in Kconfig > terms. Russell's point was that this is difficult for a lambda user to make > sense of, and Vincent argued that this option should simply be selected at > architecture level, which, given the context, makes sense IMO. > > We could change the arch Kconfig into > > select SCHED_THERMAL_PRESSURE if CPU_FREQ_THERMAL > > but that seems redundant; this dependency is already expressed in > SCHED_THERMAL_PRESSURE's definition. Is there a proper pattern to select > some Kconfig option only if all of its dependencies are met? The warning when disabling CPU_FREQ_THERMAL after make defconfig disappears, so this should be OK. diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 939c4d6bbc2e..a677e71b3d5f 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -46,7 +46,7 @@ config ARM select EDAC_ATOMIC_SCRUB select GENERIC_ALLOCATOR select GENERIC_ARCH_TOPOLOGY if ARM_CPU_TOPOLOGY - select SCHED_THERMAL_PRESSURE if ARM_CPU_TOPOLOGY + select SCHED_THERMAL_PRESSURE if ARM_CPU_TOPOLOGY && CPU_FREQ_THERMAL select GENERIC_ATOMIC64 if CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI select GENERIC_CLOCKEVENTS_BROADCAST if SMP select GENERIC_CPU_AUTOPROBE diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index c403e6f5db86..59ae16f8b941 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -192,7 +192,7 @@ config ARM64 select PCI_SYSCALL if PCI select POWER_RESET select POWER_SUPPLY - select SCHED_THERMAL_PRESSURE + select SCHED_THERMAL_PRESSURE if CPU_FREQ_THERMAL select SPARSE_IRQ select SWIOTLB select SYSCTL_EXCEPTION_TRAC _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel