From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35DD2CCF9F6 for ; Wed, 25 Sep 2024 20:51:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QlLkUfMyGaR3J/tFq0Q4tO38Q45QW/pVzn3fUTjpgHo=; b=FuyJGulph8/fVmBzHPk3dgQMZi k6sjd3FuFHj5wMKrW2gyRkVXHHl2+EdxrFU5iHf9wEEetzu9+T61piTbxpA2PPBHVfFRzPtLx/8Q7 ORp0vKIKWuKovFKyVgDjmvs9JWDzBuw4FuC5XMRXr/heA6K1PvN0yXtkK5TH3m/wTSM+kRrT0r0tu DfJl5JgYzmiazup4J7KIODSGXZPoqhHdopKKFpX6jAUcyXuX0tN7Rqr7U3TVDbauWGAn6bwtJ89RS Dp7v0u5YvTHqT5sSXjc2xyekc7C3nh0Kw9FgEWQj+FJb1lR3Ygu7ermdLgJ39F5TkSv7sOj0iCCSW 85Vs4Edg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stYya-00000006We8-3Alw; Wed, 25 Sep 2024 20:51:08 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stYxP-00000006WNX-1llg for linux-arm-kernel@lists.infradead.org; Wed, 25 Sep 2024 20:49:56 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 79A7A80245; Wed, 25 Sep 2024 22:49:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1727297386; bh=QlLkUfMyGaR3J/tFq0Q4tO38Q45QW/pVzn3fUTjpgHo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Cg4jPDdiMo3vN9bAxn1XcUyC/4/9lvGSNj2YOUIUUhWBtj0iWFFWVIUUuOkZWHFul ESVav5UIaTSN7pgY3zOfiYbC0lYn5vWcFOUabtFc1Edr1TCPHj+hvvD2kAo/PDvhu1 /EjHOIee4sykJjfZXB6jidwvajk376t4gj19//N8MRIQ7xhjzfuL+j5lpV5q3poeSF tsT7voMv935o2E7Z+nekhvB2Gwfi0O6k3nZsJJvkq8Eu6MMelHOu/BGgHSym4glETz RbtdlMnVxOiDgp/2EE2QqKaNZl8c4eNpPeI1Dvg5FRm7w7AevyurQN4e8lojxHN1Kq qiGQF2BBfm9+A== Message-ID: Date: Wed, 25 Sep 2024 21:47:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] gpu: ipu-v3: vdic: Simplify ipu_vdi_setup() To: Philipp Zabel , linux-media@vger.kernel.org Cc: Daniel Vetter , David Airlie , Fabio Estevam , Greg Kroah-Hartman , Helge Deller , Mauro Carvalho Chehab , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Steve Longerbeam , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev References: <20240724002044.112544-1-marex@denx.de> <95efd6b6491069d04b4bfae6616d9a43ba8467a6.camel@pengutronix.de> <546c9dac-39ab-4abe-a495-ab54d6ee925d@denx.de> <75edf945c98a68bf85b13efd1c13549288f56488.camel@pengutronix.de> Content-Language: en-US From: Marek Vasut In-Reply-To: <75edf945c98a68bf85b13efd1c13549288f56488.camel@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240925_134955_609947_0214D714 X-CRM114-Status: GOOD ( 12.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/25/24 6:43 PM, Philipp Zabel wrote: > On Di, 2024-09-24 at 12:47 +0200, Marek Vasut wrote: >> On 9/4/24 11:05 AM, Philipp Zabel wrote: >>> On Mi, 2024-07-24 at 02:19 +0200, Marek Vasut wrote: >>>> The 'code' parameter only ever selects between YUV 4:2:0 and 4:2:2 >>>> subsampling, turn it into boolean to select exactly that and update >>>> related code accordingly. >>>> >>>> Signed-off-by: Marek Vasut >>> >>> I'd prefer this to be an enum ipu_chroma_subsampling or similar, >>> instead of a boolean. Otherwise, >> >> I'm afraid this introduces unnecessary back and forth conversions >> between the boolean and either of the two enum ipu_chroma_subsampling >> values in the code. > > Fair enough. I dislike the opaque usage in vdic_start() a bit, but with > the in422 variable in ipu_mem2mem_vdic_setup_hardware() it is clear > enough. I'll keep the rework for V3 and then we can decide whether or not to undo it.